security group( with rules) as stack resource isn't being tracked by Trove

[Denis M.]

Trove should track security group provisioned by heat

As you can see, taskmanager doesn't perform any associations of security group/rules and instance, prof - [1], but with use_heat = False, taskmanager does it, prof - [2].

Prof:
[1] https://github.com/openstack/trove/blob/master/trove/taskmanager/models.py#L353-L424
[2] https://github.com/openstack/trove/blob/master/trove/taskmanager/models.py#L609-L621

[Denis M. (dmakogon)]

Integration tests are failing due to missing records related ot security groups:

CreateInstance
 Test to create a Database Instance
        test_create OK 0.26
AfterInstanceCreation
        test_database_create_after_create OK 0.04
        test_database_delete_after_create OK 0.59
        test_database_index_after_create OK 0.03
        test_instance_delete_right_after_create OK 0.07
        test_resize_instance_after_create OK 0.63
        test_resize_volume_after_create OK 0.04
        test_root_create_root_user_after_create OK 0.03
        test_root_is_root_enabled_after_create OK 0.03
        test_users_create_after_create OK 0.22
        test_users_delete_after_create OK 0.03
        test_users_index_after_create OK 0.03
WaitForGuestInstallationToFinish
        test_instance_created OK 313.12
SecurityGroupsTest
        setUp ERROR
        test_created_security_group SKIP: Failure in <function setUp at 0x35cbcf8>
        test_get_security_group SKIP: Failure in <function setUp at 0x35cbcf8>
        test_list_security_group SKIP: Failure in <function setUp at 0x35cbcf8>
SecurityGroupsRulesTest
        setUp SKIP: Failure in <function setUp at 0x35cbcf8>
        test_create_security_group_rule SKIP: Failure in <function setUp at 0x35cbcf8>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/96780

[Denis M. (dmakogon)]

Full log
https://gist.github.com/denismakogon/73c9d0d7d9c4b505d3b5

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/96795

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/96780
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=10716b8f1beb11b5acce8f35fad94b943d330eaa
Submitter: Jenkins
Branch: master

commit 10716b8f1beb11b5acce8f35fad94b943d330eaa
Author: Denis Makogon <email address hidden>
Date: Fri May 30 17:40:21 2014 +0300

    Use tcp/udp ports from config for heat templates

    Reasons:
     - Trove should use tcp/upd ports
       from config for rendering heat templates.
    Changes:
     - adding another two rendering parameter:
       - tcp_rules;
       - udp_rules;
     - adding validation for empty rules sets:
       - if no tcp/udp ports were mentioned - no rules will
         be assigned AWS::EC2::SecurityGroup.

    Change-Id: I066aab0e7a32136608e2a6e23999e85bc637debd
    Partial-Bug: #1276228

[Nikhil Manchanda (slicknik)]

https://review.openstack.org/#/c/96795/14 is the change for this bugfix.

[Denis M. (dmakogon)]

Yes. Given patch set was proposed as a fix.

четверг, 17 июля 2014 г. пользователь Nikhil Manchanda написал:

> https://review.openstack.org/#/c/96795/14 is the change for this bugfix.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1276228
>
> Title:
> security group( with rules) as stack resource isn't being tracked by
> Trove
>
> Status in Openstack Database (Trove):
> In Progress
>
> Bug description:
> Trove should track security group provisioned by heat
>
> As you can see, taskmanager doesn't perform any associations of
> security group/rules and instance, prof - [1], but with use_heat =
> False, taskmanager does it, prof - [2].
>
> Prof:
> [1]
> https://github.com/openstack/trove/blob/master/trove/taskmanager/models.py#L353-L424
> [2]
> https://github.com/openstack/trove/blob/master/trove/taskmanager/models.py#L609-L621
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/trove/+bug/1276228/+subscriptions
>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/96795
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=98f0fb6f7898c4389da442cee8a4dfdaf071d58b
Submitter: Jenkins
Branch: master

commit 98f0fb6f7898c4389da442cee8a4dfdaf071d58b
Author: Denis Makogon <email address hidden>
Date: Tue Jul 1 11:12:01 2014 +0300

    Fix tracking of SG's provisioned by Heat

    Reasons:
     - Trove doesn't track security group that was created as
       a part of stack.
     - Trove should create two records for security group tracking:
       - security group;
       - security group association with an actual instance;

    Changes:
     - Adding security groups registration right after stack creation.

    Change-Id: I1f55c27ecbd5ad76c869eae7197b8c24720fc1e6
    Closes-Bug: #1276228