heat-stack-delete-bug

[Denis M.]

If use_heat = True after deleting trove instance heat still have stack, but it's empty without ability to be deleted (ghosted).

Steps to reproduce:
1. Create instance with heat as prov. service.
2. Delete instance.
3. Delete stack manualy.

Trove delete also should be

If a server is already deleted for some reason, the stack will fail to delete. It's better to handle this more gracefully instead of raising an exception.

# heat resource-show a b
+------------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Property | Value |
+------------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------+
| description | |
| links | <SANITEZED>| | | <SANITEZED> |
| logical_resource_id | b |
| physical_resource_id | 03e23d82-a8bf-4df5-8d94-0b84ed229c83 |
| required_by | |
| resource_name | b |
| resource_status | DELETE_FAILED |
| resource_status_reason | NotFound: Instance could not be found (HTTP 404) (Request-ID: req-c6af6748-70ae-45ba-9105-acbc5e3e436c) |
| resource_type | OS::Nova::Server |
| updated_time | 2014-01-12T23:15:32Z |
+------------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------+

It's better if this is handled more gracefully by simply handling the exception and assuming it's already deleted then.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/69450

[Denis M. (dmakogon)]

Given patch is competetive. Please review blueprint https://blueprints.launchpad.net/trove/+spec/heat-firstclass-citizen-in-trove

[Sushil Kumar (sushil-kumar2)]

Hey Denis

Please compare both the patchsets.

Both https://review.openstack.org/#/c/67873/ and https://review.openstack.org/#/c/69450/ are different

[Sushil Kumar (sushil-kumar2)]

If use_heat = True which implies, we are using heat services to provision nova and cinder instances basically.

Now,
1. Create the trove instance using trove API, this would create a heat stack which has a nova instance and a volume if volume_support is ON using heat services.
2. Delete the nova instances using Nova API.
3. Delete the trove instance using trove API, this would leave the heat stack ghosted.

[Denis M. (dmakogon)]

Described problem has nothing common with Trove. This _is_ heat problem.

Just letting you know. Trove instance will still be ACTIVE even if compute instance is deleted.

[Denis M. (dmakogon)]

Do this fix in heat, not in Trove.

[Denis M. (dmakogon)]

This bug-report should be marked as invalid.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Nikhil Manchanda (<email address hidden>) on branch: master
Review: https://review.openstack.org/69450
Reason: Review clean up.

Abandoning since the last update > 3 weeks ago.

Please restore if patch is still in progress.

[Kevin Fox (kevpn)]

I've seen this when a heat stack failed to launch and went into CREATE_FAILED state and the trove instance then went into ERROR state. on deleting the trove instance, the heat stack was left behind. This is with trunk.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Nikhil Manchanda (<email address hidden>) on branch: master
Review: https://review.openstack.org/69450
Reason: Abandoning patches that have a negative review and are older than 4 weeks as part of a house-keeping sweep. Please feel free to restore the patch if it is still actively being worked on.

[Amrith Kumar (amrith)]

heat support (trove using heat to provision instances) is being eliminated.