Unable to create an instance on non-default service_type

Bug #1215183 reported by Nikhil Manchanda
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Critical
Nikhil Manchanda

Bug Description

The JSON Schema validation doesn't expect a service_type parameter, and blocks us from creating an instance of a non-default service type when the service_type param is specified in the instance section of the BODY in a create instance request. Here is the error that is occurring:
RESPONSE HEADERS: {'date': 'Wed, 21 Aug 2013 22:41:03 GMT', 'status': '400', 'content-length': '141', 'content-type': 'application/json; charset=UTF-8'}
RESPONSE BODY : {
    "badRequest": {
        "code": 400,
        "message": "Validation error: instance Additional properties are not allowed (u'service_type' was unexpected)"
    }
}
Validation error: instance Additional properties are not allowed (u'service_type' was unexpected) (HTTP 400)

Changed in trove:
status: New → Confirmed
importance: Undecided → Critical
milestone: none → havana-3
Changed in trove:
milestone: havana-3 → havana-rc1
Changed in trove:
assignee: nobody → Nikhil Manchanda (slicknik)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/44510

Changed in trove:
assignee: Nikhil Manchanda (slicknik) → Ed Cranford (ed--cranford)
status: Confirmed → In Progress
Revision history for this message
Denis M. (dmakogon) wrote :

What's the status ?

Revision history for this message
Denis M. (dmakogon) wrote :

service_type shouldn't be optional, it is should be required.

Changed in trove:
assignee: Ed Cranford (ed--cranford) → Nikhil Manchanda (slicknik)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/44510
Committed: http://github.com/openstack/trove/commit/2afe9ee1644ffb4e922fa5e329142866997c1fff
Submitter: Jenkins
Branch: master

commit 2afe9ee1644ffb4e922fa5e329142866997c1fff
Author: Ed Cranford <email address hidden>
Date: Fri Aug 30 13:17:17 2013 -0500

    Made apischema a bit less restrictive.

    All additionalProperties are now True instead of False
    All array minsizes are now 0 instead of 1
    Create Instance now has an additional service_type optional property

    fixes bug #1215183
    fixes bug #1218661
    fixes bug #1218662

    Change-Id: If5c9344464a730220a588294383bb473e7bc5e7c

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.