Trove - Instance reset_password is Broken

[Auston McReynolds]

The CLI claims there is an operation reset_password under the instance group of commands, but it insta-fails.

$ trove-cli instance

Available actions for 'instance' cmd:
        ...
 reset_password Reset the root user Password

https://github.com/openstack/python-troveclient/blob/9916c8f2733b683d859770d05dacd2c9c82912d7/troveclient/instances.py#L171 shows that the action is sent as `reset-password` (note the hyphen vs. underscore).

The API is looking for reset_password (underscore), see https://github.com/openstack/trove/blob/master/trove/instance/service.py#L69

Yet, even if it correctly matched, the reset_password function merely throws an unsupported exception: https://github.com/openstack/trove/blob/master/trove/instance/service.py#L131

In looking at the 'trove-cli root' commands, the 'trove-cli root create' command works as a reset also (tested), so I'm guessing the 'root create' command succeeded the ill-fated reset_password.

I'm thinking the command should be removed from the CLI (but the API fail-safe can stay for backwards compatibility) ?

[Michael Basnight (hubcap)]

https://review.openstack.org/#/c/34965/

[Michael Basnight (hubcap)]

https://review.openstack.org/#/c/34969/

[Michael Basnight (hubcap)]

this is a bug. we need to remove this code. its just plain ugly.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/42996

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/42996
Committed: http://github.com/openstack/python-troveclient/commit/87329ef2ad90c814bb869b72d3b6bc683b8fe6b1
Submitter: Jenkins
Branch: master

commit 87329ef2ad90c814bb869b72d3b6bc683b8fe6b1
Author: Nikhil Manchanda <email address hidden>
Date: Tue Aug 20 13:55:24 2013 -0700

    Removed instance reset_password from python-troveclient

    The reset_password operation no longer exists and needs to be removed
    from python-troveclient.

    Change-Id: Ic162ef6deb86716fa12fa5541699f602c246563e
    Fixes: bug 1199507