Change in localrc.rc doesn't reflect in devstack's localrc

Bug #1370946 reported by Rushi Agrawal
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Trove Integration
Undecided
Peter Stachowski

Bug Description

Say a param KEY=val was used while running './redstack install'. While running './redstack install' the second time, with the param value KEY=val2, this new value val2 is not updated in devstack's localrc

I discovered this while trying to set GIT_BASE=https://github.com in localrc.rc, as I'm behind proxy and git port is closed. But accidentally I typed 'gitnub.com', and even while fixing this in localrc.rc, it still threw the same error, that unable to connect to 'gitnub.com', because devstack's localrc was never changed again.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove-integration (master)

Fix proposed to branch: master
Review: https://review.openstack.org/142937

Changed in trove-integration:
assignee: nobody → Shayne Burgess (shayne-burgess)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on trove-integration (master)

Change abandoned by Shayne Burgess (<email address hidden>) on branch: master
Review: https://review.openstack.org/142937
Reason: Will be covered already by this change: https://review.openstack.org/#/c/155913/

Changed in trove-integration:
assignee: Shayne Burgess (shayne-burgess) → Peter Stachowski (peterstac)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove-integration (master)

Reviewed: https://review.openstack.org/155913
Committed: https://git.openstack.org/cgit/openstack/trove-integration/commit/?id=0ac948a7047b165c1938e26d780b8dc88088703b
Submitter: Jenkins
Branch: master

commit 0ac948a7047b165c1938e26d780b8dc88088703b
Author: Peter Stachowski <email address hidden>
Date: Wed Mar 4 15:49:07 2015 -0500

    Refactor redstack to use local.conf

    The devstack project has moved away from a localrc file and now uses a
    [[local|localrc]] section in the new local.conf file to accomplish the
    same thing. The redstack script should set up this file.
    (see https://github.com/openstack-dev/devstack/commit/38e38fb )

    The redstack script has been modified to set up devstack configuration
    in the new format.

    Backwards compatibility was maintained by deferring to an existing
    localrc file in the devstack base directory. In order to use the
    new style configuration file, the localrc file must first be
    deleted or renamed. At the same time, any 'user' configuration
    would need to move to USER_LOCAL_CONF (see below).

    The refactor solves the important issue of when different configurations
    are desired. For example, in order to support profiling (OSProfiler),
    entries have to be made in the corresponding trove configuration files.
    The ability to turn profiling on and off is now possible, by using
    configuration entries such as the following:

    [[post-config|$TROVE_CONF]]
    [profiler]
    enabled = True

    where the line 'enabled = True' could be generated from redstack in
    the form of 'enabled = $ENABLE_PROFILER'

    The refactoring also permits user specified configuration to become
    more in-depth, allowing greater control over the trove/devstack
    environment. This was accomplished by including a USER_LOCAL_CONF
    variable that defaults to '$HOME/.devstack.local.conf'. All the
    contents of that file are now included in devstack's local.conf
    file on each invocation of 'redstack install'.

    A directory 'local.conf.d' has been added to store additional
    configuration files. The existing using_vagrant and use_uuid_token
    configurations have been moved there. Stubs for the Trove
    configuration files were added in 'trove.conf.rc'. Files are loaded
    by default, unless a corresponding variable is set to false.
    For example, setting TROVE_CONF=false in options.rc will cause the
    trove.conf.rc file to be skipped. USING_VAGRANT=false and
    USE_UUID_TOKEN=false have been added in redstack.rc to maintain
    backwards compatibility.

    A sample.rc file was created with detailed comments about how the
    configuration can be set up (this file is ignored).

    An additional file for persistent redstack options was added,
    '$HOME/.redstack.options.rc', and is sourced before options.rc if it
    exists.

    A side effect of this refactor is that it regenerates the localrc
    part each time, thus effectively fixing bug 1370946 as well.

    Change-Id: I319476b29aada7f24829ae2308bf88c8c4bdafa7
    Closes-Bug: #1421859
    Closes-Bug: #1370946

Changed in trove-integration:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers