Guest Agent wrongly uses trove-guestagent.conf.sample directly

[Nikhil Manchanda]

The guest agent should use it's own config file and not modify the sample conf and use it.

[Sushil Kumar (sushil-kumar2)]

I would say probably this was done as a workaround because /etc/trove-guestagent.conf was not getting created due to another bug => https://bugs.launchpad.net/trove/+bug/1265184

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/64543

[Sushil Kumar (sushil-kumar2)]

As per Bug trove-guestagent uses trove-guestagent.conf.sample directly placed inside the rsync'd trove code from host.

This piece of code comes from the "trove-guest" service start-up file inside trove-integration, where the configuration file is mapped to sample file.

Now while doing a research found that code is already available in _create_server in trove.taskmanager.models, which is used to create an instance in our case, to create the file "/etc/trove-guestagent.conf" but this method was not able to work because of a false evaluating condition "if os.path.isfile(CONF.get('guest_config')):".

Problem was because guest_config was derived from "pybasedir" as '$pybasedir/etc/trove/trove-guestagent.conf.sample' in trove.common.cfg, however the correct location for the etc was the parent of pybasedir.

So to resolve the bug,

1. We need to first correct the guest_config default location, in trove, which would help taskmanager to read the conf file and send the contents to nova for guest-instantiation. (https://review.openstack.org/64539)

2. Correct the service start-up file in trove-integration to point to the built-up conf file in /etc. (https://review.openstack.org/64543)

[Dan Nguyen (daniel-a-nguyen)]

Good bug description! Thanks for filing/fixing.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/88478
Committed: https://git.openstack.org/cgit/openstack/trove-integration/commit/?id=fd1c113d05b27217e3d3f8ef804ffc3bd58fa9ba
Submitter: Jenkins
Branch: master

commit fd1c113d05b27217e3d3f8ef804ffc3bd58fa9ba
Author: Nikhil Manchanda <email address hidden>
Date: Thu Apr 17 18:08:00 2014 -0700

    Trove guestagent should not use sample conf

    Fixed the trove guestagent to use the config file from
    /etc/trove/trove-guestagent.conf instead of using the sample
    conf from the trove/etc directory.

    Closes-bug: 1176102
    Change-Id: I7c55198d6d93f5e909c3b3d9085c08d88561f376