Standalone upgrade job fails on set cinder_volume upgrade node facts in a single-node environment" task

[Sergii Golovatiuk]

Some patches such as https://review.opendev.org/#/c/753842/ fail on tripleo-ci-centos-7-standalone-upgrade-stein job with the following message

-09-28 15:24:38 | 2020-09-28 15:24:38.563 339200 ERROR tripleoclient.v1.tripleo_upgrade.Upgrade [-] Exception: Upgrade failed: DeploymentError: Upgrade failed
2020-09-28 15:24:38 | Traceback (most recent call last):
2020-09-28 15:24:38 | File "/usr/lib/python2.7/site-packages/tripleoclient/v1/tripleo_deploy.py", line 1278, in _standalone_deploy
2020-09-28 15:24:38 | raise exceptions.DeploymentError('Upgrade failed')
2020-09-28 15:24:38 | DeploymentError: Upgrade failed
2020-09-28 15:24:38 | 2020-09-28 15:24:38.567 339200 ERROR tripleoclient.v1.tripleo_upgrade.Upgrade [-] None: DeploymentError: Upgrade failed
2020-09-28 15:24:39 | 2020-09-28 15:24:39.966 339200 ERROR tripleoclient.v1.tripleo_upgrade.Upgrade [-] ** Found ansible errors for standalone deployment! **: DeploymentError: Upgrade failed
2020-09-28 15:24:39 | 2020-09-28 15:24:39.967 339200 ERROR tripleoclient.v1.tripleo_upgrade.Upgrade [-] [
2020-09-28 15:24:39 | [
2020-09-28 15:24:39 | "set cinder_volume upgrade node facts in a single-node environment",
2020-09-28 15:24:39 | {
2020-09-28 15:24:39 | "msg": "The task includes an option with an undefined variable. The error was: 'cinder_volume_node_names' is undefined\n\nThe error appears to be in '/home/zuul/standalone-ansible-YpY5Oe/Standalone/upgrade_tasks_step1.yaml': line 27, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n- block:\n - name: set cinder_volume upgrade node facts in a single-node environment\n ^ here\n",
2020-09-28 15:24:39 | "_ansible_no_log": false
2020-09-28 15:24:39 | }
2020-09-28 15:24:39 | ]

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/755064

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/755217

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/755219

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/755220

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/755064
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=0f7ed0b8d521ad7e9333482e59894af210d63d03
Submitter: Zuul
Branch: master

commit 0f7ed0b8d521ad7e9333482e59894af210d63d03
Author: Sergii Golovatiuk <email address hidden>
Date: Tue Sep 29 17:17:44 2020 +0200

    Default cinder_volume_node_names to []

    There are cases when cinder_volume_node_names is not defined. It was
    fixed for "set cinder_volume upgrade node facts from the limit option"
    task in loop but never for non HA task. So, standalone upgrade job
    fails with the following message.

    "msg": "The task includes an option with an undefined variable. The
    error was: 'cinder_volume_node_names' is undefined\n\nThe error appears
    to be in
    '/home/zuul/standalone-ansible-YpY5Oe/Standalone/upgrade_tasks_step1.yaml':
    line 27, column 5, but may\nbe elsewhere in the file depending on the
    exact syntax problem.\n\nThe offending line appears to be:\n\n- block:\n
    - name: set cinder_volume upgrade node facts in a single-node
    environment\n ^ here\n",

    This patch defaults cinder_volume_node_names to [] when
    cinder_volume_node_names is not defined in hiera.

    Closes-Bug: #1897760

    Change-Id: I1145c39e379ac6579662f2bbfcc9a4d2d3e0f059

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/755219
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=3d9362c3a8d3b6c8334e6ce17f1403513370d06b
Submitter: Zuul
Branch: stable/train

commit 3d9362c3a8d3b6c8334e6ce17f1403513370d06b
Author: Sergii Golovatiuk <email address hidden>
Date: Tue Sep 29 17:17:44 2020 +0200

    Default cinder_volume_node_names to []

    There are cases when cinder_volume_node_names is not defined. It was
    fixed for "set cinder_volume upgrade node facts from the limit option"
    task in loop but never for non HA task. So, standalone upgrade job
    fails with the following message.

    "msg": "The task includes an option with an undefined variable. The
    error was: 'cinder_volume_node_names' is undefined\n\nThe error appears
    to be in
    '/home/zuul/standalone-ansible-YpY5Oe/Standalone/upgrade_tasks_step1.yaml':
    line 27, column 5, but may\nbe elsewhere in the file depending on the
    exact syntax problem.\n\nThe offending line appears to be:\n\n- block:\n
    - name: set cinder_volume upgrade node facts in a single-node
    environment\n ^ here\n",

    This patch defaults cinder_volume_node_names to [] when
    cinder_volume_node_names is not defined in hiera.

    Closes-Bug: #1897760

    Change-Id: I1145c39e379ac6579662f2bbfcc9a4d2d3e0f059
    (cherry picked from commit 0f7ed0b8d521ad7e9333482e59894af210d63d03)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/755217
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=1f5218100e931953649f6279789460a3d073e990
Submitter: Zuul
Branch: stable/ussuri

commit 1f5218100e931953649f6279789460a3d073e990
Author: Sergii Golovatiuk <email address hidden>
Date: Tue Sep 29 17:17:44 2020 +0200

    Default cinder_volume_node_names to []

    There are cases when cinder_volume_node_names is not defined. It was
    fixed for "set cinder_volume upgrade node facts from the limit option"
    task in loop but never for non HA task. So, standalone upgrade job
    fails with the following message.

    "msg": "The task includes an option with an undefined variable. The
    error was: 'cinder_volume_node_names' is undefined\n\nThe error appears
    to be in
    '/home/zuul/standalone-ansible-YpY5Oe/Standalone/upgrade_tasks_step1.yaml':
    line 27, column 5, but may\nbe elsewhere in the file depending on the
    exact syntax problem.\n\nThe offending line appears to be:\n\n- block:\n
    - name: set cinder_volume upgrade node facts in a single-node
    environment\n ^ here\n",

    This patch defaults cinder_volume_node_names to [] when
    cinder_volume_node_names is not defined in hiera.

    Closes-Bug: #1897760
    Change-Id: I1145c39e379ac6579662f2bbfcc9a4d2d3e0f059
    (cherry picked from commit 0f7ed0b8d521ad7e9333482e59894af210d63d03)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/756085

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sergii Golovatiuk (<email address hidden>) on branch: stable/stein
Review: https://review.opendev.org/755220
Reason: no need in stein as cinder_volume_node_names_upgraded is not defined at all.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sergii Golovatiuk (<email address hidden>) on branch: master
Review: https://review.opendev.org/756085

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.