TripleOCapabilitiesFilter lacks logging

[Ben Nemec]

This is a problem because if the initial deployment of a node in a predictable placement deployment fails, Nova will retry it. Because it's already attempted the lone node that can match the instance, this retry will always fail and the capabilities filter will look like the culprit. We need to add some logging to the filter so that users can see why the node failed to schedule and hopefully realize what happened more easily.

[Ben Nemec (bnemec)]

Patch: https://review.openstack.org/#/c/503748

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/503748
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=e5d16155364c1dae2db238506f236194e2dfb1dc
Submitter: Jenkins
Branch: master

commit e5d16155364c1dae2db238506f236194e2dfb1dc
Author: Ben Nemec <email address hidden>
Date: Wed Sep 13 16:40:41 2017 +0000

    Add logging to capabilities filter

    The capabilities filter gets incorrectly blamed for a lot of
    deployment failures because on a retry of a node deployment the
    filter has to fail because there is only one node that can match
    when using predictable placement. However, we don't have any
    logging to help determine why the filter fails. This adds logging
    to explain why nodes fell through, which will hopefully help with
    debugging these problems.

    Change-Id: I702209e9b5a1e546bf8cb784eec8bdc3c97c63eb
    Closes-Bug: 1718502

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 8.0.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/510662

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/510662
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=5922c80705c455d3d1d5dcb085ec08b19dd7accd
Submitter: Jenkins
Branch: stable/pike

commit 5922c80705c455d3d1d5dcb085ec08b19dd7accd
Author: Ben Nemec <email address hidden>
Date: Wed Sep 13 16:40:41 2017 +0000

    Add logging to capabilities filter

    The capabilities filter gets incorrectly blamed for a lot of
    deployment failures because on a retry of a node deployment the
    filter has to fail because there is only one node that can match
    when using predictable placement. However, we don't have any
    logging to help determine why the filter fails. This adds logging
    to explain why nodes fell through, which will hopefully help with
    debugging these problems.

    Change-Id: I702209e9b5a1e546bf8cb784eec8bdc3c97c63eb
    Closes-Bug: 1718502
    (cherry picked from commit e5d16155364c1dae2db238506f236194e2dfb1dc)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 7.6.2 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/566296

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/566297

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/566297
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=ac5e3fc860fbbde41a347bf2fe55838228e6dc88
Submitter: Zuul
Branch: stable/newton

commit ac5e3fc860fbbde41a347bf2fe55838228e6dc88
Author: Ben Nemec <email address hidden>
Date: Wed Sep 13 16:40:41 2017 +0000

    Add logging to capabilities filter

    The capabilities filter gets incorrectly blamed for a lot of
    deployment failures because on a retry of a node deployment the
    filter has to fail because there is only one node that can match
    when using predictable placement. However, we don't have any
    logging to help determine why the filter fails. This adds logging
    to explain why nodes fell through, which will hopefully help with
    debugging these problems.

    Change-Id: I702209e9b5a1e546bf8cb784eec8bdc3c97c63eb
    Closes-Bug: 1718502
    (cherry picked from commit e5d16155364c1dae2db238506f236194e2dfb1dc)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/566296
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=9a29b4d052ef487b057a3c8ffeea0bb5d7faf229
Submitter: Zuul
Branch: stable/ocata

commit 9a29b4d052ef487b057a3c8ffeea0bb5d7faf229
Author: Ben Nemec <email address hidden>
Date: Wed Sep 13 16:40:41 2017 +0000

    Add logging to capabilities filter

    The capabilities filter gets incorrectly blamed for a lot of
    deployment failures because on a retry of a node deployment the
    filter has to fail because there is only one node that can match
    when using predictable placement. However, we don't have any
    logging to help determine why the filter fails. This adds logging
    to explain why nodes fell through, which will hopefully help with
    debugging these problems.

    Change-Id: I702209e9b5a1e546bf8cb784eec8bdc3c97c63eb
    Closes-Bug: 1718502
    (cherry picked from commit e5d16155364c1dae2db238506f236194e2dfb1dc)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 6.1.7 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/tripleo-common 5.4.9 release.