triple-common manipulates warnings

Bug #2033548 reported by Stephen Finucane
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Confirmed
Undecided
Stephen Finucane

Bug Description

The tripleo-common library is manipulating warnings filters.

https://github.com/openstack/tripleo-common/blob/9fca209d49497c11558b2537eddba1750c38ad94/tripleo_common/utils/config.py#L33-L34

Since these are global, it affects every application that imports tripleo-common, either directly or indirectly. As noted in #1889380, this includes OSC. #1889380 was "fixed" by making the warnings that were being filtered more specific, but in reality a library should not be manipulating filters full stop.

Changed in tripleo:
assignee: nobody → Stephen Finucane (stephenfinucane)
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-common/+/896879

Revision history for this message
Brendan Shephard (bshephar) wrote :

Hey Stephen,

Thanks for raising awareness. That does indeed seem unintended, can you confirm if the review linked here resolves your concerns?

Revision history for this message
Stephen Finucane (stephenfinucane) wrote :

Hi Brendan. Thanks for looking at this. I actually submitted a fix for this already, which you can find here [1], and I'm not sure why it wasn't linked to this. I'm okay with either patch though since they both do the same thing.

[1] https://review.opendev.org/c/openstack/tripleo-common/+/893237

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-common (stable/wallaby)

Change abandoned by "Brendan Shephard <email address hidden>" on branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-common/+/896879

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by "Ghanshyam <email address hidden>" on branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-common/+/893237
Reason: TrieplO project is retiring now, for details, please see https://review.opendev.org/c/openstack/governance/+/905145 or reach out to OpenStack TC.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.