Missing bind mount prevents glance_api_cron from accessing cache data

[Takashi Kajinami]

Description
===========
The glance_api_cron container executes not only db purge job but also cache prune/clean job.
However the container does not have access to the /var/lib/glance directory, which contains the image cache data (in /var/lib/glance/image-cache) and can't properly prune or clean cache data.

Steps to reproduce
==================
* Deploy overcloud

Expected result
===============
* The glance_api_cron container has access to /var/lib/glance in host
* The cache cron jobs properly prune/clean image cache data

Actual result
=============
* The glance_api_cron container does not has access to /var/lib/glance in host
* The cache cron jobs does not prune/clean image cache data

Environment
===========
The issue was initially found in stable/train

Logs & Configs
==============
N/A

[Takashi Kajinami (kajinamit)]

Fix proposed to master: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/865501

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/865501
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/b532a042152805e32c2f410bbfe16f5e8e222581
Submitter: "Zuul (22348)"
Branch: master

commit b532a042152805e32c2f410bbfe16f5e8e222581
Author: Takashi Kajinami <email address hidden>
Date: Thu Nov 24 15:19:57 2022 +0900

    Expose /var/lib/glance to cron container

    The glance_api_cron container executes the cache clean/prune jobs, thus
    it requires access to the /var/lib/glance directory which contains
    the cache data.

    Because the directory is now shared by the two containers (glance_api
    and glance_api_cron), the mount flag is updated from slave to shared
    so that any change is propagated between these two containers.

    Closes-Bug: #1997625
    Change-Id: Idb16f8664d937d8d11108f2b29b22f8b7ced521c

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/865898

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 18.0.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/865898
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/4ddf16a2cc84281d7a2a08bddae5a78972143f8c
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 4ddf16a2cc84281d7a2a08bddae5a78972143f8c
Author: Takashi Kajinami <email address hidden>
Date: Thu Nov 24 15:19:57 2022 +0900

    Expose /var/lib/glance to cron container

    The glance_api_cron container executes the cache clean/prune jobs, thus
    it requires access to the /var/lib/glance directory which contains
    the cache data.

    Because the directory is now shared by the two containers (glance_api
    and glance_api_cron), the mount flag is updated from slave to shared
    so that any change is propagated between these two containers.

    Closes-Bug: #1997625
    Change-Id: Idb16f8664d937d8d11108f2b29b22f8b7ced521c
    (cherry picked from commit b532a042152805e32c2f410bbfe16f5e8e222581)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/869043

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/869043
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/2570e4c9e10e7ba10f57a5e5ffa37c5b9cc146de
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 2570e4c9e10e7ba10f57a5e5ffa37c5b9cc146de
Author: Takashi Kajinami <email address hidden>
Date: Thu Nov 24 15:19:57 2022 +0900

    Expose /var/lib/glance to cron container

    The glance_api_cron container executes the cache clean/prune jobs, thus
    it requires access to the /var/lib/glance directory which contains
    the cache data.

    Because the directory is now shared by the two containers (glance_api
    and glance_api_cron), the mount flag is updated from slave to shared
    so that any change is propagated between these two containers.

    Closes-Bug: #1997625
    Change-Id: Idb16f8664d937d8d11108f2b29b22f8b7ced521c
    (cherry picked from commit b532a042152805e32c2f410bbfe16f5e8e222581)
    (cherry picked from commit 4ddf16a2cc84281d7a2a08bddae5a78972143f8c)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/871590

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/871590
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/aa102c181dde24342c407207f151cb7a62844278
Submitter: "Zuul (22348)"
Branch: stable/train

commit aa102c181dde24342c407207f151cb7a62844278
Author: Takashi Kajinami <email address hidden>
Date: Thu Nov 24 15:19:57 2022 +0900

    Expose /var/lib/glance to cron container

    The glance_api_cron container executes the cache clean/prune jobs, thus
    it requires access to the /var/lib/glance directory which contains
    the cache data.

    Because the directory is now shared by the two containers (glance_api
    and glance_api_cron), the mount flag is updated from slave to shared
    so that any change is propagated between these two containers.

    Closes-Bug: #1997625
    Change-Id: Idb16f8664d937d8d11108f2b29b22f8b7ced521c
    (cherry picked from commit b532a042152805e32c2f410bbfe16f5e8e222581)
    (cherry picked from commit 4ddf16a2cc84281d7a2a08bddae5a78972143f8c)
    (cherry picked from commit 2570e4c9e10e7ba10f57a5e5ffa37c5b9cc146de)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates train-eol release.