tripleo

Fix tripleo_delegate_to parameter in heat-engine

Bug #1996492 reported by Keigo Noha on 2022-11-14

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	Undecided	Unassigned

Bug Description

Ia9d3c8d0a3098191b2d8b12fc24eee4517c6c521 introduces the new logic to
tripleo_delegate_to parameter. Unfortunately, there is an unnecessary
character, '| |' in the line.
This blocks 'overcloud external-upgrade run'.

Tags:

OpenStack Infra (hudson-openstack) on 2022-11-14

Changed in tripleo:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-11-18: Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/864387
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/4a1abe6c0a72215cf4878cee1830ea69a9663eb1
Submitter: "Zuul (22348)"
Branch: master

commit 4a1abe6c0a72215cf4878cee1830ea69a9663eb1
Author: Keigo Noha <email address hidden>
Date: Mon Nov 14 15:00:00 2022 +0900

Fix tripleo_delegate_to parameter in heat-engine

    Ia9d3c8d0a3098191b2d8b12fc24eee4517c6c521 introduces the new logic to
    tripleo_delegate_to parameter. Unfortunately, there is an unnecessary
    character, '| |' in the line.
    This blocks 'overcloud external-upgrade run'. This fix remove the
    additonal '|' from the line.

Closes-Bug: #1996492
Change-Id: If0e91f1b4956f451346256487c3626ed7899643b

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-11-18: Fix proposed to tripleo-heat-templates (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/864972

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-11-22: Fix merged to tripleo-heat-templates (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/864972
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/97052ac0400269bf2dfb57857262e5c8168be5de
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 97052ac0400269bf2dfb57857262e5c8168be5de
Author: Keigo Noha <email address hidden>
Date: Mon Nov 14 15:00:00 2022 +0900

Fix tripleo_delegate_to parameter in heat-engine

    Ia9d3c8d0a3098191b2d8b12fc24eee4517c6c521 introduces the new logic to
    tripleo_delegate_to parameter. Unfortunately, there is an unnecessary
    character, '| |' in the line.
    This blocks 'overcloud external-upgrade run'. This fix remove the
    additonal '|' from the line.

    Closes-Bug: #1996492
    Change-Id: If0e91f1b4956f451346256487c3626ed7899643b
    (cherry picked from commit 4a1abe6c0a72215cf4878cee1830ea69a9663eb1)

tags:

added: in-stable-zed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-11-24: Fix proposed to tripleo-heat-templates (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/865400

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-11-30: Fix merged to tripleo-heat-templates (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/865400
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/1a7965bf0a1ce1fe54c59f968bb5e04c3b44ab6b
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 1a7965bf0a1ce1fe54c59f968bb5e04c3b44ab6b
Author: Keigo Noha <email address hidden>
Date: Mon Nov 14 15:00:00 2022 +0900

Fix tripleo_delegate_to parameter in heat-engine

    Ia9d3c8d0a3098191b2d8b12fc24eee4517c6c521 introduces the new logic to
    tripleo_delegate_to parameter. Unfortunately, there is an unnecessary
    character, '| |' in the line.
    This blocks 'overcloud external-upgrade run'. This fix remove the
    additonal '|' from the line.

    Closes-Bug: #1996492
    Change-Id: If0e91f1b4956f451346256487c3626ed7899643b
    (cherry picked from commit 4a1abe6c0a72215cf4878cee1830ea69a9663eb1)
    (cherry picked from commit 97052ac0400269bf2dfb57857262e5c8168be5de)

tags:

added: in-stable-wallaby

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-12-02: Fix merged to tripleo-heat-templates (stable/train)

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/859435
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/32f30aae8a3256a3de5d14b59431120261123d11
Submitter: "Zuul (22348)"
Branch: stable/train

commit 32f30aae8a3256a3de5d14b59431120261123d11
Author: Rabi Mishra <email address hidden>
Date: Thu Sep 8 12:21:18 2022 +0530

Filter excluded nodes from ansible delegates

This would allow external_(deploy/update/upgrade)_tasks
to honor excluded nodes during deploy/update/upgrade.

    Backports Notes: Some files had conflicts:
     - deployment/aodh/aodh-api-container-puppet.yaml
     - deployment/database/redis-container-puppet.yaml
     - deployment/designate/designate-bind-container.yaml
     - deployment/glance/glance-api-container-puppet.yaml
     - deployment/ipa/ipaservices-baremetal-ansible.yaml
     - deployment/pacemaker/pacemaker-baremetal-puppet.yaml

the resolution of those conflicts did not change the patch logic.

This review also squashes the fix included in
https://review.opendev.org/c/openstack/tripleo-heat-templates/+/865400

Closes-Bug: #1996492

    Depends-On: https://review.opendev.org/c/openstack/tripleo-common/+/859403
    Change-Id: Ia9d3c8d0a3098191b2d8b12fc24eee4517c6c521
    (cherry picked from commit e428db15cb907df62bc5621c83aa77b0f97f867d)