[CS9][Wallaby] featureset001-component-wallaby-validation failing with: "run_validations() got an unexpected keyword argument 'log_path'"

[Douglas Viroel]

periodic-tripleo-ci-centos-9-ovb-3ctlr_1comp-featureset001-component-wallaby-validation is failing since 10/27[1] with the following error[2]:

Exception occured while running the command
Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/tripleoclient/command.py", line 32, in run
    super(Command, self).run(parsed_args)
  File "/usr/lib/python3.9/site-packages/osc_lib/command/command.py", line 39, in run
    return super(Command, self).run(parsed_args)
  File "/usr/lib/python3.9/site-packages/cliff/command.py", line 185, in run
    return_code = self.take_action(parsed_args) or 0
  File "/usr/lib/python3.9/site-packages/tripleoclient/v1/undercloud.py", line 154, in take_action
    cmd = undercloud_config.prepare_undercloud_deploy(
  File "/usr/lib/python3.9/site-packages/tripleoclient/v1/undercloud_config.py", line 819, in prepare_undercloud_deploy
    undercloud_preflight.check(verbose_level, upgrade)
  File "/usr/lib/python3.9/site-packages/tripleoclient/v1/undercloud_preflight.py", line 513, in check
    _run_validations(upgrade)
  File "/usr/lib/python3.9/site-packages/tripleoclient/v1/undercloud_preflight.py", line 96, in _run_validations
    actions.run_validations(
TypeError: run_validations() got an unexpected keyword argument 'log_path'
run_validations() got an unexpected keyword argument 'log_path'

---
The change that might be causing that is:
https://review.opendev.org/c/openstack/validations-libs/+/859944

Master and Zed will not fail due to a recent change to avoid breakage on API change:
https://review.opendev.org/c/openstack/python-tripleoclient/+/859608

[1] https://review.rdoproject.org/zuul/builds?job_name=periodic-tripleo-ci-centos-9-ovb-3ctlr_1comp-featureset001-component-wallaby-validation&skip=0
[2] https://logserver.rdoproject.org/openstack-component-validation/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-9-ovb-3ctlr_1comp-featureset001-component-wallaby-validation/42bb31b/logs/undercloud/home/zuul/undercloud_install.log.txt.gz

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/863559

[Marios Andreou (marios-b)]

fix from comment #1 looks good there https://review.rdoproject.org/r/c/testproject/+/36356/77#message-a3959ed56abc27ec910e47d217a46cc7fedde5e6

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/863559
Committed: https://opendev.org/openstack/python-tripleoclient/commit/3e496feb67d59be1ff3efd8de345cb27efe54bba
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 3e496feb67d59be1ff3efd8de345cb27efe54bba
Author: Douglas Viroel <email address hidden>
Date: Thu Nov 3 17:59:05 2022 -0300

    Execute undercloud preflight validations via VF binary

    Execute undercloud preflight validations via the Validation Framework
    binary instead of via the VF API avoid breakage when an API change is introduce.
    Its also fix some issues present in the previous implementation:
    - the validations was logged in /tmp instead of the /var/log/validations,
      so the logs wasn't shown in the CLI history command.
    - the results of the executed validations was never checked, so when the
      validations was failing, the undercloud install can still continue

    Closes-Bug: #1995641

    Change-Id: I149932625fe474175e3842fa52adfea30021ab5c
    (cherry picked from commit 66156f7395a15bd29d8ec6ecf0cc29ff430b0a54)

[Marios Andreou (marios-b)]

fix merged today so we didn't get get a green run in the openstack-component-validation pipeline [1].

The line will run this evening so lets wait for that so we can validate before closing it out

[1] https://review.rdoproject.org/zuul/builds?job_name=periodic-tripleo-ci-centos-9-ovb-3ctlr_1comp-featureset001-component-wallaby-validation&pipeline=openstack-component-validation%09&skip=0

[Marios Andreou (marios-b)]

Finally a green run at the top of history today [1]

periodic-tripleo-ci-centos-9-ovb-3ctlr_1comp-featureset001-component-wallaby-validation openstack/tripleo-ci master openstack-component-validation 2 hrs 5 mins 28 secs 2022-11-07 22:33:17 SUCCESS

moving fix released

[1] https://review.rdoproject.org/zuul/builds?job_name=periodic-tripleo-ci-centos-9-ovb-3ctlr_1comp-featureset001-component-wallaby-validation&pipeline=openstack-component-validation%09&skip=0