Wallaby HA overcloud deployed with bad pacemaker container image names

[Damien Ciabrini]

With the move to ephemeral Heat, the deployment of a HA overcloud no longer include an environment file that configures Heat parameter ClusterFullTag. Consequently, the control plane is deployed with pacemaker resource configured differently than what was expected to be the new default in Wallaby:

  * Container bundle: haproxy-bundle [104.130.140.229:5001/tripleowallabycentos9/openstack-haproxy:pcmklatest]:
  * Container bundle: galera-bundle [104.130.140.229:5001/tripleowallabycentos9/openstack-mariadb:pcmklatest]:
  * Container bundle: rabbitmq-bundle [104.130.140.229:5001/tripleowallabycentos9/openstack-rabbitmq:pcmklatest]:
  * Container bundle: openstack-cinder-volume [104.130.140.229:5001/tripleowallabycentos9/openstack-cinder-volume:pcmklatest]:

The expected default should be akin to:

  * Container bundle set: haproxy-bundle [cluster.common.tag/haproxy:pcmklatest]:
  * Container bundle set: galera-bundle [cluster.common.tag/mariadb:pcmklatest]:
  * Container bundle set: rabbitmq-bundle [cluster.common.tag/rabbitmq:pcmklatest]:
  * Container bundle: openstack-cinder-volume [cluster.common.tag/cinder-volume:pcmklatest]:

As a side effect, one can not run an minor update from e.g. Wallaby to Xena without causing a service disruption, because any change of container image name makes pacemaker restart the service globally.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/861610

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/862147

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/872029

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Damien Ciabrini <email address hidden>" on branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/861610

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/862147
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/8b8f103906843ab25e5b97a76253b6120aea1de3
Submitter: "Zuul (22348)"
Branch: master

commit 8b8f103906843ab25e5b97a76253b6120aea1de3
Author: Damien Ciabrini <email address hidden>
Date: Thu Oct 20 15:48:49 2022 +0200

    HA: enable new container image name by default

    Make ClusterFullTag the new default for pacemaker's
    intermediate container image name. With this new
    default, minor updates of pacemaker-managed services
    now support all changes in container image name,
    without causing a service disruption.

    Existing environments can migrate to this new default
    by running specific update tasks [1] to orchestrate
    the migration without service disruption.

    [1] Ic6da7d30105f14fb793c2e834ebf8dcdd7c719a3

    Change-Id: Ic22276ad14abdba7801bfbf93b3925bee723db20
    Related-Bug: #1992988

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/875510

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/875602

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/875602
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/249a60d68fdf752167d5b45152eed487a6bb427f
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 249a60d68fdf752167d5b45152eed487a6bb427f
Author: Damien Ciabrini <email address hidden>
Date: Thu Oct 20 15:48:49 2022 +0200

    HA: enable new container image name by default

    Make ClusterFullTag the new default for pacemaker's
    intermediate container image name. With this new
    default, minor updates of pacemaker-managed services
    now support all changes in container image name,
    without causing a service disruption.

    Existing environments can migrate to this new default
    by running specific update tasks [1] to orchestrate
    the migration without service disruption.

    [1] Ic6da7d30105f14fb793c2e834ebf8dcdd7c719a3

    Change-Id: Ic22276ad14abdba7801bfbf93b3925bee723db20
    Related-Bug: #1992988
    (cherry picked from commit 8b8f103906843ab25e5b97a76253b6120aea1de3)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/879391

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/879392

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/872029
Committed: https://opendev.org/openstack/tripleo-ansible/commit/4c86e6d9463106cf8fd9399d5d96d073ce4bdd36
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 4c86e6d9463106cf8fd9399d5d96d073ce4bdd36
Author: Damien Ciabrini <email address hidden>
Date: Wed Oct 12 19:44:07 2022 +0200

    HA: Minor update with new container image name

    This role encapsulates preparation steps that are required
    during a minor update to change the container image name
    used by a HA service, without causing service disruption.

    Related-Bug: #1992988
    Change-Id: I9f66591d453be2f41f671ff70c511d8268945472

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/861100
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/76e37a3b7f0fb26d413c7bb62b99b640a18a0fd1
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 76e37a3b7f0fb26d413c7bb62b99b640a18a0fd1
Author: Damien Ciabrini <email address hidden>
Date: Wed Feb 15 11:15:36 2023 +0100

    HA: minor update with new container image name

    Pacemaker-managed services use intermediate container
    image names internally to implement minor updates without
    service disruption. The naming scheme is configured at
    initial deployment from Heat parameters ClusterCommonTag
    and ClusterFullTag.

    This change makes it possible to change the configured
    naming scheme during a minor update, without causing
    service disruption. It works by running new external
    update tasks to prepare for the switch prior to the
    minor update.

    For the `test_tht_ansible_syntax.py` test we have populated
    the groups so that the test won't fail because of an empty
    inventory. Note that the final host list passed to the
    `tripleo_ha_image_update` role is empty.

    Closes-Bug: #1992988

    Depends-On: https://review.opendev.org/c/openstack/tripleo-ansible/+/872029
    Change-Id: Ic6da7d30105f14fb793c2e834ebf8dcdd7c719a3

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Sofer Athlan-Guyot <email address hidden>" on branch: stable/zed
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/879392
Reason: zed is not a thing anymore.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Sofer Athlan-Guyot <email address hidden>" on branch: stable/zed
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/879391
Reason: Zed is not a thing anymore.