insert-headers is not a valid option for a TCP protocol listener

[Ananya Banerjee]

octavia_tempest_plugin.tests.scenario.v2.test_listener.ListenerScenarioTest is failing with

Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/octavia_tempest_plugin/tests/scenario/v2/test_listener.py", line 145, in test_listener_CRUD
    listener = self.mem_listener_client.create_listener(**listener_kwargs)
  File "/usr/lib/python3.6/site-packages/octavia_tempest_plugin/common/decorators.py", line 42, in wrapper
    return f(*func_args, **func_kwargs)
  File "/usr/lib/python3.6/site-packages/octavia_tempest_plugin/services/load_balancer/v2/listener_client.py", line 127, in create_listener
    return self._create_object(**kwargs)
  File "/usr/lib/python3.6/site-packages/octavia_tempest_plugin/services/load_balancer/v2/base_client.py", line 101, in _create_object
    response, body = self.post(request_uri, jsonutils.dumps(obj_dict))
  File "/usr/lib/python3.6/site-packages/tempest/lib/common/rest_client.py", line 300, in post
    return self.request('POST', url, extra_headers, headers, body, chunked)
  File "/usr/lib/python3.6/site-packages/tempest/lib/common/rest_client.py", line 704, in request
    self._error_checker(resp, resp_body)
  File "/usr/lib/python3.6/site-packages/tempest/lib/common/rest_client.py", line 815, in _error_checker
    raise exceptions.BadRequest(resp_body, resp=resp)
tempest.lib.exceptions.BadRequest: Bad request
Details: {'faultcode': 'Client', 'faultstring': 'insert-headers is not a valid option for a TCP protocol listener.', 'debuginfo': None}

https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_462/859402/1/check/tripleo-ci-centos-8-scenario010-ovn-provider-standalone-train/462444c/logs/undercloud/var/log/tempest/stestr_results.html

https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_462/859402/1/check/tripleo-ci-centos-8-scenario010-ovn-provider-standalone-train/462444c/logs/undercloud/var/log/tempest/tempest_run.log

[Ananya Banerjee (frenzyfriday)]

This affects only tripleo-ci-centos-8-scenario010-ovn-provider-standalone-train

I found a similar bug: https://bugs.launchpad.net/tripleo/+bug/1895705

[Ananya Banerjee (frenzyfriday)]

<arxcruz> :

https://github.com/openstack/tripleo-ci/blob/master/zuul.d/standalone-jobs.yaml#L681
need to either remove this, or change it to HTTP and check if it will continue to fail

the octavia plugin is a little bit old, it's failing because this is set to TCP, and failing with insert-headers is not a valid option for a TCP protocol
https://github.com/openstack/octavia-tempest-plugin/blob/1.2.0/octavia_tempest_plugin/tests/scenario/v2/test_listener.py#L55-L57
and https://github.com/openstack/octavia-tempest-plugin/blob/1.2.0/octavia_tempest_plugin/tests/scenario/v2/test_listener.py#L120

so, there is no if the protocol is tcp or http, it will try to insert the header

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-ci/+/859830

[Arx Cruz (arxcruz)]

https://review.opendev.org/c/openstack/tripleo-ci/+/859830 fix the problem

[Arx Cruz (arxcruz)]

The test never ran before, after the backport of some validation, this test started to run, and fail. Right now, l7 doesn't have support to http, and the protocol is TCP which should not have header inserted (it's not supported) so the right action is to just skip the test right now, since it never ran before anyway.

[Arx Cruz (arxcruz)]

Mark it as wont-fix because the test should not be executed in our environment anyway.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Ghanshyam <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/tripleo-ci/+/859830
Reason: TrieplO project is retiring now, for details, please see https://review.opendev.org/c/openstack/governance/+/905145 or reach out to OpenStack TC.