Update ovn_controller. fails with error Unsupported parameters for (tripleo_container_manage) module

[Mikolaj Ciecierski]

Description
===========

Update ovn_controller. task executed during minor update using `overcloud external-update run --tags ovn' fails with error: Unsupported parameters for (tripleo_container_manage) module: container_cli, log_path. Supported parameters include: config_dir, concurrency, config_overrides, log_base_path, debug, config_id, config_patterns."

Steps to reproduce
==================
Start minor update procedure:
1. Run `overcloud update prepare `
2. Run `overcloud external-update run --tags ovn`

Expected result
===============
Update ovn_controller. task completes from overcloud external-update run completes with success

Actual result
=============

Unsupported parameters failure

Environment
===========

Wallaby and master env tested and affected by the bug

Logs
===========
[[1;30m2022-09-12 06:29:02.081416 | fa163ec6-44cb-14aa-c9e1-00000000003b | TIMING | Update ovn_controller. | undercloud | 0:00:05.594820 | 3.18s^[[0m
2022-09-12 06:29:02.132491 | fa163ec6-44cb-14aa-c9e1-00000000003c | TASK | Was the ovn_controller successful.
[[0;31m2022-09-12 06:29:02.462045 | fa163ec6-44cb-14aa-c9e1-00000000003c | FATAL | Was the ovn_controller successful. | undercloud -> 192.168.24.101 | item={'failed': 0, 'started': 1, 'finished': 0, 'ansible_job_id': '576868135941.77844', 'results_file': '/tmp/.ansible_async/576868135941.77844', 'changed': True, 'item': 'master-compute-1', 'ansible_loop_var': 'item'} | error={"ansible_job_id": "576868135941.77844", "ansible_loop_var": "async_result_item", "async_result_item": {"ansible_job_id": "576868135941.77844", "ansible_loop_var": "item", "changed": true, "failed": 0, "finished": 0, "item": "master-compute-1", "results_file": "/tmp/.ansible_async/576868135941.77844", "started": 1}, "attempts": 1, "changed": false, "finished": 1, "msg": "Unsupported parameters for (tripleo_container_manage) module: container_cli, log_path. Supported parameters include: config_dir, concurrency, config_overrides, log_base_path, debug, config_id, config_patterns.", "results_file": "/tmp/.ansible_async/576868135941.77844", "started": 1, "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}^[[0m

[Rabi Mishra (rabi)]

Yes, there is a bug it seems. [1] should be 'log_base_path'.

[1] https://github.com/openstack/tripleo-heat-templates/blame/master/deployment/ovn/ovn-controller-container-puppet.yaml#L491

[Rabi Mishra (rabi)]

Also, container_cli is not a valid option.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/857199

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/857199
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/67c4988a5ac8cc248b8bee8a633dcb5fe7cb930d
Submitter: "Zuul (22348)"
Branch: master

commit 67c4988a5ac8cc248b8bee8a633dcb5fe7cb930d
Author: mciecier <email address hidden>
Date: Mon Sep 12 16:01:43 2022 +0200

    Fix Update ovn_controller. from external-update playbook

    Remove unsupported container_cli parameter and replace log_path with
    log_base_path in order in fix Update ovn_controller task. container_cli
    and log_path are not supported parameters for (tripleo_container_manage)
    module.

    Closes-Bug: #1989342
    Change-Id: Iadb78c5613f57cbdf92bbf8b40b0b9f83040d2a4

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/857433

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/857433
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/1c0ee8f48580c1d652f8e6a6da8db0ba3d4d8019
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 1c0ee8f48580c1d652f8e6a6da8db0ba3d4d8019
Author: mciecier <email address hidden>
Date: Mon Sep 12 16:01:43 2022 +0200

    Fix Update ovn_controller. from external-update playbook

    Remove unsupported container_cli parameter and replace log_path with
    log_base_path in order in fix Update ovn_controller task. container_cli
    and log_path are not supported parameters for (tripleo_container_manage)
    module.

    Closes-Bug: #1989342
    Change-Id: Iadb78c5613f57cbdf92bbf8b40b0b9f83040d2a4
    (cherry picked from commit 67c4988a5ac8cc248b8bee8a633dcb5fe7cb930d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 17.0.0 release.