[oslo_messaging_rabbit] heartbeat_in_pthread should be False for non-wsgi services

[Takashi Kajinami]

Description
===========
We have recently found an issue with recent oslo.messaging and some processes like nova-compute or neutron-server do not behave properly with the current defaults.

examples:
 https://bugs.launchpad.net/oslo.messaging/+bug/1934937
 https://bugs.launchpad.net/oslo.messaging/+bug/1961402

We are currently discussing disabling reverting the default value in oslo.messaging in oslo/stable team, but discussion about backportability is still under discussion.

Considering the impact of he problem, we should set this parameter to False now to workaround the problem until the issue is fixed in oslo.messaging.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/852579

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/852713

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/852579
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/cf4d4f881a1bf7011a3eae604eb83c8900f1b1a4
Submitter: "Zuul (22348)"
Branch: master

commit cf4d4f881a1bf7011a3eae604eb83c8900f1b1a4
Author: Takashi Kajinami <email address hidden>
Date: Tue Aug 9 21:44:00 2022 +0900

    Disable [oslo_messaging_rabbit] heartbeat_in_pthread

    Default value of this option was updated during Wallaby cycle[1] but
    the new default(true) is causing problems with non-wsgi services like
    nova-compute and we've learned these services are not able to behave
    properly in some cases(when starting up, reconnecting to MQ, etc)[2].

    This change overrides the parameter to use the old default value until
    the problem is fixed in oslo.messaging(or in any other layers).

    [1] https://review.opendev.org/c/openstack/oslo.messaging/+/747395
    [2] https://bugs.launchpad.net/oslo.messaging/+bug/1934937

    Closes-Bug: #1984076
    Related-Bug: #1934937
    Depends-on: https://review.opendev.org/852528
    Change-Id: I2bf0fbbb85a6d01f9004420df0b5937d2ba59759

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Takashi Kajinami <email address hidden>" on branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/852713
Reason: abandoning to rerun CI faster.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/852713
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/87cbe7c220f689cb9dac09bfe01b70960e296047
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 87cbe7c220f689cb9dac09bfe01b70960e296047
Author: Takashi Kajinami <email address hidden>
Date: Tue Aug 9 21:44:00 2022 +0900

    Disable [oslo_messaging_rabbit] heartbeat_in_pthread

    Default value of this option was updated during Wallaby cycle[1] but
    the new default(true) is causing problems with non-wsgi services like
    nova-compute and we've learned these services are not able to behave
    properly in some cases(when starting up, reconnecting to MQ, etc)[2].

    This change overrides the parameter to use the old default value until
    the problem is fixed in oslo.messaging(or in any other layers).

    [1] https://review.opendev.org/c/openstack/oslo.messaging/+/747395
    [2] https://bugs.launchpad.net/oslo.messaging/+bug/1934937

    Conflicts:
            deployment/aodh/aodh-base.yaml
            deployment/ceilometer/ceilometer-base-container-puppet.yaml
            deployment/designate/designate-base.yaml
            deployment/ironic/ironic-base-puppet.yaml
            deployment/manila/manila-base.yaml
            deployment/neutron/neutron-base.yaml
            deployment/nova/nova-base-puppet.yaml
            deployment/octavia/octavia-base.yaml
            deployment/swift/swift-proxy-container-puppet.yaml

    Closes-Bug: #1984076
    Related-Bug: #1934937
    Depends-on: https://review.opendev.org/852528
    Change-Id: I2bf0fbbb85a6d01f9004420df0b5937d2ba59759
    (cherry picked from commit cf4d4f881a1bf7011a3eae604eb83c8900f1b1a4)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 17.0.0 release.