openstack-tox-pep8 fails for openstack/cliff with E275

[Jiri Podivin]

The `assert` statement is written as a call to a function. This is technically possible, but irregular. Linters complain about it, at least in some runs, and cause job to fail.

Issue can be replicated on local machine, with invocation of 'tox -e pep8'.

Trace:
------
[notice] A new release of pip available: 22.2.1 -> 22.2.2
[notice] To update, run: pip install --upgrade pip
pep8 finish: installpkg /home/zuul/src/opendev.org/openstack/cliff/.tox/.tmp/package/1/cliff-3.10.2.dev19.zip after 2.32 seconds
pep8 start: envreport
setting PATH=/home/zuul/src/opendev.org/openstack/cliff/.tox/pep8/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
[2861] /home/zuul/src/opendev.org/openstack/cliff$ /home/zuul/src/opendev.org/openstack/cliff/.tox/pep8/bin/python -m pip freeze >.tox/pep8/log/pep8-1.log
pep8 finish: envreport after 0.49 seconds
pep8 installed: alabaster==0.7.12,attrs==22.1.0,autopage==0.5.1,Babel==2.10.3,bandit==1.7.4,certifi==2022.6.15,charset-normalizer==2.1.0,cliff @ file:///home/zuul/src/opendev.org/openstack/cliff/.tox/.tmp/package/1/cliff-3.10.2.dev19.zip,cmd2==2.4.2,coverage==6.4.2,docutils==0.19,extras==1.0.0,fixtures==4.0.1,flake8==5.0.4,future==0.18.2,gitdb==4.0.9,GitPython==3.1.27,idna==3.3,imagesize==1.4.1,importlib-metadata==4.12.0,Jinja2==3.1.2,MarkupSafe==2.1.1,mccabe==0.7.0,packaging==21.3,pbr==5.9.0,prettytable==3.3.0,pycodestyle==2.9.1,pyflakes==2.5.0,Pygments==2.12.0,pyparsing==3.0.9,pyperclip==1.8.2,python-subunit==1.4.0,pytz==2022.1,PyYAML==6.0,requests==2.28.1,smmap==5.0.0,snowballstemmer==2.2.0,Sphinx==5.1.1,sphinxcontrib-applehelp==1.0.2,sphinxcontrib-devhelp==1.0.2,sphinxcontrib-htmlhelp==2.0.0,sphinxcontrib-jsmath==1.0.1,sphinxcontrib-qthelp==1.0.3,sphinxcontrib-serializinghtml==1.1.5,stestr==3.2.1,stevedore==4.0.0,testscenarios==0.5.0,testtools==2.5.0,urllib3==1.26.11,voluptuous==0.13.1,wcwidth==0.2.5,zipp==3.8.1
pep8 start: run-test-pre
pep8 run-test-pre: PYTHONHASHSEED='2525613966'
pep8 finish: run-test-pre after 0.00 seconds
pep8 start: run-test
pep8 run-test: commands[0] | flake8 cliff doc/source/conf.py setup.py
setting PATH=/home/zuul/src/opendev.org/openstack/cliff/.tox/pep8/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
[2863] /home/zuul/src/opendev.org/openstack/cliff$ /home/zuul/src/opendev.org/openstack/cliff/.tox/pep8/bin/flake8 cliff doc/source/conf.py setup.py
cliff/tests/test_app.py:324:23: E275 missing whitespace after keyword
ERROR: InvocationError for command /home/zuul/src/opendev.org/openstack/cliff/.tox/pep8/bin/flake8 cliff doc/source/conf.py setup.py (exited with code 1)
pep8 finish: run-test after 0.67 seconds
pep8 start: run-test-post
pep8 finish: run-test-post after 0.00 seconds

Logs:
-----
https://zuul.opendev.org/t/openstack/build/dcd157c6a8cc4453958b511cec8af742

[Jiri Podivin (jpodivin)]

Fix committed as https://review.opendev.org/c/openstack/cliff/+/852177 and passed CI.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cliff 4.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cliff wallaby-eom release.