[CI][C9][Master] python-sqlalchemy addition in CS9 base broke container barbican_api_db_sync

[Dariusz Smigiel]

Tests for tripleo-ci upgrade started failing [0] on 2022-07-19 13:08:41
The issue: [1][2][3][4]

+ exec /usr/bin/bootstrap_host_exec barbican_api su barbican -s /bin/bash -c ''\''/usr/bin/barbican-manage' db upgrade \'
ERROR: The argument passed to Dialect.has_table() should be a <class 'sqlalchemy.engine.base.Connection'>, got <class 'sqlalchemy.engine.base.Engine'>. Additionally, the Dialect.has_table() method is for internal dialect use only; please use ``inspect(some_engine).has_table(<tablename>>)`` for public API use.

[0]: https://zuul.opendev.org/t/openstack/builds?job_name=tripleo-ci-centos-9-undercloud-upgrade&skip=0
[1]: https://536ba7636eca1576ae9f-4e53ffd70f9f0b38678a1c719bbe7de3.ssl.cf2.rackcdn.com/850349/1/check/tripleo-ci-centos-9-undercloud-upgrade/f43c1b0/logs/undercloud/home/zuul/undercloud_install.log
[2]: https://452b1fe13bf3ad38d63b-63986be9dd45a6c418e78618e601d4fb.ssl.cf2.rackcdn.com/850341/1/check/tripleo-ci-centos-9-undercloud-upgrade/e4cc9bb/logs/undercloud/home/zuul/undercloud_install.log
[3]: https://26ac4362fb28c9ae1745-4bfcd1a0cc7c3d4f9c4976468d7d6805.ssl.cf5.rackcdn.com/840158/1/gate/tripleo-ci-centos-9-undercloud-upgrade/0c9f08f/logs/undercloud/home/zuul/undercloud_install.log
[4]. https://536ba7636eca1576ae9f-4e53ffd70f9f0b38678a1c719bbe7de3.ssl.cf2.rackcdn.com/850349/1/check/tripleo-ci-centos-9-undercloud-upgrade/f43c1b0/logs/undercloud/var/log/extra/podman/containers/barbican_api_db_sync/stdout.log

[Dariusz Smigiel (smigiel-dariusz)]

Last working job doesn't have the barbican container [0] while first failing one includes it [1].

The job before failing which got cancelled [2], already has the barbican container.

[0]: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_c63/850222/4/check/tripleo-ci-centos-9-undercloud-upgrade/c6311cb/logs/undercloud/var/log/extra/podman/containers/index.html
[1]: https://26ac4362fb28c9ae1745-4bfcd1a0cc7c3d4f9c4976468d7d6805.ssl.cf5.rackcdn.com/840158/1/gate/tripleo-ci-centos-9-undercloud-upgrade/0c9f08f/logs/undercloud/var/log/extra/podman/containers/index.html
[2]: https://63bcf7c04a36b258ddfb-d8efb2c8dc9c4e35e02c540c6f97e75e.ssl.cf5.rackcdn.com/840156/2/gate/tripleo-ci-centos-9-undercloud-upgrade/38bfc8b/logs/undercloud/var/log/extra/podman/containers/index.html

[Ronelle Landy (rlandy)]

Looks like a similar error in:

https://030b0b339d494f5a846b-d880cdb4cc1983adbfeb24ef0c06b667.ssl.cf2.rackcdn.com/847237/1/gate/tripleo-ci-centos-9-undercloud-containers/2d36d1e/logs/undercloud/home/zuul/undercloud_install.log

ERROR: The argument passed to Dialect.has_table() should be a <class 'sqlalchemy.engine.base.Connection'>, got <class 'sqlalchemy.engine.base.Engine'>. Additionally, the Dialect.has_table() method is for internal dialect use only; please use ``inspect(some_engine).has_table(<tablename>>)`` for public API use.
2022-07-19 19:26:58.190243 | bc764e10-1131-b125-0d1f-000000001df0 | FATAL | Create containers managed by Podman for /var/lib/tripleo-config/container-startup-config/step_3 | undercloud | error={"changed": false, "msg": "Failed containers: barbican_api_db_sync"}

https://zuul.opendev.org/t/openstack/builds?job_name=tripleo-ci-centos-9-undercloud-containers&skip=0

[Ronelle Landy (rlandy)]

https://030b0b339d494f5a846b-d880cdb4cc1983adbfeb24ef0c06b667.ssl.cf2.rackcdn.com/847237/1/gate/tripleo-ci-centos-9-undercloud-containers/2d36d1e/logs/undercloud/var/log/extra/podman/containers/barbican_api_db_sync/stdout.log

ERROR: The argument passed to Dialect.has_table() should be a <class 'sqlalchemy.engine.base.Connection'>, got <class 'sqlalchemy.engine.base.Engine'>. Additionally, the Dialect.has_table() method is for internal dialect use only; please use ``inspect(some_engine).has_table(<tablename>>)`` for public API use.

[Ronelle Landy (rlandy)]

looks like the errors started with with new promotion of wallaby on 9 hours ago wallaby current-tripleo centos-9

[chandan kumar (chkumar246)]

https://bugzilla.redhat.com/show_bug.cgi?id=2084556 - Add python-sqlalchemy to RHEL 9.1 caused the issue.

[chandan kumar (chkumar246)]

https://review.opendev.org/c/openstack/barbican/+/796059 - inspect(some_engine).has_table is used here

[chandan kumar (chkumar246)]

We are going with this patch https://review.opendev.org/c/openstack/tripleo-quickstart/+/850442 once we have promotion, we will revert it in favor of https://review.rdoproject.org/r/c/openstack/barbican-distgit/+/44082

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-quickstart/+/850442
Committed: https://opendev.org/openstack/tripleo-quickstart/commit/1b30d001551efa6fd78082039e0e2900e7d6b4eb
Submitter: "Zuul (22348)"
Branch: master

commit 1b30d001551efa6fd78082039e0e2900e7d6b4eb
Author: Chandan Kumar (raukadah) <email address hidden>
Date: Wed Jul 20 12:44:28 2022 +0530

    Downgrade python3-sqlalchemy

    Wallaby tests are showing multiple errors since
    the last centos 9 stream compose was released.

    This patch rolls back some version to avoid
    the latest failures and uses the version from
    wallaby-deps.

    Related-Bug: #1982227
    Related-Bug: #1982195

    Signed-off-by: Chandan Kumar (raukadah) <email address hidden>
    Change-Id: Iae399de94350d0b1a6f5e75f6155e9013919ef8d

[OpenStack Infra (hudson-openstack)]

Change abandoned by "chandan kumar <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/tripleo-quickstart/+/850428

[Alfredo Moralejo (amoralej)]

Sent some cherry-picks upstream:

https://review.opendev.org/c/openstack/nova/+/852099
https://review.opendev.org/c/openstack/oslo.db/+/852097

[chandan kumar (chkumar246)]

850568: Revert "Downgrade python3-sqlalchemy" | https://review.opendev.org/c/openstack/tripleo-quickstart/+/850568 got +wed, we can close this bug now.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-quickstart/+/858030

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-quickstart/+/858030
Committed: https://opendev.org/openstack/tripleo-quickstart/commit/054053061579c626d960b38cd2bb0874de1651bb
Submitter: "Zuul (22348)"
Branch: master

commit 054053061579c626d960b38cd2bb0874de1651bb
Author: Marios Andreou <email address hidden>
Date: Fri Sep 16 07:55:35 2022 +0000

    Revert "Revert "Downgrade python3-sqlalchemy""

    This reverts commit ab4cff620fc31ecad36b42635a6bf538264eefab.

    Reason for revert: causing problems again new bug @ https://bugs.launchpad.net/tripleo/+bug/1989795

    Change-Id: I998f9e7ab1ef4713660a75f6bc77e5e43a08b549
    Related-Bug: 1989795
    Related-Bug: 1982195

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-quickstart/+/880136

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-quickstart/+/880136
Committed: https://opendev.org/openstack/tripleo-quickstart/commit/b97252d4d9bd52882037305e9ac876f2345ae025
Submitter: "Zuul (22348)"
Branch: master

commit b97252d4d9bd52882037305e9ac876f2345ae025
Author: Chandan Kumar <email address hidden>
Date: Wed Apr 12 14:34:32 2023 +0530

    Drop python3-sqlalchemy exclude from wallaby release file

    python-sqlalchemy13-1.3.24-3.el9s is already added in RDO
    wallaby repo[1].

    We donot need to pin it in the release file.

    [1]. https://review.rdoproject.org/r/q/topic:sqlalchemy13

    Closes-Bug: #1982195

    Change-Id: I81764ca5b241087c74dbcf8dc718ae84a469c70c
    Signed-off-by: Chandan Kumar <email address hidden>