The HeatConfigureDelegatedRoles parameter has no effect

[Takashi Kajinami]

Description
===========
The HeatConfigureDelegatedRoles parameter is supposed to determine whether trustor roles should be created.
However this parmaeter internally use the puppet parameter (heat::engine::configure_delegated_roles) which was already removed.

Also, there are a few more problems with its implementation.
 - The trusts_delegated_roles parameter in heat.conf is hardcoded to [], which means these trustor roles are not used.
 - Currently all keystone resources are managed by ansible so the roles should be created by ansible

Steps to reproduce
==================
- Deploy overcloud/standalone with HeatConfigureDelegatedRoles: true
- Check heat.conf
- Check keystone roles

Expected result
===============
- Trustor roles are created and listed in trusts_delegated_roles

Actual result
=============
- Trustor roles are never created

Environment
===========
The issue was initially found in master, but affects older releases (eg. train, wallaby)

Logs & Configs
==============
N/A

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/847570
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/491fefe7c54ac825cb1ed1957362acb89fc33b28
Submitter: "Zuul (22348)"
Branch: master

commit 491fefe7c54ac825cb1ed1957362acb89fc33b28
Author: Takashi Kajinami <email address hidden>
Date: Mon Jun 27 15:50:39 2022 +0900

    Fix ignored HeatConfigureDelegatedRoles

    The HeatConfigureDelegatedRoles parameter has been ignored since
    the puppet parameter internally used was renamed[1][2].

    This change fixes the ineffective parameter. Also, now management role
    is implemented by ansible, instead of puppet, following how keystone
    resources are managed now.

    [1] 74e874365933b3d7a07d6413762597e78efaaaa8
    [2] 1b209d35be143564d4592ef188ea5c0d906a8e96

    Closes-Bug: #1979950
    Change-Id: I3450f544597b82d053c33ac1b8ecc7d918fd73b0

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 17.0.0 release.