provisioning idempotency issue when capital letters in hostname

[Harald Jensås]

instance['hostname'] can have upparcase characters.
Neutron ports `dns_name` is always lowercase:

We find existing ports by running:

hostname = instance['hostname']
inst_ports = [port for port in inst_ports if port.dns_name == hostname]

In case instance['hostname'] has uppercase characters we will never see that a port already exists, and create a new port.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/845487

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/845487
Committed: https://opendev.org/openstack/tripleo-ansible/commit/04891f08a3b7c0de3708ef11722d205d17196fda
Submitter: "Zuul (22348)"
Branch: master

commit 04891f08a3b7c0de3708ef11722d205d17196fda
Author: Harald Jensås <email address hidden>
Date: Sat Jun 11 00:18:21 2022 +0200

    Fix port idempotency when uppercase in hostname

    When uppercase characters where used in instance hostname,
    new port was created each time node provisioning ran.

    Fix this issue by converting instance hostname to lowercase
    so that it can be compared to neutron port `dns_name` property
    which is always lowercase.

    Closes-Bug: #1978360
    Change-Id: Icb4b52f7922cf0eec3f5317db2051896e583d83e

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/845399

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/845399
Committed: https://opendev.org/openstack/tripleo-ansible/commit/b88744a61efd33d1987178ace284e410e42f89b8
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit b88744a61efd33d1987178ace284e410e42f89b8
Author: Harald Jensås <email address hidden>
Date: Sat Jun 11 00:18:21 2022 +0200

    Fix port idempotency when uppercase in hostname

    When uppercase characters where used in instance hostname,
    new port was created each time node provisioning ran.

    Fix this issue by converting instance hostname to lowercase
    so that it can be compared to neutron port `dns_name` property
    which is always lowercase.

    Closes-Bug: #1978360
    Change-Id: Icb4b52f7922cf0eec3f5317db2051896e583d83e
    (cherry picked from commit 04891f08a3b7c0de3708ef11722d205d17196fda)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ansible 5.0.0 release.