AttributeError: 'Service' object has no attribute 'enabled'

[Ananya Banerjee]

Overcloud deploy fails in task : Create identity service fails with AttributeError: 'Service' object has no attribute 'enabled'
We are seeing this in master clients component jobs.

https://logserver.rdoproject.org/openstack-component-clients/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-9-containers-multinode-clients-master/cd37e9e/logs/undercloud/home/zuul/overcloud_deploy.log.txt.gz
https://logserver.rdoproject.org/35/43135/5/check/periodic-tripleo-ci-centos-9-containers-multinode-clients-master/e9a2843/logs/undercloud/home/zuul/overcloud_deploy.log.txt.gz

https://logserver.rdoproject.org/openstack-component-clients/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-9-ovb-3ctlr_1comp-featureset001-clients-master/f2964ec/logs/undercloud/home/zuul/overcloud_deploy.log.txt.gz

 FATAL | Create identity service | undercloud | error={"changed": false, "module_stderr": "Traceback (most recent call last):\n File \"<stdin>\", line 107, in <module>\n File \"<stdin>\", line 99, in _ansiballz_main\n File \"<stdin>\", line 47, in invoke_module\n File \"/usr/lib64/python3.9/runpy.py\", line 210, in run_module\n return _run_module_code(code, init_globals, run_name, mod_spec)\n File \"/usr/lib64/python3.9/runpy.py\", line 97, in _run_module_code\n _run_code(code, mod_globals, init_globals,\n File \"/usr/lib64/python3.9/runpy.py\", line 87, in _run_code\n exec(code, run_globals)\n File \"/tmp/ansible_openstack.cloud.catalog_service_payload_ukau0rou/ansible_openstack.cloud.catalog_service_payload.zip/ansible_collections/openstack/cloud/plugins/modules/catalog_service.py\", line 185, in <module>\n File \"/tmp/ansible_openstack.cloud.catalog_service_payload_ukau0rou/ansible_openstack.cloud.catalog_service_payload.zip/ansible_collections/openstack/cloud/plugins/modules/catalog_service.py\", line 181, in main\n File \"/tmp/ansible_openstack.cloud.catalog_service_payload_ukau0rou/ansible_openstack.cloud.catalog_service_payload.zip/ansible_collections/openstack/cloud/plugins/module_utils/openstack.py\", line 407, in __call__\n File \"/tmp/ansible_openstack.cloud.catalog_service_payload_ukau0rou/ansible_openstack.cloud.catalog_service_payload.zip/ansible_collections/openstack/cloud/plugins/modules/catalog_service.py\", line 161, in run\n File \"/tmp/ansible_openstack.cloud.catalog_service_payload_ukau0rou/ansible_openstack.cloud.catalog_service_payload.zip/ansible_collections/openstack/cloud/plugins/modules/catalog_service.py\", line 114, in _needs_update\n File \"/usr/lib/python3.9/site-packages/openstack/resource.py\", line 641, in __getattribute__\n raise e\n File \"/usr/lib/python3.9/site-packages/openstack/resource.py\", line 630, in __getattribute__\n return object.__getattribute__(self, name)\nAttributeError: 'Service' object has no attribute 'enabled'\n", "module_stdout": "", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1}

[Ananya Banerjee (frenzyfriday)]

Comparing passing and failing logs:
https://logserver.rdoproject.org/openstack-component-clients/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-9-ovb-3ctlr_1comp-featureset001-clients-master/e0c6935/logs/undercloud/var/log/extra/rpm-list.txt.gz
https://logserver.rdoproject.org/35/43135/5/check/periodic-tripleo-ci-centos-9-containers-multinode-clients-master/e9a2843/logs/undercloud/var/log/extra/rpm-list.txt.gz

I see that openstacksdk version is
python3-openstacksdk-0.61.0-0.20211214092115.26c9bc2.el9.noarch for passing job
python3-openstacksdk-0.99.0-0.20220523180923.652faab.el9.noarch for failing jobs
while ansible-openstack-collections is ansible-collections-openstack-1.8.0-0.20220511140827.5bb8312.el9.noarch for both.
This might be due to the openstacksdk version as I think "enabled" changed to "is_enabled" for some modules

[Rabi Mishra (rabi)]

Right. https://review.opendev.org/c/openstack/tripleo-quickstart/+/843570 should possibly fix the ansible-openstack-collections/openstacksdk incompatibility issues.

[Marios Andreou (marios-b)]

@Rabi the patch at https://review.opendev.org/c/openstack/tripleo-quickstart/+/843570 is related but won't help us here

we are consuming pinned versions of these things (openstacksdk/ansible-collections-openstack)

I think the patch that broke these jobs is that https://github.com/redhat-openstack/rdoinfo/commit/67527c9f766b5f68ce0ba9039ff93035a0c6387c which bumped openstacksdk to 0.99

From example failing job there

         * https://logserver.rdoproject.org/openstack-component-clients/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-9-undercloud-upgrade-clients-master/2d87b43/logs/undercloud/var/log/extra/package-list-installed.txt.gz

        * ansible-collections-openstack.noarch 1.8.0-0.20220511140827.5bb8312.el9 @clients

        * python3-openstacksdk.noarch 0.99.0-0.20220523180923.652faab.el9 @clients

[Marios Andreou (marios-b)]

not sure if we can get away with that (if someone else really needs/depends-on 0.99?) but posted update for zed-uc.yml at https://review.rdoproject.org/r/c/rdoinfo/+/43207

otherwise we'll need to pin to that older version somehow as we are not ready for 0.99 yet

[Marios Andreou (marios-b)]

chatting with ykarel in rdo just now, we also need this https://review.rdoproject.org/r/c/openstack/openstacksdk-distgit/+/43214

[Marios Andreou (marios-b)]

k we have a couple of green runs now in the job history [1] latest example at [2]

moving fix-released

[1] https://review.rdoproject.org/zuul/builds?job_name=periodic-tripleo-ci-centos-9-containers-multinode-clients-master
[2] https://review.rdoproject.org/zuul/build/2e555efbf70242e0ba7649cc0baf6bc5