Validator: 'ArgumentParser' object has no attribute 'output_dir'

Bug #1970387 reported by Cristian Le
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Jiri Podivin

Bug Description

Using RDO trunk on CentOS9 stream on either master or yoga branch, I get the following error when running `openstack tripleo validator run `
```
'ArgumentParser' object has no attribute 'output_dir'
```
Python version is `3.9.10`

Jiri Podivin (jpodivin)
Changed in tripleo:
importance: Undecided → High
assignee: nobody → Jiri Podivin (jpodivin)
Changed in tripleo:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-tripleoclient (master)

Change abandoned by "Jiri Podivin <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/839200

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by "mbu <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/839363
Reason: Already adressed by Jirka

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/839383

Revision history for this message
Cristian Le (lecris) wrote :

Thank you for the very quick patches

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/839376
Committed: https://opendev.org/openstack/python-tripleoclient/commit/ea8795d00572dd613f38e91e2285c9b41cba4885
Submitter: "Zuul (22348)"
Branch: master

commit ea8795d00572dd613f38e91e2285c9b41cba4885
Author: Jiri Podivin <email address hidden>
Date: Tue Apr 26 15:07:37 2022 +0200

    Revert "Setting default inventory path for VF interface with ooo client."

    This reverts commit c42ee30017b268d46dd0e212a91986bda4d9c356.
    Closes-Bug: #1970387

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: I7b8900857da333318ad6eeab5d4eaefeb43e111a

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/839383
Committed: https://opendev.org/openstack/python-tripleoclient/commit/cc4f3efe2c25ee11c86a9d3b83b00a5211dcd4c2
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit cc4f3efe2c25ee11c86a9d3b83b00a5211dcd4c2
Author: Jiri Podivin <email address hidden>
Date: Tue Apr 26 15:07:37 2022 +0200

    Revert "Setting default inventory path for VF interface with ooo client."

    This reverts commit c42ee30017b268d46dd0e212a91986bda4d9c356.
    Closes-Bug: #1970387

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: I7b8900857da333318ad6eeab5d4eaefeb43e111a
    (cherry picked from commit ea8795d00572dd613f38e91e2285c9b41cba4885)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/839509
Committed: https://opendev.org/openstack/python-tripleoclient/commit/6a9db445d66a3426a5cfecedf5f0e07ffc664468
Submitter: "Zuul (22348)"
Branch: master

commit 6a9db445d66a3426a5cfecedf5f0e07ffc664468
Author: Jiri Podivin <email address hidden>
Date: Wed Apr 27 12:18:02 2022 +0200

    Improved test coverage for tripleo validator

    The validator run subcommand which was previously without
    any unit test coverage now has it's basic operation mode tested.

    Assertions are placed on calls and return values of the parser.

    The existing test structure was improved with enabling of autospec
    on mocked API.

    Closes-Bug: #1970387

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: I008ac81cd803adbd08a9509902e46967f8b7d2e4

Revision history for this message
Cristian Le (lecris) wrote :

About [this commit](https://opendev.org/openstack/python-tripleoclient/commit/ea8795d00572dd613f38e91e2285c9b41cba4885) shouldn't we still have some default inventory and/or to retrieve it from something like `--stack`? Right now it is very cryptic to newcomers how tripleo validator should be run, e.g. see discussion in [1970387](https://bugs.launchpad.net/tripleo/+bug/1971070)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 19.0.0

This issue was fixed in the openstack/python-tripleoclient 19.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.