growvols playbook fail 'ERROR! Specified hosts and/or --limit does not match any hosts' if role Count is 0.

Bug #1955432 reported by Harald Jensås
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Unassigned

Bug Description

Deploying with count == 0 in baremetal_deployment.yaml fails as there is an attempt to apply the growvols playbooks to a role (group) that does not exist.

- name: Controller
  count: 3
- name: Compute
  count: 0

Summary Information ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2021-12-16 21:51:08.519 | [WARNING]: Could not match supplied host pattern, ignoring: Compute
2021-12-16 21:51:08.521 | ERROR! Specified hosts and/or --limit does not match any hosts

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)
Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/822366
Committed: https://opendev.org/openstack/python-tripleoclient/commit/b9b9dbd74e01f97b2104b5319cd567913bc90ac8
Submitter: "Zuul (22348)"
Branch: master

commit b9b9dbd74e01f97b2104b5319cd567913bc90ac8
Author: Harald Jensås <email address hidden>
Date: Mon Dec 20 23:28:25 2021 +0100

    Don't run playbooks if role count == 0

    There is no reason to try to run playbooks limited
    to a role name when the role count is zero. It
    actually fails because no hosts match.

    Add a check to skip roles with count == 0.

    Closes-Bug: #1955432
    Change-Id: I5312e5362bdeac8337d1d0991e5a94ded5e83f3f

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/822414

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/822414
Committed: https://opendev.org/openstack/python-tripleoclient/commit/8aeed5ec37edf9e3cca65944828b99bc581931e2
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 8aeed5ec37edf9e3cca65944828b99bc581931e2
Author: Harald Jensås <email address hidden>
Date: Mon Dec 20 23:28:25 2021 +0100

    Don't run playbooks if role count == 0

    There is no reason to try to run playbooks limited
    to a role name when the role count is zero. It
    actually fails because no hosts match.

    Add a check to skip roles with count == 0.

    Closes-Bug: #1955432
    Change-Id: I5312e5362bdeac8337d1d0991e5a94ded5e83f3f
    (cherry picked from commit b9b9dbd74e01f97b2104b5319cd567913bc90ac8)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 18.0.0

This issue was fixed in the openstack/python-tripleoclient 18.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 16.5.0

This issue was fixed in the openstack/python-tripleoclient 16.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.