Undercloud upgrade won't start due to missing tripleo-undercloud-passwords.yaml file

[Jose Luis Franco]

During the initial upgrade testing from Train to Wallaby, the undercloud upgrade fails due to the following preflight validation:

2021-12-13 14:09:13 | The /home/stack/tripleo-deploy/undercloud/tripleo-undercloud-passwords.yaml file is missing. This will cause all service passwords to change and break the existing undercloud.
2021-12-13 14:09:13 | An error occurred during configuration validation, please check your host configuration and try again.
2021-12-13 14:09:13 | Error message: The /home/stack/tripleo-deploy/undercloud/tripleo-undercloud-passwords.yaml file is missing. This will cause all service passwords to change and break the existing undercloud.

However, this file is being created during the migration step to ephemeral heat which takes place at the beginning of the Undercloud upgrade:

https://github.com/openstack/tripleo-heat-templates/blob/stable/wallaby/deployment/undercloud/undercloud-upgrade-ephemeral-heat.yaml#L66-L67

https://github.com/openstack/tripleo-heat-templates/blob/stable/wallaby/scripts/undercloud-upgrade-ephemeral-heat.py#L392

Therefore, this preflight validation should be skipped when the command being triggered is an undercloud upgrade.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/821686

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Jose Luis Franco <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/821686
Reason: Abandon in favor of https://review.opendev.org/c/openstack/python-tripleoclient/+/821710