Port Name incorrectly set for OVNChassisMacPorts

[Harald Jensås]

https://opendev.org/openstack/tripleo-heat-templates/src/branch/stable/train/puppet/role.role.j2.yaml#L619-L629

  {{server_resource_name}}OVNChassisMacPorts:
    type: OS::Heat::ResourceGroup
    properties:
      count:
        yaql:
          expression: $.data.len()
          data: {get_param: OVNBridgeMappings}
      resource_def:
        type: OS::TripleO::OVNMacAddressPort
        properties:
          PortName: {{server_resource_name}}-ovn-mac-%index%

The "PortName": should hold the servers hostname + '-ovn-mac-%index%', i.e it should use '{get_attr: [{{server_resource_name}}, name]}'

{{server_resource_name}} is actually the role name[1] ...

[1] https://opendev.org/openstack/tripleo-heat-templates/src/branch/stable/train/puppet/role.role.j2.yaml#L4

[Harald Jensås (harald-jensas)]

This code is not present in master and wallaby.
So would be a stable releases fix only.