overcloud node extract provisioned - should not set subnet on ctlplane

[Harald Jensås]

Metalsmith does not support both network and subnet key in a NIC definition.
Since the ctlplane port is vif: true the subnet to use is automated via ironic port physical_network and neutron physical_network segment mapping.

overcloud node extract provisioned should not set the subnet key for the ctlplane network.

[1] https://opendev.org/openstack/python-tripleoclient/src/branch/master/tripleoclient/v1/overcloud_node.py#L572-L574

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/821327

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/821327
Committed: https://opendev.org/openstack/python-tripleoclient/commit/ddfd6d99404ed4b5cb24d4b1e278283c603a23bd
Submitter: "Zuul (22348)"
Branch: master

commit ddfd6d99404ed4b5cb24d4b1e278283c603a23bd
Author: Harald Jensås <email address hidden>
Date: Thu Dec 9 23:44:01 2021 +0100

    Don't set 'subnet' for ctlplane in node extract

    Metalsmith does not support both network and subnet
    key in a NIC definition. Since the ctlplane port has
    vif: True, the subnet to use is automated via ironic
    port physical_network and neutron physical_network
    segment mapping. Setting the subnet is not neccecary
    in this case.

    Change-Id: I8ac9fee84d1c830c0df4f34088c12aec98323dbb
    Closes-Bug: #1954341

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/822519

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/822519
Committed: https://opendev.org/openstack/python-tripleoclient/commit/a1912be8964479b1ce7b3ccbe5934862bda4a4b8
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit a1912be8964479b1ce7b3ccbe5934862bda4a4b8
Author: Harald Jensås <email address hidden>
Date: Thu Dec 9 23:44:01 2021 +0100

    Don't set 'subnet' for ctlplane in node extract

    Metalsmith does not support both network and subnet
    key in a NIC definition. Since the ctlplane port has
    vif: True, the subnet to use is automated via ironic
    port physical_network and neutron physical_network
    segment mapping. Setting the subnet is not neccecary
    in this case.

    Change-Id: I8ac9fee84d1c830c0df4f34088c12aec98323dbb
    Closes-Bug: #1954341
    (cherry picked from commit ddfd6d99404ed4b5cb24d4b1e278283c603a23bd)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 18.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 16.5.0 release.