fence-agents packages are uninstalled when building a hardened image

[Damien Ciabrini]

When building an overcloud image like e.g.:

openstack overcloud image build --image-name overcloud-hardened-full --config-file /usr/share/openstack-tripleo-common/image-yaml/overcloud-hardened-images-python3.yaml --config-file /usr/share/openstack-tripleo-common/image-yaml/overcloud-hardened-images-rhel8.yaml

all the fence agents are installed via package fence-agents-all.

However this one depends on telnet, which gets removed when building a hardened image, and consequently the fence agents gets removed automatically as well:

2021-11-19 12:27:18.565 | + echo '# empty ruleset created by tripleo-image-elements'
2021-11-19 12:27:18.565 | + echo '# empty ruleset created by tripleo-image-elements'
2021-11-19 12:27:18.566 | dib-run-parts 99-empty-iptables completed
2021-11-19 12:27:18.566 | dib-run-parts Running /tmp/in_target.d/install.d/99-package-uninstalls
2021-11-19 12:27:19.590 | Map uninstall for overcloud-secure: kexec-tools, telnet
2021-11-19 12:27:19.591 | Running command: ['install-packages', '-e', 'kexec-tools', 'telnet']
2021-11-19 12:27:19.591 | > Running install-packages remove.
2021-11-19 12:27:19.591 | > + dnf -v -y remove kexec-tools telnet
2021-11-19 12:27:19.591 | > Loaded plugins: builddep, changelog, config-manager, copr, debug, debuginfo-install, download, generate_completion_cache, needs-restarting, playground, repoclosure, repodiff, repograph, repomanage, reposync, uploadprofile
2021-11-19 12:27:19.591 | > DNF version: 4.2.17
2021-11-19 12:27:19.591 | > cachedir: /tmp/yum
2021-11-19 12:27:19.591 | > User-Agent: constructed: 'libdnf (Red Hat Enterprise Linux 8.2; generic; Linux.x86_64)'
2021-11-19 12:27:19.591 | > No module defaults found
2021-11-19 12:27:19.591 | > --> Starting dependency resolution
2021-11-19 12:27:19.591 | > --> Finding unneeded leftover dependencies
2021-11-19 12:27:19.591 | > ---> Package PackageKit.x86_64 1.1.12-4.el8 will be erased
2021-11-19 12:27:19.591 | > ---> Package PackageKit-glib.x86_64 1.1.12-4.el8 will be erased
2021-11-19 12:27:19.591 | > ---> Package autogen-libopts.x86_64 5.18.12-7.el8 will be erased
2021-11-19 12:27:19.591 | > ---> Package cockpit-bridge.x86_64 211.3-1.el8 will be erased
2021-11-19 12:27:19.591 | > ---> Package cockpit-system.noarch 211.3-1.el8 will be erased
2021-11-19 12:27:19.591 | > ---> Package device-mapper-multipath.x86_64 0.8.3-3.el8_2.3 will be erased
2021-11-19 12:27:19.591 | > ---> Package device-mapper-multipath-libs.x86_64 0.8.3-3.el8_2.3 will be erased
2021-11-19 12:27:19.591 | > ---> Package dracut-network.x86_64 049-70.git20200228.el8 will be erased
2021-11-19 12:27:19.591 | > ---> Package dracut-squash.x86_64 049-70.git20200228.el8 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-all.x86_64 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-amt-ws.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-apc.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-apc-snmp.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-bladecenter.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-brocade.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-cisco-mds.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-cisco-ucs.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-common.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-compute.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-drac5.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-eaton-snmp.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-emerson.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-eps.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-heuristics-ping.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-hpblade.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-ibmblade.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-ifmib.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-ilo-moonshot.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-ilo-mp.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-ilo-ssh.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-ilo2.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-intelmodular.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-ipdu.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-ipmilan.noarch 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-kdump.x86_64 4.2.1-41.el8_2.5 will be erased
2021-11-19 12:27:19.591 | > ---> Package fence-agents-mpath.noarch 4.2.1-41.el8_2.5 will be erased

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-puppet-elements/+/818566

[Juan Badia Payno (jbadiapa)]

fix proposed to master:
https://review.opendev.org/c/openstack/tripleo-puppet-elements/+/818184

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Damien Ciabrini <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/tripleo-puppet-elements/+/818566