python-tripleoclient "overcloud_delete.py" doesn't link to the inventory

[Cédric Jeanneret]

The inventory passed to utils.run_ansible_playbook in v2/overcloud_delete.py is wrong: it doesn't use the "parsed_args.stack" parameter and, therefore, only the string template is provided:

/home/stack/config-download/{}/tripleo-ansible-inventory.yaml

when it should pass:

/home/stack/config-download/overcloud/tripleo-ansible-inventory.yaml

It wasn't detected before because we don't have TLS-e with freeIPA deploy in CI, and the cli-overcloud-delete.yaml playbook doesn't use the OC inventory data at all - running only locally in the UC.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/816998

[Cédric Jeanneret (cjeanner)]

Correction is also needed in wallaby:
https://opendev.org/openstack/python-tripleoclient/src/branch/stable/wallaby/tripleoclient/v2/overcloud_delete.py#L118

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/816998
Committed: https://opendev.org/openstack/python-tripleoclient/commit/9fd913f57cd5584c65c069af90037d72aa9db7cf
Submitter: "Zuul (22348)"
Branch: master

commit 9fd913f57cd5584c65c069af90037d72aa9db7cf
Author: Cédric Jeanneret <email address hidden>
Date: Mon Nov 8 12:32:09 2021 +0100

    Ensure we're using the stackname for the inventory

    Until now, the inventory path used by the overcloud_delete.py was wrong,
    since it wasn't using the "stackname", leading to a wrong
    /home/stack/config-download/{}/tripleo-ansible-inventory.yaml path.

    While it's not a big issue with non-TLS-e deploy, it becomes an actual
    problem when we involve FreeIPA and TLS-e, since the deletion won't
    remove the nodes nor services from FreeIPA.

    Closes-Bug: #1950155

    Change-Id: I5941bf9948c5f17e7406d34c21b8de9bd174c063

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/817101

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/817101
Committed: https://opendev.org/openstack/python-tripleoclient/commit/914709dd74d4a0ea09dedc3aacc06a0488ef89e4
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 914709dd74d4a0ea09dedc3aacc06a0488ef89e4
Author: Cédric Jeanneret <email address hidden>
Date: Mon Nov 8 12:32:09 2021 +0100

    Ensure we're using the stackname for the inventory

    Until now, the inventory path used by the overcloud_delete.py was wrong,
    since it wasn't using the "stackname", leading to a wrong
    /home/stack/config-download/{}/tripleo-ansible-inventory.yaml path.

    While it's not a big issue with non-TLS-e deploy, it becomes an actual
    problem when we involve FreeIPA and TLS-e, since the deletion won't
    remove the nodes nor services from FreeIPA.

    Closes-Bug: #1950155

    Change-Id: I5941bf9948c5f17e7406d34c21b8de9bd174c063
    (cherry picked from commit 9fd913f57cd5584c65c069af90037d72aa9db7cf)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 18.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 16.5.0 release.