Tripleo-quickstart does not deploy the servers with the flavors that the VMs were created for

[Juan Badia Payno]

After provisioning the servers the VMs weren't assigned to the proper flavors.

(undercloud) [stack@undercloud ~]$ metalsmith list
+--------------------------------------+-----------+--------------------------------------+-------------------------+--------+------------------------+
| UUID | Node Name | Allocation UUID | Hostname | State | IP Addresses |
+--------------------------------------+-----------+--------------------------------------+-------------------------+--------+------------------------+
| 0e6aa469-bb32-45b7-8524-859046ba6012 | control-0 | 76296a0b-a8db-4095-a42a-7b2b771adb3d | overcloud-novacompute-0 | ACTIVE | ctlplane=192.168.24.28 |
| 2564e323-9bb2-49e4-82d4-b26ae555bb3a | control-1 | 74687ca0-b703-4644-9e17-a30082b53f3a | overcloud-cephstorage-1 | ACTIVE | ctlplane=192.168.24.27 |
| bba34d13-ea97-4fa3-a150-6d8975b66660 | control-2 | 645716ff-77f6-4e62-b1bc-979af0cbf0b4 | overcloud-novacompute-1 | ACTIVE | ctlplane=192.168.24.13 |
| 2ef97a79-80bf-4c22-adb1-562cda283d17 | compute-0 | 08ffaf1c-ec4d-4851-ac09-68afbeab75a3 | overcloud-controller-0 | ACTIVE | ctlplane=192.168.24.12 |
| 2da76e74-03e7-4b2b-a3b7-ac8218988484 | compute-1 | 3f2b271b-b091-4f24-bdbf-e974e093dcda | overcloud-controller-1 | ACTIVE | ctlplane=192.168.24.8 |
| 87900ae6-d8aa-4fec-8342-f5e9a8b10b0f | ceph-0 | ce4cb2f3-78c1-4ab4-afc4-209cc676027d | overcloud-cephstorage-0 | ACTIVE | ctlplane=192.168.24.22 |
| e4a5b346-69ef-48a6-92b3-f6596e2063bd | ceph-1 | d273b97f-ddb0-444d-b64a-6cee90cee697 | overcloud-controller-2 | ACTIVE | ctlplane=192.168.24.11 |
| dbdd3f7c-67bf-4f57-b8f0-a4947047023c | ceph-2 | 5ce4bf6e-cd32-431a-8e29-c5934868de06 | overcloud-cephstorage-2 | ACTIVE | ctlplane=192.168.24.14 |
+--------------------------------------+-----------+--------------------------------------+-------------------------+--------+------------------------+

To avoid this issue the instances can be configured in the overcloud_baremetal_deploy.yaml before provision them.

As an example:

- name: Controller
  count: 3
  instances:
  - hostname: overcloud-controller-0
    name: control-0
  - hostname: overcloud-controller-1
    name: control-1
  - hostname: overcloud-controller-2
    name: control-2
  defaults:
    networks:
      - network: ctlplane
        vif: true
      - network: external
        subnet: external_subnet
      - network: internal_api
        subnet: internal_api_subnet
      - network: storage
        subnet: storage_subnet
      - network: storage_mgmt
        subnet: storage_mgmt_subnet
      - network: tenant
        subnet: tenant_subnet

    network_config:
      default_route_network:
      - external
      template: templates/multiple_nics/multiple_nics_dvr.j2

  ansible_playbooks:
  - playbook: /usr/share/ansible/tripleo-playbooks/cli-overcloud-node-growvols.yaml
    extra_vars:
      growvols_args: /=8GB /tmp=1GB /var/log=10GB /var/log/audit=2GB /home=1GB /var=50% /srv=50%
...

To reproduce it: (whole_disk_images=false)

 ./quickstart.sh -n -X -R master-tripleo-ci --tags all -T none --nodes config/nodes/3ctlr_2comp_3ceph.yml -p quickstart.yml 127.0.0.2
./quickstart.sh -R master-tripleo-ci --no-clone --tags all -I -T none --nodes config/nodes/3ctlr_2comp_3ceph.yml -p quickstart-extras-undercloud.yml 127.0.0.2
./quickstart.sh -R master-tripleo-ci --no-clone --tags all -I -T none --nodes config/nodes/3ctlr_2comp_3ceph.yml -p quickstart-extras-overcloud-prep.yml 127.0.0.2
./quickstart.sh -R master-tripleo-ci --no-clone --tags overcloud-scripts -I -T none --nodes config/nodes/3ctlr_2comp_3ceph.yml -p quickstart-extras-overcloud.yml 127.0.0.2

(undercloud) [stack@undercloud ~]$ openstack overcloud network provision -y -o overcloud-networks-deployed.yaml /usr/share/openstack-tripleo-heat-templates/ci/network_data.yaml
(undercloud) [stack@undercloud ~]$ openstack overcloud network vip provision -y -o overcloud-vips-deployed.yaml --stack overcloud /usr/share/openstack-tripleo-heat-templates/ci/vip_data.yaml
(undercloud) [stack@undercloud ~]$ openstack overcloud node provision -o overcloud-baremetal-deployed.yaml --stack overcloud overcloud_baremetal_deploy.yaml

[Juan Badia Payno (jbadiapa)]

Proposed patch:
https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/797452

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/797452
Committed: https://opendev.org/openstack/tripleo-quickstart-extras/commit/d8622a2e5271e7832de03f87f30555efe82370f4
Submitter: "Zuul (22348)"
Branch: master

commit d8622a2e5271e7832de03f87f30555efe82370f4
Author: Juan Badia Payno <email address hidden>
Date: Tue Jun 22 15:40:57 2021 +0200

    Create overcloud_baremetal_deploy.yaml file properly

    Currently the overcloud_baremetal_deploy does not match the
    VMs with the flavor/role properly. The way that
    currently creates the file may deploy the compute on
    a ceph or a controller vm.

    This way the vms will be used for the role that
    they were created

    Closes-Bug: #1949070
    Change-Id: I4de262fc049b74482ff7220a11ec864133f1cb75