undercloud upgrade tries to upgrade python2 tripleoclient under centos8

[Alex Schultz]

In order to track the python2/python3 transition, we tried to handle the package version by using the python executable version the upgrade was invoked with. Unfortunately with newer versions the `openstack` command uses platform-python so the version check is incorrect.

2021-09-24 10:43:30.483 933909 WARNING tripleoclient.v1.undercloud.UpgradeUndercloud [ ] Updating necessary packages: python2-tripleoclient openstack-tripleo-common openstack-tripleo-heat-templates openstack-tripleo-validations tripleo-ansible

We probably should just remove this logic because we no longer need to handle the python2 case.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/811468

[yatin (yatinkarel)]

Also upgrade job hitting it ex:- https://e31f9be4742ab987838e-5d50e8ef24c23b6b3512cdd707b25e49.ssl.cf1.rackcdn.com/806562/5/check/tripleo-ci-centos-8-undercloud-upgrade/ddb1069/logs/undercloud/home/zuul/undercloud_upgrade.log

[Marios Andreou (marios-b)]

bug and patch at https://review.opendev.org/c/openstack/python-tripleoclient/+/811468 makes sense but i don't understand why we are only hitting this in some jobs?

for example, the job is pretty green everywhere other than tripleo-quickstart-extras [1] and
for t-q-e it has *some* fails not consistent [2] - eg i see some success there after the fail pointed to in comment #2.

[1] https://zuul.openstack.org/builds?job_name=tripleo-ci-centos-8-undercloud-upgrade
[2] https://zuul.openstack.org/builds?job_name=tripleo-ci-centos-8-undercloud-upgrade&project=openstack%2Ftripleo-quickstart-extras

[yatin (yatinkarel)]

<< bug and patch at https://review.opendev.org/c/openstack/python-tripleoclient/+/811468 makes sense but i don't understand why we are only hitting this in some jobs?

ohkk i checked again, and tripleoclient should be upgraded even before with https://opendev.org/openstack/tripleo-upgrade/src/branch/master/tasks/common/undercloud_prerequisites.yaml#L8-L12 but due to gating-repo priority tripleoclient installed from wallaby, since now wallaby backport got merged job should pass in that patch.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/811468
Committed: https://opendev.org/openstack/python-tripleoclient/commit/9ec115216f9a40190c62b9c63dc45aa0e1fe5ee6
Submitter: "Zuul (22348)"
Branch: master

commit 9ec115216f9a40190c62b9c63dc45aa0e1fe5ee6
Author: Alex Schultz <email address hidden>
Date: Tue Sep 28 12:08:47 2021 -0600

    Drop python2 logic for upgrades

    We no longer need to handle this case and the logic doesn't work now
    that packaging uses platform-python.

    Change-Id: Ic506842240417142230e39755e7663b9276d4e34
    Closes-Bug: #1945357

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/812212

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/812212
Committed: https://opendev.org/openstack/python-tripleoclient/commit/1e1394a66b7cfaa1be7d22e5d7ebad652585892a
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 1e1394a66b7cfaa1be7d22e5d7ebad652585892a
Author: Alex Schultz <email address hidden>
Date: Tue Sep 28 12:08:47 2021 -0600

    Drop python2 logic for upgrades

    We no longer need to handle this case and the logic doesn't work now
    that packaging uses platform-python.

    Change-Id: Ic506842240417142230e39755e7663b9276d4e34
    Closes-Bug: #1945357
    (cherry picked from commit 9ec115216f9a40190c62b9c63dc45aa0e1fe5ee6)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 17.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 16.5.0 release.