New molecule version wants a specific namespace/role_name format

Bug #1943965 reported by Cédric Jeanneret
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Critical
Unassigned

Bug Description

With molecule being bumped to 3.5.1 in order to solve #1943170, there's apparently a new format check embedded:

ERROR Computed fully qualified role name of OpenStack.tripleo_sshd does not follow current galaxy requirements.
Please edit meta/main.yml and assure we can correctly determine full role name:

galaxy_info:
role_name: my_name # if absent directory name hosting role is used instead
namespace: my_galaxy_namespace # if absent, author is used instead

Namespace: https://galaxy.ansible.com/docs/contributing/namespaces.html#galaxy-namespace-limitations
Role: https://galaxy.ansible.com/docs/contributing/creating_role.html#role-names

Example:
https://zuul.opendev.org/t/openstack/build/eeab23830a9d47bca8dd0a8fd9195c8e

Apparently, we "just" need to inject "namespace: openstack" in the galaxy_info dict, for all the roles:
"""
Namespace names in Galaxy are limited to lowercase word characters (i.e., a-z, 0-9) and ‘_’, must have a minimum length of 2 characters, and cannot start with an ‘_’. No other characters are allowed, including ‘.’, ‘-‘, and space.
"""

OpenStack isn't valid with this limitation.

Revision history for this message
Cédric Jeanneret (cjeanner) wrote :

2 solutions:
- either change the value of "author" and change it to lowercase
- or inject "namespace: openstack"

This will affect all the repositories running molecule with a CamelCase author and now namespace.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (master)
Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/809643
Committed: https://opendev.org/openstack/tripleo-ansible/commit/1cb8d44e0f2c87a63db69ba239388558b8d01f73
Submitter: "Zuul (22348)"
Branch: master

commit 1cb8d44e0f2c87a63db69ba239388558b8d01f73
Author: Kevin Carter <email address hidden>
Date: Fri Sep 17 07:40:57 2021 -0500

    fix galaxy meta requirements

    Also takes the opportunity to ignore "meta" directory from molecule
    jobs. Since we apparently can't use "irrevelant_files" with "files",
    we're using a negative look-ahead regexpi[1], to take all BUT "meta.*".

    [1] https://www.regular-expressions.info/lookaround.html

    NOTE: this patch also toggle tripleo-ansible-centos-8-role-addition to
    non-voting in order to get this change merged. This job times out on a
    regular basis, and prevents this needed patch to merge. Follow-up are
    needed, for instance calling "pip-compile" as it's now done here:
    https://review.opendev.org/c/openstack/tripleo-quickstart/+/807491

    Closes-Bug: 1943965
    Change-Id: I84d077c6daefdbeda4fda2d1f8fdd400c7437500
    Signed-off-by: Kevin Carter <email address hidden>

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
Juan Badia Payno (jbadiapa) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/810574

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/810574
Committed: https://opendev.org/openstack/tripleo-ansible/commit/25e4f53ea9f6e396fd47ae8283298e40344dcf3e
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 25e4f53ea9f6e396fd47ae8283298e40344dcf3e
Author: Kevin Carter <email address hidden>
Date: Fri Sep 17 07:40:57 2021 -0500

    fix galaxy meta requirements

    Also takes the opportunity to ignore "meta" directory from molecule
    jobs. Since we apparently can't use "irrevelant_files" with "files",
    we're using a negative look-ahead regexpi[1], to take all BUT "meta.*".

    [1] https://www.regular-expressions.info/lookaround.html

    NOTE: this patch also toggle tripleo-ansible-centos-8-role-addition to
    non-voting in order to get this change merged. This job times out on a
    regular basis, and prevents this needed patch to merge. Follow-up are
    needed, for instance calling "pip-compile" as it's now done here:
    https://review.opendev.org/c/openstack/tripleo-quickstart/+/807491

    Closes-Bug: 1943965
    Change-Id: I84d077c6daefdbeda4fda2d1f8fdd400c7437500
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 1cb8d44e0f2c87a63db69ba239388558b8d01f73)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible 4.1.0

This issue was fixed in the openstack/tripleo-ansible 4.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.