Redundant file ACLs for neutron when upgrading from older version of OpenStack

[Purandhar Sairam Mannidi]

tripleo-heat-templates is having redundant upgrade tasks to apply file ACLs on /var/lib/neutron when upgrading from older version of OpenStack (from Mitaka / Newton) which was used to resolve a situation arising from upgrading a tripleo env with system services to containerized services.

Expected result
===============
No ACLs should be applied to /var/lib/neutron

Actual Results:
===============
ACLs are applied to /var/lib/neutron as part of post-upgrade tasks.

Additional Details
===========
Latest OpenStack code at https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/deployment/neutron/neutron-l3-container-puppet.yaml#L368-L397

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/807974

[wes hayutin (weshayutin)]

sorry.. going to use this bug for a moment, to test tooling.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/807974
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/a522941695e07d943c4908b4f403edf9d24f0108
Submitter: "Zuul (22348)"
Branch: master

commit a522941695e07d943c4908b4f403edf9d24f0108
Author: Purandhar Sairam Mannidi <email address hidden>
Date: Thu Sep 9 10:02:53 2021 +1000

    Remove setting ACLs during Upgrade

    Currently, we are setting file ACLs on /var/lib/neutron as part of
    upgrade tasks if there is a neutron user in the system. Since moving to
    containerized deployment, we don't have neutron user on the system
    anymore. This code was added to resolve issues arising with existing
    neutron resources when moving from system services to containerized
    services.

    This patch is to remove the stale upgrade tasks to remove file ACLs.

    Closes-Bug: #1943034

    Signed-off-by: Purandhar Sairam Mannidi <email address hidden>
    Change-Id: I19f457a99dedfd781bd56987e3fea6626737500d

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/808669

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/808669
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/b9fe05d56c4aa7645b900fc92bfac2f45da91c20
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit b9fe05d56c4aa7645b900fc92bfac2f45da91c20
Author: Purandhar Sairam Mannidi <email address hidden>
Date: Thu Sep 9 10:02:53 2021 +1000

    Remove setting ACLs during Upgrade

    Currently, we are setting file ACLs on /var/lib/neutron as part of
    upgrade tasks if there is a neutron user in the system. Since moving to
    containerized deployment, we don't have neutron user on the system
    anymore. This code was added to resolve issues arising with existing
    neutron resources when moving from system services to containerized
    services.

    This patch is to remove the stale upgrade tasks to remove file ACLs.

    Closes-Bug: #1943034

    Signed-off-by: Purandhar Sairam Mannidi <email address hidden>
    Change-Id: I19f457a99dedfd781bd56987e3fea6626737500d
    (cherry picked from commit a522941695e07d943c4908b4f403edf9d24f0108)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/809967

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/809967
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/2d21dcce74df7affbf1a91aff18da3dc3840c74f
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 2d21dcce74df7affbf1a91aff18da3dc3840c74f
Author: Purandhar Sairam Mannidi <email address hidden>
Date: Thu Sep 9 10:02:53 2021 +1000

    Remove setting ACLs during Upgrade

    Currently, we are setting file ACLs on /var/lib/neutron as part of
    upgrade tasks if there is a neutron user in the system. Since moving to
    containerized deployment, we don't have neutron user on the system
    anymore. This code was added to resolve issues arising with existing
    neutron resources when moving from system services to containerized
    services.

    This patch is to remove the stale upgrade tasks to remove file ACLs.

    Closes-Bug: #1943034

    Signed-off-by: Purandhar Sairam Mannidi <email address hidden>
    Change-Id: I19f457a99dedfd781bd56987e3fea6626737500d
    (cherry picked from commit a522941695e07d943c4908b4f403edf9d24f0108)
    (cherry picked from commit b9fe05d56c4aa7645b900fc92bfac2f45da91c20)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/810058

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/810058
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/193d2311a3d7b878d303965c419248f9e9c35fdc
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 193d2311a3d7b878d303965c419248f9e9c35fdc
Author: Purandhar Sairam Mannidi <email address hidden>
Date: Thu Sep 9 10:02:53 2021 +1000

    Remove setting ACLs during Upgrade

    Currently, we are setting file ACLs on /var/lib/neutron as part of
    upgrade tasks if there is a neutron user in the system. Since moving to
    containerized deployment, we don't have neutron user on the system
    anymore. This code was added to resolve issues arising with existing
    neutron resources when moving from system services to containerized
    services.

    This patch is to remove the stale upgrade tasks to remove file ACLs.

    Closes-Bug: #1943034

    Signed-off-by: Purandhar Sairam Mannidi <email address hidden>
    Change-Id: I19f457a99dedfd781bd56987e3fea6626737500d
    (cherry picked from commit a522941695e07d943c4908b4f403edf9d24f0108)
    (cherry picked from commit b9fe05d56c4aa7645b900fc92bfac2f45da91c20)
    (cherry picked from commit 2d21dcce74df7affbf1a91aff18da3dc3840c74f)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/810203

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/810203
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/28f96b1f6a73c40588ab7dcf50d546a2d8de895d
Submitter: "Zuul (22348)"
Branch: stable/train

commit 28f96b1f6a73c40588ab7dcf50d546a2d8de895d
Author: Purandhar Sairam Mannidi <email address hidden>
Date: Thu Sep 9 10:02:53 2021 +1000

    Remove setting ACLs during Upgrade

    Currently, we are setting file ACLs on /var/lib/neutron as part of
    upgrade tasks if there is a neutron user in the system. Since moving to
    containerized deployment, we don't have neutron user on the system
    anymore. This code was added to resolve issues arising with existing
    neutron resources when moving from system services to containerized
    services.

    This patch is to remove the stale upgrade tasks to remove file ACLs.

    Closes-Bug: #1943034

    Signed-off-by: Purandhar Sairam Mannidi <email address hidden>
    Change-Id: I19f457a99dedfd781bd56987e3fea6626737500d
    (cherry picked from commit a522941695e07d943c4908b4f403edf9d24f0108)
    (cherry picked from commit b9fe05d56c4aa7645b900fc92bfac2f45da91c20)
    (cherry picked from commit 2d21dcce74df7affbf1a91aff18da3dc3840c74f)
    (cherry picked from commit 193d2311a3d7b878d303965c419248f9e9c35fdc)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 15.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 12.4.6 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 13.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates train-eol release.