puppet-openstack-unit-* unit tests are failing in puppet-tripleo gate/check

[Ronelle Landy]

The following puppet-openstack-unit-* tests are failing in puppet-tripleo reviews:

puppet-openstack-unit-6.21-centos-8-stream
puppet-openstack-unit-7.8-centos-8-stream
puppet-openstack-unit-6.21-ubuntu-focal
puppet-openstack-unit-7.8-ubuntu-focal

Example output:

2021-08-26 12:40:00.342197 | centos-8-stream | /usr/bin/ruby -I/home/zuul/workspace/.bundled_gems/gems/rspec-core-3.10.1/lib:/home/zuul/workspace/.bundled_gems/gems/rspec-support-3.10.2/lib /home/zuul/workspace/.bundled_gems/gems/rspec-core-3.10.1/exe/rspec --pattern spec/\{aliases,classes,defines,functions,hosts,integration,plans,tasks,type_aliases,types,unit\}/\*\*/\*_spec.rb failed
2021-08-26 12:40:00.717143 | centos-8-stream | ERROR
2021-08-26 12:40:00.717583 | centos-8-stream | {
2021-08-26 12:40:00.717703 | centos-8-stream | "delta": "0:14:58.653809",
2021-08-26 12:40:00.717837 | centos-8-stream | "end": "2021-08-26 12:40:00.348740",
2021-08-26 12:40:00.717951 | centos-8-stream | "msg": "non-zero return code",
2021-08-26 12:40:00.718066 | centos-8-stream | "rc": 1,
2021-08-26 12:40:00.718140 | centos-8-stream | "start": "2021-08-26 12:25:01.694931"
2021-08-26 12:40:00.718241 | centos-8-stream | }

Example failures in review:

https://review.opendev.org/c/openstack/puppet-tripleo/+/798407/

https://zuul.opendev.org/t/openstack/builds?job_name=puppet-openstack-unit-6.21-centos-8-stream shows that the failures started today 08/26.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/806251

[Takashi Kajinami (kajinamit)]

Looking at the example builds, the failure is caused by duplicated declaration of Package[redis].
This seems to be caused by a change in underlying puppet-redis.

My current guess is the recent change[1] is not working properly with puppetlabs-7.x.x which is now used in our gate.

[1] https://github.com/voxpupuli/puppet-redis/commit/a5cc0a194afd2b17564e90939ff5e08f63d3d3f8

https://zuul.opendev.org/t/openstack/build/8c9c796e24e041b3a7cd93e03dd79742

2021-08-26 12:45:29.542463 | centos-8-stream | 1) tripleo::profile::base::database::redis on redhat-8-x86_64 behaves like tripleo::profile::base::database::redis with step 2 with multiple nodes should configure redis
2021-08-26 12:45:29.542486 | centos-8-stream | Failure/Error: function_create_resources([type.capitalize, { item => params }])
2021-08-26 12:45:29.542507 | centos-8-stream |
2021-08-26 12:39:59.966309 | centos-8-stream | Puppet::PreformattedError:
2021-08-26 12:39:59.966327 | centos-8-stream | Evaluation Error: Error while evaluating a Function Call, Duplicate declaration: Package[redis] is already declared at (file: /home/zuul/workspace/spec/fixtures/modules/redis/manifests/install.pp, line: 5); cannot redeclare (file: /home/zuul/workspace/spec/fixtures/modules/redis/manifests/sentinel.pp, line: 150) (file: /home/zuul/workspace/spec/fixtures/modules/redis/manifests/sentinel.pp, line: 150, column: 3) on node centos-8-stream-rax-dfw-0026118171

https://zuul.opendev.org/t/openstack/build/ed83c226333d4223ad0f30a0917eb768

2021-08-26 12:45:29.542463 | centos-8-stream | 1) tripleo::profile::base::database::redis on redhat-8-x86_64 behaves like tripleo::profile::base::database::redis with step 2 with multiple nodes should configure redis
2021-08-26 12:45:29.542486 | centos-8-stream | Failure/Error: function_create_resources([type.capitalize, { item => params }])
2021-08-26 12:45:29.542507 | centos-8-stream |
2021-08-26 12:45:29.542528 | centos-8-stream | Puppet::PreformattedError:
2021-08-26 12:45:29.542554 | centos-8-stream | Evaluation Error: Error while evaluating a Function Call, Duplicate declaration: Package[redis] is already declared at (file: /home/zuul/workspace/spec/fixtures/modules/redis/manifests/install.pp, line: 5); cannot redeclare (file: /home/zuul/workspace/spec/fixtures/modules/redis/manifests/sentinel.pp, line: 150) (file: /home/zuul/workspace/spec/fixtures/modules/redis/manifests/sentinel.pp, line: 150, column: 3) on node centos-8-stream-rax-dfw-0026118219

https://zuul.opendev.org/t/openstack/build/8e6dd104f19746ef9aa09f55272e0358

2021-08-26 12:53:16.606990 | ubuntu-focal | 1) tripleo::profile::base::database::redis on redhat-8-x86_64 behaves like tripleo::profile::base::database::redis with step 2 with multiple nodes should configure redis
2021-08-26 12:53:16.607001 | ubuntu-focal | Failure/Error: function_create_resources([type.capitalize, { item => params }])
2021-08-26 12:53:16.607012 | ubuntu-focal |
2021-08-26 12:53:16.607022 | ubuntu-focal | Puppet::PreformattedError:
2021-08-26 12:53:16.607109 | ubuntu-focal | Evaluation Error: Error while evaluating a Function Call, Duplicate declaration: Package[redis]...

[Takashi Kajinami (kajinamit)]

We observe the same problem in
 https://review.opendev.org/c/openstack/puppet-tripleo/+/798407/
and
 https://review.opendev.org/c/openstack/puppet-tripleo/+/801075/
so I think we can assume this is the consistent problem now.

Note:
We should pin puppet-redis in U, V and W as well.
These branches are still using puppet-redis master.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-tripleo/+/806251
Committed: https://opendev.org/openstack/puppet-tripleo/commit/4931d2cce84c61c764214360e4cf9f9a4083cdd2
Submitter: "Zuul (22348)"
Branch: master

commit 4931d2cce84c61c764214360e4cf9f9a4083cdd2
Author: Takashi Kajinami <email address hidden>
Date: Fri Aug 27 02:09:15 2021 +0900

    Pin puppet-redis to 8.0.0

    ... because recent change to adopt to stdlib 8.0.0[1] causes duplicated
    declaration of Package['redis'] when stdlib 7.y.z is used.

    [1] https://github.com/voxpupuli/puppet-redis/commit/a5cc0a194afd2b17564e90939ff5e08f63d3d3f8

    Closes-Bug: #1941772
    Change-Id: Ibb4ad7bf54b1e41f1cd62373e711c8efa00d7751

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/806302

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/806303

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/806304

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-tripleo/+/806302
Committed: https://opendev.org/openstack/puppet-tripleo/commit/73fc6a7f9521f26769b7dcef37efa07219c2f63c
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 73fc6a7f9521f26769b7dcef37efa07219c2f63c
Author: Takashi Kajinami <email address hidden>
Date: Fri Aug 27 02:09:15 2021 +0900

    Pin puppet-redis to 8.0.0

    ... because recent change to adopt to stdlib 8.0.0[1] causes duplicated
    declaration of Package['redis'] when stdlib 7.y.z is used.

    [1] https://github.com/voxpupuli/puppet-redis/commit/a5cc0a194afd2b17564e90939ff5e08f63d3d3f8

    Closes-Bug: #1941772
    Change-Id: Ibb4ad7bf54b1e41f1cd62373e711c8efa00d7751
    (cherry picked from commit 4931d2cce84c61c764214360e4cf9f9a4083cdd2)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-tripleo/+/806303
Committed: https://opendev.org/openstack/puppet-tripleo/commit/3529a584b3415d6e5f5223a071a0082593995f49
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 3529a584b3415d6e5f5223a071a0082593995f49
Author: Takashi Kajinami <email address hidden>
Date: Fri Aug 27 02:09:15 2021 +0900

    Pin puppet-redis to 8.0.0

    ... because recent change to adopt to stdlib 8.0.0[1] causes duplicated
    declaration of Package['redis'] when stdlib 7.y.z is used.

    [1] https://github.com/voxpupuli/puppet-redis/commit/a5cc0a194afd2b17564e90939ff5e08f63d3d3f8

    Closes-Bug: #1941772
    Change-Id: Ibb4ad7bf54b1e41f1cd62373e711c8efa00d7751
    (cherry picked from commit 4931d2cce84c61c764214360e4cf9f9a4083cdd2)
    (cherry picked from commit 73fc6a7f9521f26769b7dcef37efa07219c2f63c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-tripleo/+/806304
Committed: https://opendev.org/openstack/puppet-tripleo/commit/1081ab94169ca51af5d3900517dec54bd551988a
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 1081ab94169ca51af5d3900517dec54bd551988a
Author: Takashi Kajinami <email address hidden>
Date: Fri Aug 27 02:09:15 2021 +0900

    Pin puppet-redis to 8.0.0

    ... because recent change to adopt to stdlib 8.0.0[1] causes duplicated
    declaration of Package['redis'] when stdlib 7.y.z is used.

    [1] https://github.com/voxpupuli/puppet-redis/commit/a5cc0a194afd2b17564e90939ff5e08f63d3d3f8

    Conflicts:
            Puppetfile_extras

    Closes-Bug: #1941772
    Change-Id: Ibb4ad7bf54b1e41f1cd62373e711c8efa00d7751
    (cherry picked from commit 4931d2cce84c61c764214360e4cf9f9a4083cdd2)
    (cherry picked from commit 73fc6a7f9521f26769b7dcef37efa07219c2f63c)
    (cherry picked from commit 3529a584b3415d6e5f5223a071a0082593995f49)

[Takashi Kajinami (kajinamit)]

Hmm... I thought this was caused by some change in puppetlabs-stdlib, but after having a second look, now I feel like this is a bug in puppet-redis.

I have proposed the change to puppet-redis https://github.com/voxpupuli/puppet-redis/pull/413/files .

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-tripleo/+/806609
Committed: https://opendev.org/openstack/puppet-tripleo/commit/e5e2a45506dfdbe5b85092733fee8ad4e056a72f
Submitter: "Zuul (22348)"
Branch: master

commit e5e2a45506dfdbe5b85092733fee8ad4e056a72f
Author: Takashi Kajinami <email address hidden>
Date: Tue Aug 31 00:12:20 2021 +0900

    Revert "Pin puppet-redis to 8.0.0"

    This reverts commit 4931d2cce84c61c764214360e4cf9f9a4083cdd2.

    Reason for revert:
    This issue was caused by a duplicate declaration detected when redis
    and redis::sentinel are both included and old puppetlabs-stdlib is
    used, but now redis::sentinel is no longer used.

    Related-Bug: #1941772
    Change-Id: I0e4cf41b16fcbfd2260f84bd07a8b940de20dbc8

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 16.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 12.7.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 13.7.0 release.