pacemaker_cluster module is passed invalid arguments

[Brendan Shephard]

Description:

In the update_steps, pacemaker_cluster is passed the argument check_and_fail. This is not valid with the pacemaker_cluster ansible module and causes the update process to fail at that task:

https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/pacemaker/pacemaker-baremetal-puppet.yaml#L220

https://docs.ansible.com/ansible/latest/collections/community/general/pacemaker_cluster_module.html

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/803534

[Brendan Shephard (bshephar)]

So we can revert to the one we're shipping in ansible-pacemaker. Or update the community version, but that will mean maintaining two copies of the same module afaik unless we want to drop one of them.

[stack@tripleo-director ~]$ sudo find /usr/share/ansible -name pacemaker_cluster.py
/usr/share/ansible/collections/ansible_collections/community/general/plugins/modules/clustering/pacemaker_cluster.py
/usr/share/ansible/collections/ansible_collections/community/general/plugins/modules/pacemaker_cluster.py
/usr/share/ansible/plugins/modules/pacemaker_cluster.py

ansible-pacemaker-1.0.4-0.20210623140808.666f706.el8.noarch : Ansible modules for managing Pacemaker clusters
Repo : delorean-component-tripleo
Matched from:
Filename : /usr/share/ansible/plugins/modules/pacemaker_cluster.py

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/803534
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/b0caee4753efd5f5d0f769d73bb8826dc8466de2
Submitter: "Zuul (22348)"
Branch: master

commit b0caee4753efd5f5d0f769d73bb8826dc8466de2
Author: Brendan Shephard <email address hidden>
Date: Thu Aug 5 01:44:23 2021 +0000

    Revert change to use community pacemaker_cluster module

    The community pacemaker_cluster module is not in sync
    with the real pacemaker_cluster module causing failures.

    https://github.com/ansible-collections/community.general/blob/main/plugins/modules/clustering/pacemaker_cluster.py#L19-L39
    vs
    https://github.com/redhat-openstack/ansible-pacemaker/blob/master/modules/pacemaker_cluster.py#L32-L58

    This causes failures in the minor update process.

    Related: Ie96b3d35cea61370b1f98d7e060d696c4807c6b7
    Closes-Bug: #1938967
    Change-Id: Id65f0eef7249588d6038883f703d8e587826a4ac

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/804993

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/804993
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/2a6d751fa0f0b4eb0975575352a663a162162376
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 2a6d751fa0f0b4eb0975575352a663a162162376
Author: Brendan Shephard <email address hidden>
Date: Thu Aug 5 01:44:23 2021 +0000

    Revert change to use community pacemaker_cluster module

    The community pacemaker_cluster module is not in sync
    with the real pacemaker_cluster module causing failures.

    https://github.com/ansible-collections/community.general/blob/main/plugins/modules/clustering/pacemaker_cluster.py#L19-L39
    vs
    https://github.com/redhat-openstack/ansible-pacemaker/blob/master/modules/pacemaker_cluster.py#L32-L58

    This causes failures in the minor update process.

    Related: Ie96b3d35cea61370b1f98d7e060d696c4807c6b7
    Closes-Bug: #1938967
    Change-Id: Id65f0eef7249588d6038883f703d8e587826a4ac
    (cherry picked from commit b0caee4753efd5f5d0f769d73bb8826dc8466de2)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 15.1.0 release.