ci.centos jobs can't find tripleo_overcloud_image_upload role

[Ronelle Landy]

Jobs running in ci.centos are failing when trying to run the 'tripleo_overcloud_image_upload' role.

The full error is copied below:

2021-07-31 21:26:52.472 | TASK [Run overcloud image upload via tripleo-operator-ansible] *****************
2021-07-31 21:26:52.472 | task path: /home/jenkins/workspace/tripleo-quickstart-promote-wallaby-current-tripleo-delorean-minimal/usr/local/share/ansible/roles/overcloud-prep-images/tasks/overcloud-prep-images.yml:13
2021-07-31 21:26:52.472 | Saturday 31 July 2021 21:26:52 +0000 (0:00:00.029) 0:48:55.618 *********
2021-07-31 21:26:52.505 | ERROR! the role 'tripleo_overcloud_image_upload' was not found in tripleo.operator:ansible.legacy:/home/jenkins/workspace/tripleo-quickstart-promote-wallaby-current-tripleo-delorean-minimal/playbooks/roles:/home/jenkins/workspace/tripleo-quickstart-promote-wallaby-current-tripleo-delorean-minimal/tripleo-quickstart/roles:/home/jenkins/workspace/tripleo-quickstart-promote-wallaby-current-tripleo-delorean-minimal/usr/local/share/tripleo-quickstart/roles:/home/jenkins/workspace/tripleo-quickstart-promote-wallaby-current-tripleo-delorean-minimal/usr/local/share/ansible/roles:/home/jenkins/workspace/tripleo-quickstart-promote-wallaby-current-tripleo-delorean-minimal/usr/local/share/opstools-ansible/roles:/home/jenkins/workspace/tripleo-quickstart-promote-wallaby-current-tripleo-delorean-minimal/share/ansible/roles:/home/jenkins/workspace/tripleo-quickstart-promote-wallaby-current-tripleo-delorean-minimal/usr/share/ansible/roles:/usr/share/ansible/roles:/home/jenkins/workspace/tripleo-quickstart-promote-wallaby-current-tripleo-delorean-minimal/playbooks
2021-07-31 21:26:52.505 |
2021-07-31 21:26:52.505 | The error appears to be in '/home/jenkins/workspace/tripleo-quickstart-promote-wallaby-current-tripleo-delorean-minimal/usr/local/share/ansible/roles/overcloud-prep-images/tasks/overcloud-prep-images.yml': line 17, column 15, but may
2021-07-31 21:26:52.505 | be elsewhere in the file depending on the exact syntax problem.
2021-07-31 21:26:52.505 |
2021-07-31 21:26:52.505 | The offending line appears to be:
2021-07-31 21:26:52.505 |
2021-07-31 21:26:52.505 | include_role:
2021-07-31 21:26:52.505 | name: tripleo_overcloud_image_upload
2021-07-31 21:26:52.505 | ^ here

https://github.com/openstack/tripleo-quickstart/commit/ea6e1c21728c1b7f4a3ecd68b3fafe5afc7295c3 removed tripleo-operator-ansible from requirements. The install is happening via rpm.

The role path is not picking up this role now.

Log link:

https://artifacts.ci.centos.org/rdo/jenkins-tripleo-quickstart-promote-wallaby-current-tripleo-delorean-minimal-24/console.log

This is impacting all releases.

[chandan kumar (chkumar246)]

I think the issue is here: https://opendev.org/openstack/tripleo-quickstart/src/branch/master/roles/convert-image/defaults/main.yml#L16 is used to convert overcloud and undercloud and then install python-tripleoclient to drive the deployment.

Since tripleo-operator-ansible is not installed during conversion so that the deployment fails to discover those playbook and leading to failing the deployment.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-quickstart/+/803134

[Marios Andreou (marios-b)]

fixes from Chandan at https://review.opendev.org/c/openstack/tripleo-quickstart/+/803134 & https://review.opendev.org/c/openstack/tripleo-quickstart/+/803307

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-ci/+/803336

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-quickstart/+/803307
Committed: https://opendev.org/openstack/tripleo-quickstart/commit/444fcff6b17b77778382cd0be5a45f7b85a7b7ca
Submitter: "Zuul (22348)"
Branch: master

commit 444fcff6b17b77778382cd0be5a45f7b85a7b7ca
Author: Chandan Kumar (raukadah) <email address hidden>
Date: Tue Aug 3 11:06:14 2021 +0530

    Install tripleo-operator-ansible on cico node

    As in ci.centos jobs, quickstart.sh is getting executed on
    cico slave node where we donot sudo access. The playbook
    execution is failing as tripleo-operator-ansible roles
    are not getting discovered.

    Since https://review.opendev.org/c/openstack/tripleo-quickstart/+/790701
    already removed the git installation of tripleo-operator-ansible
    and we cannot install it via rpm so the failure is legit.

    In order to fix that, we need to install tripleo-operator-ansible
    from git on cico nodes.

    Since it is kept under ci-base-requirements.txt used only in
    ci.centos jobs so it is not going to affect any other
    deployments.

    Related-Bug: #1938638

    Signed-off-by: Chandan Kumar (raukadah) <email address hidden>
    Change-Id: Id7c8404914c73f3b72480ba64c0e60e9dcdf27fb

[OpenStack Infra (hudson-openstack)]

Change abandoned by "chandan kumar <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/tripleo-quickstart/+/803134

[chandan kumar (chkumar246)]

https://review.opendev.org/c/openstack/tripleo-ci/+/803336 and https://review.opendev.org/c/openstack/tripleo-quickstart/+/803307 fixes the issue, we can move it to fix released.

[Marios Andreou (marios-b)]

https://review.opendev.org/c/openstack/tripleo-ci/+/803336 still not merged

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-ci/+/803336
Committed: https://opendev.org/openstack/tripleo-ci/commit/9efd855e786ddc906085a3b23a4fb6054e66f7e5
Submitter: "Zuul (22348)"
Branch: master

commit 9efd855e786ddc906085a3b23a4fb6054e66f7e5
Author: Chandan Kumar (raukadah) <email address hidden>
Date: Tue Aug 3 18:46:25 2021 +0530

    Install tripleo-operator-ansible from git for baremetal

    In baremetal deployment, quickstart execution is done from
    zuul node and quickstart depends on tripleo-operator-ansible.

    Since https://review.opendev.org/c/openstack/tripleo-quickstart/+/790701
    already removed the git installation of tripleo-operator-ansible
    and we cannot install it via rpm so the failure is legit.

    In order to fix that, we need to install tripleo-operator-ansible
    from git on zuul node.

    Related-Bug: #1938638

    Signed-off-by: Chandan Kumar (raukadah) <email address hidden>
    Change-Id: I1fd588f02195dc09620f4950029faacb98b85eed