Various jobs failing deploy puppet config (puppet-neutron) step 1 Unknown function: 'warn'

[Marios Andreou]

At [1][2][3] (various jobs affected) the undercloud install fails during puppet config step1 with trace like:

 2021-07-23 04:31:29.123984 | | WARNING | ERROR: Can't run container container-puppet-neutron
 stderr: + /usr/bin/puppet apply --summarize --detailed-exitcodes --color=false --modulepath=/etc/puppet/modules:/usr/share/openstack-puppet/modules --tags '"file,file_line,concat,augeas,cron,neutron_config,ironic_neutron_agent_config,neutron_config,neutron_api_config,neutron_plugin_ml2,neutron_config,neutron_dhcp_agent_config,neutron_config,neutron_l3_agent_config,neutron_config,neutron_agent_ovs,neutron_plugin_ml2"' /etc/config.pp
 + logger -s -t puppet-user
 <13>Jul 23 04:30:40 puppet-user: Warning: /etc/puppet/hiera.yaml: Use of 'hiera.yaml' version 3 is deprecated. It should be converted to version 5
 <13>Jul 23 04:30:44 puppet-user: (file: /etc/puppet/hiera.yaml)
 <13>Jul 23 04:30:44 puppet-user: Warning: Undefined variable '::deploy_config_name';
 <13>Jul 23 04:30:44 puppet-user: (file & line not available)
 <13>Jul 23 04:30:44 puppet-user: Warning: The function 'hiera' is deprecated in favor of using 'lookup'. See https://puppet.com/docs/puppet/7.8/deprecated_language.html
 <13>Jul 23 04:30:44 puppet-user: (file & line not available)
 <13>Jul 23 04:30:45 puppet-user: Warning: This method is deprecated, please use match expressions with Stdlib::Compat::Array instead. They are described at https://docs.puppet.com/puppet/latest/reference/lang_data_type.html#match-expressions. at ["/etc/puppet/modules/neutron/manifests/init.pp", 482]:["/etc/puppet/modules/tripleo/manifests/profile/base/neutron/agents/networking_baremetal.pp", 31]
 <13>Jul 23 04:30:45 puppet-user: (location: /etc/puppet/modules/stdlib/lib/puppet/functions/deprecation.rb:36:in `deprecation')
 <13>Jul 23 04:30:45 puppet-user: Error: Evaluation Error: Unknown function: 'warn'. (file: /etc/puppet/modules/neutron/manifests/agents/ml2/networking_baremetal.pp, line: 147, column: 5) on node undercloud.localdomain
 + rc=1
 + '[' false = false ']'
 + set +x
 2021-07-23 04:31:29.125903 | fa163eb8-f8d3-becf-b727-000000001079 | FATAL | Manage Puppet containers (generate config) for step 1 | undercloud | error={"changed": false, "msg": "Failed containers: container-puppet-neutron"}

This seems to be caused by the recent merge at [4] and it blocks the gate see [5]

[1] https://df04c129a3fb0b1c135c-2dcc7383799adb6a1c83021c20182aaa.ssl.cf5.rackcdn.com/799916/1/gate/tripleo-ci-centos-8-undercloud-upgrade/cd8836a/logs/undercloud/home/zuul/undercloud_upgrade.log
[2] https://4676a671550dbf2716a6-49efd684bfe013929d3e78dde3afb985.ssl.cf5.rackcdn.com/799916/1/gate/tripleo-ci-centos-8-scenario000-multinode-oooq-container-updates/b8caac6/logs/undercloud/home/zuul/undercloud_install.log
[3] https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_69b/799916/1/gate/tripleo-ci-centos-8-undercloud-containers/69be597/logs/undercloud/home/zuul/undercloud_install.log
[4] https://review.opendev.org/c/openstack/puppet-neutron/+/796359
[5] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/799916/1#message-49a43010a5edc5f7823975889e752fb4072372d2

[Marios Andreou (marios-b)]

posted a revert for the puppet-neutron patch at https://review.opendev.org/c/openstack/puppet-neutron/+/801879

[Marios Andreou (marios-b)]

OK instead of the revert in comment #1 let's try Takashi patch at https://review.opendev.org/c/openstack/puppet-neutron/+/801933

testing with https://review.rdoproject.org/r/c/testproject/+/34650

[Marios Andreou (marios-b)]

Takashi also adding a relevant job to puppet-neutron to prevent similar issue in the future https://review.opendev.org/c/openstack/puppet-neutron/+/801936/3

[Marios Andreou (marios-b)]

this also blocks the periodic integration promotion line e.g. [1]

The fix at https://review.opendev.org/c/openstack/puppet-neutron/+/801933 looks good (green run on test https://review.rdoproject.org/r/c/testproject/+/34650) but hitting some issues trying to get puppet-neutron/+/801933 merged (e.g. [2]).

[1] https://logserver.rdoproject.org/openstack-periodic-integration-main/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-8-ovb-1ctlr_2comp-featureset020-master/db22544/logs/undercloud/home/zuul/undercloud_install.log.txt.gz
[2] https://review.opendev.org/c/openstack/puppet-neutron/+/801933/1#message-5a0eef40cd55034a153012c35c10fbfd49ab7912

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-neutron/+/801933
Committed: https://opendev.org/openstack/puppet-neutron/commit/ab03d57aafe7acbfffd515e0eb953e0dd0070773
Submitter: "Zuul (22348)"
Branch: master

commit ab03d57aafe7acbfffd515e0eb953e0dd0070773
Author: Takashi Kajinami <email address hidden>
Date: Fri Jul 23 14:51:42 2021 +0900

    Fix wrong method name

    This change fixes the wrong method name introduced by commit
    09429d0ebc6bff6aed5808faf7c4430e72d2dafb .

    Closes-Bug: #1937333
    Change-Id: I6513eb610a9dfd64f30f4d5cb465cb8b0ff2d897

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-neutron 19.1.0 release.

[Takashi Kajinami (kajinamit)]

The issue was fixed in puppet-neutron and we have nothing to do in TripleO.
So closing this bug as invalid.