TypeError: The 'validation_id' argument should be a List

Bug #1936465 reported by Rabi Mishra
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Critical
Jiri Podivin

Bug Description

Undercloud install fails with tarceback[1]

Noticed at https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_a44/800420/1/gate/tripleo-ci-centos-8-undercloud-containers/a442270/logs/undercloud/home/zuul/undercloud_install.log

Looks like https://github.com/openstack/validations-libs/commit/2f3b09d41ef8feaaf6438693551ea8aaf3a83892#diff-90b69462813c80b251c23eab92a0bbc66c389a46396df69ec705f47898eb9f9a broke it.

[1]
undercloud_admin_host or undercloud_public_host is not in the same cidr as local_ip.
Exception occured while running the command
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/tripleoclient/command.py", line 34, in run
    super(Command, self).run(parsed_args)
  File "/usr/lib/python3.6/site-packages/osc_lib/command/command.py", line 39, in run
    return super(Command, self).run(parsed_args)
  File "/usr/lib/python3.6/site-packages/cliff/command.py", line 185, in run
    return_code = self.take_action(parsed_args) or 0
  File "/usr/lib/python3.6/site-packages/tripleoclient/v1/undercloud.py", line 154, in take_action
    disable_container_prepare=parsed_args.disable_container_prepare)
  File "/usr/lib/python3.6/site-packages/tripleoclient/v1/undercloud_config.py", line 807, in prepare_undercloud_deploy
    undercloud_preflight.check(verbose_level, upgrade)
  File "/usr/lib/python3.6/site-packages/tripleoclient/v1/undercloud_preflight.py", line 501, in check
    _check_diskspace(upgrade)
  File "/usr/lib/python3.6/site-packages/tripleoclient/v1/undercloud_preflight.py", line 98, in _check_diskspace
    validation_name=playbook_args['playbook'])
  File "/usr/lib/python3.6/site-packages/validations_libs/validation_actions.py", line 348, in run_validations
    group)
  File "/usr/lib/python3.6/site-packages/validations_libs/utils.py", line 210, in get_validations_playbook
    raise TypeError("The 'validation_id' argument should be a List")
TypeError: The 'validation_id' argument should be a List
The 'validation_id' argument should be a List

Jiri Podivin (jpodivin)
Changed in tripleo:
assignee: nobody → Jiri Podivin (jpodivin)
Jiri Podivin (jpodivin)
Changed in tripleo:
status: Triaged → In Progress
tags: added: alert ci promotion-blocker
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)
Revision history for this message
Jiri Podivin (jpodivin) wrote :

I have submitted a fix to the python-tripleoclient. [0]

[0]https://review.opendev.org/c/openstack/python-tripleoclient/+/801019

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to validations-libs (master)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/801019
Committed: https://opendev.org/openstack/python-tripleoclient/commit/efdefd92de54d2dd0803f0367bf89bb577927037
Submitter: "Zuul (22348)"
Branch: master

commit efdefd92de54d2dd0803f0367bf89bb577927037
Author: Jiri Podivin <email address hidden>
Date: Fri Jul 16 08:39:22 2021 +0200

    Passes playbook to the validation action as a list

    Recent removal of the 'validations_libs.utils.convert_data'
    function, implemented by the Ief9459e914ea73fbd59a85c07a55c26078e0126a,
    resulted in a change of accepted argument types of
    the 'validations_libs.validation_actions' methods.

    This patch turns the passed argument from string into a list.

    Closes-bug: #1936465

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: I4e96f5a0e013de5abcde837dad3c5f9d5228dd4c

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
Bhagyashri Shewale (bhagyashri-shewale) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/801232

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/801234

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/801258

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/801232
Committed: https://opendev.org/openstack/python-tripleoclient/commit/e0f12ac4be6222fc2b1634ff167b5c83bed54815
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit e0f12ac4be6222fc2b1634ff167b5c83bed54815
Author: Jiri Podivin <email address hidden>
Date: Fri Jul 16 08:39:22 2021 +0200

    Passes playbook to the validation action as a list

    Recent removal of the 'validations_libs.utils.convert_data'
    function, implemented by the Ief9459e914ea73fbd59a85c07a55c26078e0126a,
    resulted in a change of accepted argument types of
    the 'validations_libs.validation_actions' methods.

    This patch turns the passed argument from string into a list.

    Closes-bug: #1936465

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: I4e96f5a0e013de5abcde837dad3c5f9d5228dd4c
    (cherry picked from commit efdefd92de54d2dd0803f0367bf89bb577927037)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/801234
Committed: https://opendev.org/openstack/python-tripleoclient/commit/9b3bd5f5bec92655893a127c45083cbb618c5b66
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 9b3bd5f5bec92655893a127c45083cbb618c5b66
Author: Jiri Podivin <email address hidden>
Date: Fri Jul 16 08:39:22 2021 +0200

    Passes playbook to the validation action as a list

    Recent removal of the 'validations_libs.utils.convert_data'
    function, implemented by the Ief9459e914ea73fbd59a85c07a55c26078e0126a,
    resulted in a change of accepted argument types of
    the 'validations_libs.validation_actions' methods.

    This patch turns the passed argument from string into a list.

    Closes-bug: #1936465

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: I4e96f5a0e013de5abcde837dad3c5f9d5228dd4c
    (cherry picked from commit efdefd92de54d2dd0803f0367bf89bb577927037)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/801258
Committed: https://opendev.org/openstack/python-tripleoclient/commit/265c15ab2ff13f2a50f0e75773550a824365b517
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 265c15ab2ff13f2a50f0e75773550a824365b517
Author: Jiri Podivin <email address hidden>
Date: Fri Jul 16 08:39:22 2021 +0200

    Passes playbook to the validation action as a list

    Recent removal of the 'validations_libs.utils.convert_data'
    function, implemented by the Ief9459e914ea73fbd59a85c07a55c26078e0126a,
    resulted in a change of accepted argument types of
    the 'validations_libs.validation_actions' methods.

    This patch turns the passed argument from string into a list.

    Closes-bug: #1936465

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: I4e96f5a0e013de5abcde837dad3c5f9d5228dd4c
    (cherry picked from commit efdefd92de54d2dd0803f0367bf89bb577927037)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on validations-libs (master)

Change abandoned by "Jiri Podivin <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/validations-libs/+/801022
Reason: After discussion it was decided that the revert won't be necessary, considering the merge of other fixes.

Revision history for this message
Jiri Podivin (jpodivin) wrote :

Considering the actions regarding the patches I think we can consider this matter to be resolved.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 13.4.5

This issue was fixed in the openstack/python-tripleoclient 13.4.5 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 16.4.0

This issue was fixed in the openstack/python-tripleoclient 16.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 14.2.3

This issue was fixed in the openstack/python-tripleoclient 14.2.3 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers