tripleo

timemaster service fails to start on single domain with multiple interfaces

Bug #1934667 reported by Haresh
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Undecided
Haresh

Bug Description

Description:
Current jinja template (timemaster.conf.j2) is having below.

{% for domain, nic_list in ptp_dict.items() %}
[ptp_domain {{ domain }}]
interfaces {% for nic in nic_list %}
{{ nic }}{% if not loop.last %},{% endif %}
{% endfor %}

{% endfor %}

Due to this, when below is passed via THT,
PTPInterfaces: '0:eno1,0:eno2'

results in to
[ptp_domain 0]
interfaces eno1,eno2

timemaster service fails with this message.

[root@computedpdk-0 heat-admin]# systemctl status timemaster
● timemaster.service - Synchronize system clock to NTP and PTP time sources
   Loaded: loaded (/usr/lib/systemd/system/timemaster.service; enabled; vendor preset: disabled)
   Active: failed (Result: exit-code) since Mon 2021-07-05 12:12:05 UTC; 4s ago
  Process: 169838 ExecStart=/usr/sbin/timemaster -f /etc/timemaster.conf (code=exited, status=1/FAILURE)
 Main PID: 169838 (code=exited, status=1/FAILURE)

Jul 05 12:12:05 hareshcomputedpdk-0 systemd[1]: timemaster.service: Succeeded.
Jul 05 12:12:05 hareshcomputedpdk-0 systemd[1]: Stopped Synchronize system clock to NTP and PTP time sources.
Jul 05 12:12:05 hareshcomputedpdk-0 systemd[1]: Started Synchronize system clock to NTP and PTP time sources.
Jul 05 12:12:05 hareshcomputedpdk-0 timemaster[169838]: timemaster[532409.195]: ioctl SIOCETHTOOL failed: No such device
Jul 05 12:12:05 hareshcomputedpdk-0 timemaster[169838]: timemaster[532409.195]: failed to get time stamping info for eno1,eno2 <<<<<<<<<<<<<<<<<<<<
Jul 05 12:12:05 hareshcomputedpdk-0 systemd[1]: timemaster.service: Main process exited, code=exited, status=1/FAILURE
Jul 05 12:12:05 hareshcomputedpdk-0 systemd[1]: timemaster.service: Failed with result 'exit-code'.

Steps to reprodcue:
- Perform deployment with above mentioned PTPInternface value.

Expected result:
Ideally, we should have

[ptp_domain 0]
interfaces eno1 eno2 <<<<No ","

To start timemaster service successfully.

Actual result:
Failed timemaster service on the node.

Environment:
Logs & Config:
Refer description.

We need to replace "," with "" in order to generate working template.

Haresh (hakhande)
Changed in tripleo:
assignee: nobody → Haresh (hakhande)
status: New → In Progress
Revision history for this message
Haresh (hakhande) wrote :

Fixed jinja template and tried below combinations.

PTPInterfaces: '0:eno1'
[ptp_domain 0]
interfaces eno1 <<<<<<<<<<Ran overcloud deployment and timemaster service started successfully

PTPInterfaces: '0:eno1,0:eno2,0:eno4'
[ptp_domain 0]
interfaces eno1 eno2 eno4 <<<<<<<<<<Ran overcloud deployment and timemaster service started successfully

PTPInterfaces: '0:eno1,1:eno2,0:eno3'
[ptp_domain 0]
interfaces eno1 eno3
[ptp_domain 1]
interfaces eno2 <<<<<<<<<<Ran overcloud deployment and timemaster service started successfully

PTPInterfaces: '1:eno1,0:eno2,2:eno4'
[ptp_domain 1]
interfaces eno1
[ptp_domain 0]
interfaces eno2
[ptp_domain 2]
interfaces eno4 <<<<<<<<<<Ran overcloud deployment and timemaster service started successfully

Will submit patch soon.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/799565

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/799565
Committed: https://opendev.org/openstack/tripleo-ansible/commit/34c0d5d62c5b86f4646afe053220b0a9dc900168
Submitter: "Zuul (22348)"
Branch: master

commit 34c0d5d62c5b86f4646afe053220b0a9dc900168
Author: Haresh Khandelwal <email address hidden>
Date: Tue Jul 6 12:53:21 2021 +0530

    replacing "," with " " to avoid timemaster to
    consider it as a single interface

    Due to this, when below is passed via THT,
    PTPInterfaces: '0:eno1,0:eno2'

    results in to
    [ptp_domain 0]
    interfaces eno1,eno2

    timemaster[169838]: timemaster[532409.195]:
    ioctl SIOCETHTOOL failed: No such device
    timemaster[169838]: timemaster[532409.195]:
    failed to get time stamping info for eno1,eno2
    systemd[1]: timemaster.service: Main process
    exited, code=exited, status=1/FAILURE
    systemd[1]: timemaster.service: Failed with
    result 'exit-code'.

    Closes-Bug: #1934667
    Change-Id: I3f3182929571ec723f4e1d5a8e283755b3e17f95

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/799990

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/799991

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/799992

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/799993

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/799990
Committed: https://opendev.org/openstack/tripleo-ansible/commit/dba77c4b22dd52c692376dc2ed5c47b934dc0186
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit dba77c4b22dd52c692376dc2ed5c47b934dc0186
Author: Haresh Khandelwal <email address hidden>
Date: Tue Jul 6 12:53:21 2021 +0530

    replacing "," with " " to avoid timemaster to
    consider it as a single interface

    Due to this, when below is passed via THT,
    PTPInterfaces: '0:eno1,0:eno2'

    results in to
    [ptp_domain 0]
    interfaces eno1,eno2

    timemaster[169838]: timemaster[532409.195]:
    ioctl SIOCETHTOOL failed: No such device
    timemaster[169838]: timemaster[532409.195]:
    failed to get time stamping info for eno1,eno2
    systemd[1]: timemaster.service: Main process
    exited, code=exited, status=1/FAILURE
    systemd[1]: timemaster.service: Failed with
    result 'exit-code'.

    Closes-Bug: #1934667
    Change-Id: I3f3182929571ec723f4e1d5a8e283755b3e17f95
    (cherry picked from commit 34c0d5d62c5b86f4646afe053220b0a9dc900168)

tags: added: in-stable-wallaby
tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/799991
Committed: https://opendev.org/openstack/tripleo-ansible/commit/fd8df6f4eb773c9d078e636357456eaf9f0d047d
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit fd8df6f4eb773c9d078e636357456eaf9f0d047d
Author: Haresh Khandelwal <email address hidden>
Date: Tue Jul 6 12:53:21 2021 +0530

    replacing "," with " " to avoid timemaster to
    consider it as a single interface

    Due to this, when below is passed via THT,
    PTPInterfaces: '0:eno1,0:eno2'

    results in to
    [ptp_domain 0]
    interfaces eno1,eno2

    timemaster[169838]: timemaster[532409.195]:
    ioctl SIOCETHTOOL failed: No such device
    timemaster[169838]: timemaster[532409.195]:
    failed to get time stamping info for eno1,eno2
    systemd[1]: timemaster.service: Main process
    exited, code=exited, status=1/FAILURE
    systemd[1]: timemaster.service: Failed with
    result 'exit-code'.

    Closes-Bug: #1934667
    Change-Id: I3f3182929571ec723f4e1d5a8e283755b3e17f95
    (cherry picked from commit 34c0d5d62c5b86f4646afe053220b0a9dc900168)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/799992
Committed: https://opendev.org/openstack/tripleo-ansible/commit/d2cb0e7e18fbc819a5c69be0000ab5d35b5ea85c
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit d2cb0e7e18fbc819a5c69be0000ab5d35b5ea85c
Author: Haresh Khandelwal <email address hidden>
Date: Tue Jul 6 12:53:21 2021 +0530

    replacing "," with " " to avoid timemaster to
    consider it as a single interface

    Due to this, when below is passed via THT,
    PTPInterfaces: '0:eno1,0:eno2'

    results in to
    [ptp_domain 0]
    interfaces eno1,eno2

    timemaster[169838]: timemaster[532409.195]:
    ioctl SIOCETHTOOL failed: No such device
    timemaster[169838]: timemaster[532409.195]:
    failed to get time stamping info for eno1,eno2
    systemd[1]: timemaster.service: Main process
    exited, code=exited, status=1/FAILURE
    systemd[1]: timemaster.service: Failed with
    result 'exit-code'.

    Closes-Bug: #1934667
    Change-Id: I3f3182929571ec723f4e1d5a8e283755b3e17f95
    (cherry picked from commit 34c0d5d62c5b86f4646afe053220b0a9dc900168)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (stable/train)

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/799993
Committed: https://opendev.org/openstack/tripleo-ansible/commit/744bc7a9b4c8637821438eb13ed91db626656c69
Submitter: "Zuul (22348)"
Branch: stable/train

commit 744bc7a9b4c8637821438eb13ed91db626656c69
Author: Haresh Khandelwal <email address hidden>
Date: Tue Jul 6 12:53:21 2021 +0530

    replacing "," with " " to avoid timemaster to
    consider it as a single interface

    Due to this, when below is passed via THT,
    PTPInterfaces: '0:eno1,0:eno2'

    results in to
    [ptp_domain 0]
    interfaces eno1,eno2

    timemaster[169838]: timemaster[532409.195]:
    ioctl SIOCETHTOOL failed: No such device
    timemaster[169838]: timemaster[532409.195]:
    failed to get time stamping info for eno1,eno2
    systemd[1]: timemaster.service: Main process
    exited, code=exited, status=1/FAILURE
    systemd[1]: timemaster.service: Failed with
    result 'exit-code'.

    Closes-Bug: #1934667
    Change-Id: I3f3182929571ec723f4e1d5a8e283755b3e17f95
    (cherry picked from commit 34c0d5d62c5b86f4646afe053220b0a9dc900168)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible 3.2.0

This issue was fixed in the openstack/tripleo-ansible 3.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible 2.4.0

This issue was fixed in the openstack/tripleo-ansible 2.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible 1.5.5

This issue was fixed in the openstack/tripleo-ansible 1.5.5 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible 4.1.0

This issue was fixed in the openstack/tripleo-ansible 4.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible train-eol

This issue was fixed in the openstack/tripleo-ansible train-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.