Containers not updating with rpms from Depends-On patches.

[Sandeep Yadav]

Description:-

Containers are not updating with rpms from Depends-On patches.

In testpatch: https://review.rdoproject.org/r/c/testproject/+/28458/79//COMMIT_MSG

We added Depends-On following patches:-

https://review.opendev.org/c/openstack/tripleo-heat-templates/+/798328
https://review.opendev.org/c/openstack/tripleo-common/+/798327

New rpm from patch was installed correctly on the host but not in the container:-

Host:-

https://logserver.rdoproject.org/58/28458/79/check/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001-train-with-pre/57b6979/logs/undercloud/var/log/extra/package-list-installed.txt.gz

~~~
openstack-tripleo-common.noarch 11.7.1-0.20210629055939.d4fe1ff.el8 @gating-repo
openstack-tripleo-common-containers.noarch 11.7.1-0.20210629055939.d4fe1ff.el8 @gating-repo
~~~

rpm inside mistral_executor container:-

https://logserver.rdoproject.org/58/28458/79/check/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001-train-with-pre/57b6979/logs/undercloud/var/log/extra/podman/containers/mistral_executor/log/dnf.rpm.log.txt.gz

~~~
2021-06-28T18:44:41+0000 SUBDEBUG Installed: python3-tripleo-common-11.7.1-0.20210618005811.90725a9.el8.noarch
2021-06-28T18:44:41+0000 SUBDEBUG Installed: openstack-tripleo-common-11.7.1-0.20210618005811.90725a9.el8.noarc
~~~

This was noticed in train branch, could be present in other branches.

[Ronelle Landy (rlandy)]

It looks like the rpm from tripleo-heat-templates was updated:

*** mistral_executor rpm update info ***
openstack-tripleo-heat-templates.noarch 11.6.1-0.20210629055715.becfe49.el8 @gating-repo

https://logserver.rdoproject.org/58/28458/79/check/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001-train-with-pre/57b6979/logs/undercloud/var/log/extra/podman/containers/mistral_executor/log/dnf.rpm.log.txt.gz

2021-06-29T06:17:20+0000 SUBDEBUG Upgrade: openstack-tripleo-heat-templates-11.6.1-0.20210629055715.becfe49.el8.noarch
2021-06-29T06:17:20+0000 SUBDEBUG Upgraded: openstack-tripleo-heat-templates-11.6.1-0.20210625131448.1be1855.el8.noarch
2021-06-29T08:16:36+0000 INFO --- logging initialized ---

Checking tripleo-common change

[Ronelle Landy (rlandy)]

This may be a complete side point but ... when we build overcloud images in OVB, we don't add gating repo to the list of dib_yum_repo_conf

[Ronelle Landy (rlandy)]

One other observation:

Package openstack-tripleo-common-container-base.noarch 11.7.1-0.20210618005811.90725a9.el8 will be installed

is the container

openstack-tripleo-common-container-base noarch 11.7.1-0.20210618005811.90725a9.el8 delorean-component-tripleo 28 k

The following are listed in https://logserver.rdoproject.org/58/28458/79/check/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001-train-with-pre/57b6979/logs/undercloud/var/log/extra/package-list-installed.txt.gz:

openstack-tripleo-common.noarch 11.7.1-0.20210629055939.d4fe1ff.el8 @gating-repo
openstack-tripleo-common-containers.noarch 11.7.1-0.20210629055939.d4fe1ff.el8 @gating-repo
python3-tripleo-common.noarch 11.7.1-0.20210629055939.d4fe1ff.el8 @gating-repo

not sure about last package

[wes hayutin (weshayutin)]

@Sandeep please put up fresh DNM tripleo-common patch and rerun a test-project job so we can look at the results again.

Thanks

[Sandeep Yadav (sandeepyadav93)]

@Wes testing here https://review.rdoproject.org/r/c/testproject/+/28458

[wes hayutin (weshayutin)]

https://review.rdoproject.org/r/c/testproject/+/28458 has added tripleo-common to the mistral containers.. this is not a bug..

[Ronelle Landy (rlandy)]

[mistral@07e8be4c570b /]$ rpm -qa | grep tripleo-common
openstack-tripleo-common-containers-11.7.1-0.20210701182411.3a44fc2.el8.noarch
openstack-tripleo-common-11.7.1-0.20210701182411.3a44fc2.el8.noarch
python3-tripleo-common-11.7.1-0.20210701182411.3a44fc2.el8.noarch
openstack-tripleo-common-container-base-11.7.1-0.20210701182411.3a44fc2.el8.noarch

checked mistral-executor container ^^ after patch was rebased and job was in rerun

[Ronelle Landy (rlandy)]

https://logserver.rdoproject.org/58/28458/81/check/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001-train-with-pre/e61d6d8/logs/undercloud/var/log/extra/podman/container_updates_info.log.txt.gz

https://logserver.rdoproject.org/58/28458/81/check/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001-train-with-pre/e61d6d8/logs/undercloud/var/log/extra/podman/containers/mistral_executor/log/dnf.log.txt.gz

^^ note the upgrade here.

The patch needs to be rebased

[Sandeep Yadav (sandeepyadav93)]

Hello Ronelle,

Thanks and this is interesting, Just curious - Do we need to rebase the patch even if the patch is not in merge conflict for this to work?

The original issue, found in patchset 79: https://review.rdoproject.org/r/c/testproject/+/28458/79//COMMIT_MSG

Was depending on tripleo-common patch -
https://review.opendev.org/c/openstack/tripleo-common/+/798327 , this patch never faced merge conflict and was merged in its 1st patchset version.

[Ronelle Landy (rlandy)]

I don't think the patch was ever in merge conflict.
I simply rebased the patch from https://bugs.launchpad.net/tripleo/+bug/1933962/comments/5 - there was no merge conflict during the rebase.

When we install packages on the undercloud, we explicitly mark gating-repo as priority 1 and delorean-current as 10 and the drln components as 20.
In container updates we consider the update repos, gating, delorean-current and component