Deployment with PreNetworkConfig is failing because of wrong hiera.yaml content - The Lookup Configuration at '/etc/puppet/hiera.yaml' has wrong type, unrecognized key 'changed'

Bug #1933850 reported by Sandeep Yadav
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Alex Schultz

Bug Description

Description:

When using PreNetworkConfig, hiera.yaml output is wrong(ansible output is getting injected into hiera.yaml)

Background:

To test PreNetworkConfig interface in CI, we have defined a simple resource[1] in PreNetwork configuration but the deployment with PreNetworkConfig is failing because of wrong hiera.yaml content

~~~
Error: Evaluation Error: Error while evaluating a Function Call, Lookup of key 'lookup_options' failed: The Lookup Configuration at '/etc/puppet/hiera.yaml' has wrong type, unrecognized key 'changed'
~~~

[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/798254
[2] https://review.rdoproject.org/r/c/testproject/+/31954/4/.zuul.yaml

Error snippet:-

https://logserver.rdoproject.org/54/31954/4/check/tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001-with-pre/06e5df1/logs/undercloud/home/zuul/overcloud_deploy.log.txt.gz

~~~
2021-06-28 10:11:43 | 2021-06-28 10:11:43.620289 | fa163e53-a6c3-6ad8-3f05-000000003a6d | FATAL | Wait for puppet host configuration to finish | overcloud-novacompute-0 | error={"ansible_job_id": "519918335459.20733", "attempts": 4, "changed": true, "cmd": "set -o pipefail; puppet apply --modulepath=/etc/puppet/modules:/opt/stack/puppet-modules:/usr/share/openstack-puppet/modules --detailed-exitcodes --summarize --color=false /var/lib/tripleo-config/puppet_step_config.pp 2>&1 | logger -s -t puppet-user", "delta": "0:00:07.914990", "end": "2021-06-28 10:11:41.235447", "failed_when_result": true, "finished": 1, "msg": "non-zero return code", "rc": 1, "start": "2021-06-28 10:11:33.320457", "stderr": "<13>Jun 28 10:11:33 puppet-user: Warning: /etc/puppet/hiera.yaml: Use of 'hiera.yaml' version 3 is deprecated. It should be converted to version 5
<13>Jun 28 10:11:41 puppet-user: (file: /etc/puppet/hiera.yaml)
<13>Jun 28 10:11:41 puppet-user: Error: Evaluation Error: Error while evaluating a Function Call, Lookup of key 'lookup_options' failed: The Lookup Configuration at '/etc/puppet/hiera.yaml' has wrong type, unrecognized key 'changed'
<13>Jun 28 10:11:41 puppet-user: The Lookup Configuration at '/etc/puppet/hiera.yaml' has wrong type, unrecognized key 'skip_reason'
<13>Jun 28 10:11:41 puppet-user: The Lookup Configuration at '/etc/puppet/hiera.yaml' has wrong type, unrecognized key 'skipped' (file: /var/lib/tripleo-config/puppet_step_config.pp, line: 1, column: 1) on node overcloud-novacompute-0.localdomain", "stderr_lines": ["<13>Jun 28 10:11:33 puppet-user: Warning: /etc/puppet/hiera.yaml: Use of 'hiera.yaml' version 3 is deprecated. It should be converted to version 5", "<13>Jun 28 10:11:41 puppet-user: (file: /etc/puppet/hiera.yaml)", "<13>Jun 28 10:11:41 puppet-user: Error: Evaluation Error: Error while evaluating a Function Call, Lookup of key 'lookup_options' failed: The Lookup Configuration at '/etc/puppet/hiera.yaml' has wrong type, unrecognized key 'changed'", "<13>Jun 28 10:11:41 puppet-user: The Lookup Configuration at '/etc/puppet/hiera.yaml' has wrong type, unrecognized key 'skip_reason'", "<13>Jun 28 10:11:41 puppet-user: The Lookup Configuration at '/etc/puppet/hiera.yaml' has wrong type, unrecognized key 'skipped' (file: /var/lib/tripleo-config/puppet_step_config.pp, line: 1, column: 1) on node overcloud-novacompute-0.localdomain"], "stdout": "", "stdout_lines": []
~~~

ansible output is getting injected into hiera.yaml

https://logserver.rdoproject.org/54/31954/4/check/tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001-with-pre/06e5df1/logs/overcloud-novacompute-0/etc/puppet/hiera.yaml.txt.gz

~~~
---
:backends:
  - json
:json:
  :datadir: /etc/puppet/hieradata
:hierarchy:
changed: false
skip_reason: Conditional result was False
skipped: true
~~~

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)
Changed in tripleo:
status: Triaged → In Progress
description: updated
Changed in tripleo:
importance: Medium → High
tags: added: train-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/798343
Committed: https://opendev.org/openstack/tripleo-common/commit/2118998220805bc34e99dc5875bc6c711939fa5c
Submitter: "Zuul (22348)"
Branch: master

commit 2118998220805bc34e99dc5875bc6c711939fa5c
Author: Alex Schultz <email address hidden>
Date: Mon Jun 28 09:18:11 2021 -0600

    Rename hieradata_files result var

    This var is used internally in tripleo-ansible tripleo_hieradata role so
    the check result is overwriting the variable used to generate hiera.yaml

    Closes-Bug: #1933850
    Change-Id: I9b6cdad78f834c097226bd1681fa2e13791c33aa

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-common/+/798324

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/tripleo-common/+/798325

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/tripleo-common/+/798326

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/tripleo-common/+/798327

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/798324
Committed: https://opendev.org/openstack/tripleo-common/commit/d6b493303955911c9aa1568e3e0dbaaff250b161
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit d6b493303955911c9aa1568e3e0dbaaff250b161
Author: Alex Schultz <email address hidden>
Date: Mon Jun 28 09:18:11 2021 -0600

    Rename hieradata_files result var

    This var is used internally in tripleo-ansible tripleo_hieradata role so
    the check result is overwriting the variable used to generate hiera.yaml

    Closes-Bug: #1933850
    Change-Id: I9b6cdad78f834c097226bd1681fa2e13791c33aa
    (cherry picked from commit 2118998220805bc34e99dc5875bc6c711939fa5c)

tags: added: in-stable-wallaby
Changed in tripleo:
milestone: none → xena-2
assignee: nobody → Alex Schultz (alex-schultz)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/798326
Committed: https://opendev.org/openstack/tripleo-common/commit/66a5cc7e768ee9943103078fd7b0d70aae2f4f5d
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 66a5cc7e768ee9943103078fd7b0d70aae2f4f5d
Author: Alex Schultz <email address hidden>
Date: Mon Jun 28 09:18:11 2021 -0600

    Rename hieradata_files result var

    This var is used internally in tripleo-ansible tripleo_hieradata role so
    the check result is overwriting the variable used to generate hiera.yaml

    Closes-Bug: #1933850
    Change-Id: I9b6cdad78f834c097226bd1681fa2e13791c33aa
    (cherry picked from commit 2118998220805bc34e99dc5875bc6c711939fa5c)
    (cherry picked from commit d6b493303955911c9aa1568e3e0dbaaff250b161)
    (cherry picked from commit e7e69815c4ebaa84b2920f0603e437ec984cd83e)

tags: added: in-stable-ussuri
tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/train)

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/798327
Committed: https://opendev.org/openstack/tripleo-common/commit/d4fe1ff6449616aba3146fb54fc5b4304cbf13f1
Submitter: "Zuul (22348)"
Branch: stable/train

commit d4fe1ff6449616aba3146fb54fc5b4304cbf13f1
Author: Alex Schultz <email address hidden>
Date: Mon Jun 28 09:18:11 2021 -0600

    Rename hieradata_files result var

    This var is used internally in tripleo-ansible tripleo_hieradata role so
    the check result is overwriting the variable used to generate hiera.yaml

    Closes-Bug: #1933850
    Change-Id: I9b6cdad78f834c097226bd1681fa2e13791c33aa
    (cherry picked from commit 2118998220805bc34e99dc5875bc6c711939fa5c)
    (cherry picked from commit d6b493303955911c9aa1568e3e0dbaaff250b161)
    (cherry picked from commit e7e69815c4ebaa84b2920f0603e437ec984cd83e)
    (cherry picked from commit 66a5cc7e768ee9943103078fd7b0d70aae2f4f5d)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/798325
Committed: https://opendev.org/openstack/tripleo-common/commit/e7e69815c4ebaa84b2920f0603e437ec984cd83e
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit e7e69815c4ebaa84b2920f0603e437ec984cd83e
Author: Alex Schultz <email address hidden>
Date: Mon Jun 28 09:18:11 2021 -0600

    Rename hieradata_files result var

    This var is used internally in tripleo-ansible tripleo_hieradata role so
    the check result is overwriting the variable used to generate hiera.yaml

    Closes-Bug: #1933850
    Change-Id: I9b6cdad78f834c097226bd1681fa2e13791c33aa
    (cherry picked from commit 2118998220805bc34e99dc5875bc6c711939fa5c)
    (cherry picked from commit d6b493303955911c9aa1568e3e0dbaaff250b161)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 15.3.0

This issue was fixed in the openstack/tripleo-common 15.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 13.2.2

This issue was fixed in the openstack/tripleo-common 13.2.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 12.4.6

This issue was fixed in the openstack/tripleo-common 12.4.6 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 16.2.0

This issue was fixed in the openstack/tripleo-common 16.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common train-eol

This issue was fixed in the openstack/tripleo-common train-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.