Some NovaSchedulerAvailableFilters are ambigous

Bug #1932146 reported by Alexey Stupnikov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Undecided
Alexey Stupnikov

Bug Description

NovaSchedulerAvailableFilters is defined in ambiguous way in multiple NFV-related environment files [1]: nova.scheduler.filters.pci_passthrough_filter.PciPassthroughFilter is already included in nova.scheduler.filters.all_filters, so there is no need to provide it separately in the list.

[1]
environments/services-baremetal/neutron-sriov.yaml: NovaSchedulerAvailableFilters: ["nova.scheduler.filters.all_filters","nova.scheduler.filters.pci_passthrough_filter.PciPassthroughFilter"]
environments/ovs-hw-offload.yaml: NovaSchedulerAvailableFilters: ["nova.scheduler.filters.all_filters","nova.scheduler.filters.pci_passthrough_filter.PciPassthroughFilter"]
environments/services/neutron-sriov.yaml: NovaSchedulerAvailableFilters: ["nova.scheduler.filters.all_filters","nova.scheduler.filters.pci_passthrough_filter.PciPassthroughFilter"]
environments/services/neutron-ovn-sriov.yaml: NovaSchedulerAvailableFilters: ["nova.scheduler.filters.all_filters","nova.scheduler.filters.pci_passthrough_filter.PciPassthroughFilter"]
environments/services/neutron-mlnx-agent.yaml: NovaSchedulerAvailableFilters: ["nova.scheduler.filters.all_filters","nova.scheduler.filters.pci_passthrough_filter.PciPassthroughFilter"]

Changed in tripleo:
assignee: nobody → Alexey Stupnikov (astupnikov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)
Changed in tripleo:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796625
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/f94c38476e1c297c7ca5887b9563fa6673d780ba
Submitter: "Zuul (22348)"
Branch: master

commit f94c38476e1c297c7ca5887b9563fa6673d780ba
Author: Alexey Stupnikov <email address hidden>
Date: Wed Jun 16 12:57:59 2021 +0200

    Remove PciPassthroughFilter from NovaSchedulerAvailableFilters

    This patch removes PciPassthroughFilter from
    NovaSchedulerAvailableFilters definitions when
    "nova.scheduler.filters.all_filters" presents in the list:
    PciPassthroughFilter is part of nova.scheduler.filters.all_filters
    and there is no reason to define it separately.

    Closes-bug: #1932146
    Change-Id: Ief8f157c3a758c398aa0e6791dea75c035393ee8

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 15.1.0

This issue was fixed in the openstack/tripleo-heat-templates 15.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.