Master jobs are failing with ERROR oslo_service.service ironic.common.exception.DriverNotFoundInEntrypoint: Could not find the following items in the 'ironic.hardware.interfaces.deploy' entrypoint: iscsi.

[Sandeep Yadav]

Description:-
Master jobs are failing with ERROR oslo_service.service ironic.common.exception.DriverNotFoundInEntrypoint: Could not find the following items in the 'ironic.hardware.interfaces.deploy' entrypoint: iscsi.

Logs:-

OVB jobs failing during node import:-

https://logserver.rdoproject.org/openstack-periodic-integration-main/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001-master/6074246/logs/undercloud/home/zuul/overcloud_import_nodes.log.txt.gz
~~~
ironicclient.common.apiclient.exceptions.ServiceUnavailable: Resource temporarily unavailable, please retry. (HTTP 503)
~~~

https://logserver.rdoproject.org/openstack-periodic-integration-main/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001-master/6074246/logs/undercloud/var/log/containers/ironic/ironic-conductor.log.txt.gz
~~~
2021-06-09 01:56:59.278 7 ERROR oslo_service.service [req-a016ddb3-4f65-4621-8399-18648c2f5f0a - - - - -] Error starting thread.: ironic.common.exception.DriverNotFoundInEntrypoint: Could not find the following items in the 'ironic.hardware.interfaces.deploy' entrypoint: iscsi.
2021-06-09 01:56:59.278 7 ERROR oslo_service.service Traceback (most recent call last):
2021-06-09 01:56:59.278 7 ERROR oslo_service.service File "/usr/lib/python3.6/site-packages/oslo_service/service.py", line 807, in run_service
2021-06-09 01:56:59.278 7 ERROR oslo_service.service service.start()
2021-06-09 01:56:59.278 7 ERROR oslo_service.service File "/usr/lib/python3.6/site-packages/ironic/common/rpc_service.py", line 63, in start
2021-06-09 01:56:59.278 7 ERROR oslo_service.service self.manager.init_host(admin_context)
2021-06-09 01:56:59.278 7 ERROR oslo_service.service File "/usr/lib/python3.6/site-packages/ironic/conductor/base_manager.py", line 171, in init_host
2021-06-09 01:56:59.278 7 ERROR oslo_service.service self._collect_periodic_tasks(admin_context)
2021-06-09 01:56:59.278 7 ERROR oslo_service.service File "/usr/lib/python3.6/site-packages/ironic/conductor/base_manager.py", line 300, in _collect_periodic_tasks
2021-06-09 01:56:59.278 7 ERROR oslo_service.service for ifaces in driver_factory.all_interfaces().values():
2021-06-09 01:56:59.278 7 ERROR oslo_service.service File "/usr/lib/python3.6/site-packages/ironic/common/driver_factory.py", line 286, in all_interfaces
2021-06-09 01:56:59.278 7 ERROR oslo_service.service return {iface: interfaces(iface) for iface in _INTERFACE_LOADERS}
2021-06-09 01:56:59.278 7 ERROR oslo_service.service File "/usr/lib/python3.6/site-packages/ironic/common/driver_factory.py", line 286, in <dictcomp>
2021-06-09 01:56:59.278 7 ERROR oslo_service.service return {iface: interfaces(iface) for iface in _INTERFACE_LOADERS}
2021-06-09 01:56:59.278 7 ERROR oslo_service.service File "/usr/lib/python3.6/site-packages/ironic/common/driver_factory.py", line 277, in interfaces
2021-06-09 01:56:59.278 7 ERROR oslo_service.service return _get_all_drivers(_INTERFACE_LOADERS[interface_type]())
2021-06-09 01:56:59.278 7 ERROR oslo_service.service File "/usr/lib/python3.6/site-packages/ironic/common/driver_factory.py", line 338, in __init__
2021-06-09 01:56:59.278 7 ERROR oslo_service.service self.__class__._init_extension_manager()
2021-06-09 01:56:59.278 7 ERROR oslo_service.service File "/usr/lib/python3.6/site-packages/oslo_concurrency/lockutils.py", line 360, in inner
2021-06-09 01:56:59.278 7 ERROR oslo_service.service return f(*args, **kwargs)
2021-06-09 01:56:59.278 7 ERROR oslo_service.service File "/usr/lib/python3.6/site-packages/ironic/common/driver_factory.py", line 408, in _init_extension_manager
2021-06-09 01:56:59.278 7 ERROR oslo_service.service on_missing_entrypoints_callback=missing_callback))
2021-06-09 01:56:59.278 7 ERROR oslo_service.service File "/usr/lib/python3.6/site-packages/stevedore/named.py", line 85, in __init__
2021-06-09 01:56:59.278 7 ERROR oslo_service.service on_missing_entrypoints_callback(self._missing_names)
2021-06-09 01:56:59.278 7 ERROR oslo_service.service File "/usr/lib/python3.6/site-packages/ironic/common/driver_factory.py", line 399, in missing_callback
2021-06-09 01:56:59.278 7 ERROR oslo_service.service names=names, entrypoint=cls._entrypoint_name)
2021-06-09 01:56:59.278 7 ERROR oslo_service.service ironic.common.exception.DriverNotFoundInEntrypoint: Could not find the following items in the 'ironic.hardware.interfaces.deploy' entrypoint: iscsi.
2021-06-09 01:56:59.278 7 ERROR oslo_service.service
~~~

Minion job also failing with similiar error:-

https://logserver.rdoproject.org/openstack-periodic-integration-main/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-8-containers-undercloud-minion-master/14a69df/logs/subnode-1/var/log/containers/ironic/ironic-conductor.log.txt.gz

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/795520

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/795522

[Sandeep Yadav (sandeepyadav93)]

We spoke with dtantsur from Ironic,

He mentioned they've removed the iscsi deploy after a year of deprecation (and a few ML threads). We need to remove iscsi from enabled_deploy_interfaces too

We figured this is still mentioned in below places:-

Patches:-

https://review.opendev.org/c/openstack/tripleo-heat-templates/+/795522
https://review.opendev.org/c/openstack/python-tripleoclient/+/795520

Testing here: https://review.rdoproject.org/r/c/testproject/+/28458

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/795522
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/36e680fee003b20cad2f8f7845ef28f1109a5885
Submitter: "Zuul (22348)"
Branch: master

commit 36e680fee003b20cad2f8f7845ef28f1109a5885
Author: Sandeep Yadav <email address hidden>
Date: Wed Jun 9 17:23:30 2021 +0530

    Remove iscsi deploy interface from minion node

    This is continuation of patch[1] to remove iscsi deploy interface
    from minion node. iscsi deploy interface is removed after a year of
    deprecation (and a few ML threads)[2]

    [1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/749475
    [2] http://lists.openstack.org/pipermail/openstack-discuss/2020-September/016952.html

    Related-Bug: #1931417
    Change-Id: Id698a88a83e5218eb6254ae2fe4af6accf0a7306

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/795520
Committed: https://opendev.org/openstack/python-tripleoclient/commit/0f0352a5b856c44f589d1ab6adb189142216498a
Submitter: "Zuul (22348)"
Branch: master

commit 0f0352a5b856c44f589d1ab6adb189142216498a
Author: Arx Cruz <email address hidden>
Date: Wed Jun 9 13:41:17 2021 +0200

    Remove iscsi from IronicEnabledDeployInterfaces

    Iscsi is deprecated and should no longer be used

    Related-Bug: #1931417
    Change-Id: If6893492a854956b6b3b19cf5ed36411daf0a1b0

[Sandeep Yadav (sandeepyadav93)]

Fixes merged

https://review.opendev.org/c/openstack/tripleo-heat-templates/+/795522
https://review.opendev.org/c/openstack/python-tripleoclient/+/795520

Jobs are back to green:-
https://review.rdoproject.org/zuul/builds?job_name=periodic-tripleo-ci-centos-8-containers-undercloud-minion-master
https://review.rdoproject.org/zuul/builds?job_name=periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001-master

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/796451

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/796451
Committed: https://opendev.org/openstack/python-tripleoclient/commit/2ebf9d48a3190d2bebed7c6a02d7c32df4a7ef1a
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 2ebf9d48a3190d2bebed7c6a02d7c32df4a7ef1a
Author: Arx Cruz <email address hidden>
Date: Wed Jun 9 13:41:17 2021 +0200

    Remove iscsi from IronicEnabledDeployInterfaces

    Iscsi is deprecated and should no longer be used

    Related-Bug: #1931417
    Change-Id: If6893492a854956b6b3b19cf5ed36411daf0a1b0
    (cherry picked from commit 0f0352a5b856c44f589d1ab6adb189142216498a)