Do not sort IronicEnabled* interface parameter entries

Bug #1931161 reported by Steve Baker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
High
Steve Baker

Bug Description

Building these paramater entries[1] builds a set then sorts them when setting the heat parameter.

However the order of these entries are used by Ironic to attempt each interface until one is found which is compatible with the node, so a specific order is required to ensure all hardware types work.

[1] https://opendev.org/openstack/python-tripleoclient/src/branch/master/tripleoclient/v1/undercloud_config.py#L166

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)
Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/795183
Committed: https://opendev.org/openstack/python-tripleoclient/commit/05500120e07311389d6227d5e513fda422844321
Submitter: "Zuul (22348)"
Branch: master

commit 05500120e07311389d6227d5e513fda422844321
Author: Steve Baker <email address hidden>
Date: Tue Jun 8 09:10:17 2021 +1200

    Use explicit order for ironic enabled interfaces

    Ironic uses the order of enabled interfaces to attempt each interface
    in turn, so sorting the list will result in an incorrect order in some
    cases, which will cause deployment failures on some hardware.

    This change sets an explicit order for each interface.

    Change-Id: If2740767521453c7adfca56d942db97af13bfaf2
    Closes-Bug: #1931161

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/795422

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/795422
Committed: https://opendev.org/openstack/python-tripleoclient/commit/7f959bfdcddc7c1cd8fdd9fca611c5a610f346bc
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 7f959bfdcddc7c1cd8fdd9fca611c5a610f346bc
Author: Steve Baker <email address hidden>
Date: Tue Jun 8 09:10:17 2021 +1200

    Use explicit order for ironic enabled interfaces

    Ironic uses the order of enabled interfaces to attempt each interface
    in turn, so sorting the list will result in an incorrect order in some
    cases, which will cause deployment failures on some hardware.

    This change sets an explicit order for each interface.

    Change-Id: If2740767521453c7adfca56d942db97af13bfaf2
    Closes-Bug: #1931161
    (cherry picked from commit 05500120e07311389d6227d5e513fda422844321)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 17.0.0

This issue was fixed in the openstack/python-tripleoclient 17.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/799133

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/799134

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/train)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/799134
Committed: https://opendev.org/openstack/python-tripleoclient/commit/25adb4b85df21385d32a5f40a962ede09579d487
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 25adb4b85df21385d32a5f40a962ede09579d487
Author: Steve Baker <email address hidden>
Date: Tue Jun 8 09:10:17 2021 +1200

    Use explicit order for ironic enabled interfaces

    Ironic uses the order of enabled interfaces to attempt each interface
    in turn, so sorting the list will result in an incorrect order in some
    cases, which will cause deployment failures on some hardware.

    This change sets an explicit order for each interface.

    Change-Id: If2740767521453c7adfca56d942db97af13bfaf2
    Closes-Bug: #1931161
    (cherry picked from commit 05500120e07311389d6227d5e513fda422844321)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/799133
Committed: https://opendev.org/openstack/python-tripleoclient/commit/79637b03e3945a56c2f45b8cfecfb5c370354602
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 79637b03e3945a56c2f45b8cfecfb5c370354602
Author: Steve Baker <email address hidden>
Date: Tue Jun 8 09:10:17 2021 +1200

    Use explicit order for ironic enabled interfaces

    Ironic uses the order of enabled interfaces to attempt each interface
    in turn, so sorting the list will result in an incorrect order in some
    cases, which will cause deployment failures on some hardware.

    This change sets an explicit order for each interface.

    Change-Id: If2740767521453c7adfca56d942db97af13bfaf2
    Closes-Bug: #1931161
    (cherry picked from commit 05500120e07311389d6227d5e513fda422844321)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/train)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/799156
Committed: https://opendev.org/openstack/python-tripleoclient/commit/31dd5e7cfa8848b9562322b3c4a6c1327e62aba8
Submitter: "Zuul (22348)"
Branch: stable/train

commit 31dd5e7cfa8848b9562322b3c4a6c1327e62aba8
Author: Steve Baker <email address hidden>
Date: Tue Jun 8 09:10:17 2021 +1200

    Use explicit order for ironic enabled interfaces

    Ironic uses the order of enabled interfaces to attempt each interface
    in turn, so sorting the list will result in an incorrect order in some
    cases, which will cause deployment failures on some hardware.

    This change sets an explicit order for each interface.

    Change-Id: If2740767521453c7adfca56d942db97af13bfaf2
    Closes-Bug: #1931161
    (cherry picked from commit 05500120e07311389d6227d5e513fda422844321)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 16.3.0

This issue was fixed in the openstack/python-tripleoclient 16.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 14.2.2

This issue was fixed in the openstack/python-tripleoclient 14.2.2 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers