network-v2 - port ideompotency broken when migration from heat managed ports

Bug #1928711 reported by Harald Jensås
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
High
Harald Jensås

Bug Description

The port name is checked agains existing ports, however since THT uses the upper case network name and not the lower case name used by the network-v2 ansible module implementation the ansible module ends up creating new ports instead of adopting the ports already created by heat.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (master)
Changed in tripleo:
status: Triaged → In Progress
tags: added: wallaby-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/791812
Committed: https://opendev.org/openstack/tripleo-ansible/commit/f6bb0590178d5f51940154f8d69df59f462fb10b
Submitter: "Zuul (22348)"
Branch: master

commit f6bb0590178d5f51940154f8d69df59f462fb10b
Author: Harald Jensås <email address hidden>
Date: Mon May 17 14:08:23 2021 +0200

    Fix network-v2 node port idempotency

    Store the 'name_upper' of the networks in the
    network name id map, and use this name when
    setting the port name in port definitions.

    The port name is checked agains existing ports,
    and since THT uses the upper case network name
    when setting the port name the same (name_upper)
    must be used here.

    Closes-Bug: #1928711
    Related: blueprint network-data-v2-ports
    Change-Id: Iac7f351ce9ee965c17b6bc2956d140efe25ffcf4

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/792513

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/792513
Committed: https://opendev.org/openstack/tripleo-ansible/commit/a73d2ec0db91e41468985ac8433c7d301afe2d7d
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit a73d2ec0db91e41468985ac8433c7d301afe2d7d
Author: Harald Jensås <email address hidden>
Date: Mon May 17 14:08:23 2021 +0200

    Fix network-v2 node port idempotency

    Store the 'name_upper' of the networks in the
    network name id map, and use this name when
    setting the port name in port definitions.

    The port name is checked agains existing ports,
    and since THT uses the upper case network name
    when setting the port name the same (name_upper)
    must be used here.

    Closes-Bug: #1928711
    Related: blueprint network-data-v2-ports
    Change-Id: Iac7f351ce9ee965c17b6bc2956d140efe25ffcf4
    (cherry picked from commit f6bb0590178d5f51940154f8d69df59f462fb10b)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible 3.1.2

This issue was fixed in the openstack/tripleo-ansible 3.1.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible 4.0.0

This issue was fixed in the openstack/tripleo-ansible 4.0.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers