tripleo-ansible-inventory - fail generating from neutron when OVN MAC addr net/ports are present

Bug #1928469 reported by Harald Jensås
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
High
Harald Jensås

Bug Description

The inventory.py code fails with MissingMandatoryNeutronResourceTag when the OVN MAC address network or ports on this network is present.

This network, and ports on this network and other networks not associated with the stack should be ignored when creating the inventory.

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/790525
Committed: https://opendev.org/openstack/tripleo-common/commit/8877d0f80572431fbb636f47ea87b38fbd6f64f4
Submitter: "Zuul (22348)"
Branch: master

commit 8877d0f80572431fbb636f47ea87b38fbd6f64f4
Author: Harald Jensås <email address hidden>
Date: Tue May 11 00:18:39 2021 +0200

    Ignore OVN Bridge MAC net for inventory generation

    The OVN Bridge MAC network causes the inventory generation
    to be skipped due to MissingMandatoryNeutronResourceTag.
    This nework should be ignored here.

    Related: blueprint network-data-v2-ports
    Partial-Bug: #1928469
    Change-Id: Idb557d0c6c4356385cb05b2041b0bdaa5485367a

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/790527
Committed: https://opendev.org/openstack/tripleo-common/commit/14441478f944d0e07d107191d59fbb9024ced512
Submitter: "Zuul (22348)"
Branch: master

commit 14441478f944d0e07d107191d59fbb9024ced512
Author: Harald Jensås <email address hidden>
Date: Tue May 11 00:58:04 2021 +0200

    Skip port if missing mandatory tag

    Instead of bailing out if a port does not have the
    mandatory tags when building ports_by_role_and_host
    simply skip the port.

    Also skip ports for which the network_id is not in
    'networks_by_id'. This means it is a OVN bridge MAC
    port and should be ignored.

    Related: blueprint network-data-v2-ports
    Closes-Bug: #1928469
    Depends-On: https://review.opendev.org/790687
    Change-Id: Ife65326509e1d5fe7689c1baec17d902ec848c0d

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-common/+/791936

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-common/+/791937

tags: added: wallaby-backport-potential
Changed in tripleo:
status: Fix Released → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/791937
Committed: https://opendev.org/openstack/tripleo-common/commit/0a7cfe39343e302875b07b400c224bdd2e6be578
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 0a7cfe39343e302875b07b400c224bdd2e6be578
Author: Harald Jensås <email address hidden>
Date: Tue May 11 00:58:04 2021 +0200

    Skip port if it's on the OVN MAC Net

    Skip ports for which the network_id is not in
    'networks_by_id'. This means it is a OVN bridge MAC
    port and should be ignored.

    This change is the original patch, and the partial
    revert squashed in.

    Related: blueprint network-data-v2-ports
    Closes-Bug: #1928469
    Depends-On: https://review.opendev.org/790687
    Change-Id: Ife65326509e1d5fe7689c1baec17d902ec848c0d
    (cherry picked from commit 14441478f944d0e07d107191d59fbb9024ced512)
    (cherry picked from commit d3286377132ee6b0689a39e52858c07954711d13)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/792260
Committed: https://opendev.org/openstack/tripleo-common/commit/0a35f94522b93fde032a439eaa57fab0e7ee7ccf
Submitter: "Zuul (22348)"
Branch: master

commit 0a35f94522b93fde032a439eaa57fab0e7ee7ccf
Author: Harald Jensås <email address hidden>
Date: Wed May 19 15:53:03 2021 +0200

    Ignore non host ports by tag filtering

    Don't include tripleo_vip_net and tripleo_service_vip
    ports when generating the inventory.

    Closes-Bug: #1928469
    Change-Id: I3db93dd6aa493da6f1c059b1c49eb0fa0f3179fc

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-common/+/792888

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/792888
Committed: https://opendev.org/openstack/tripleo-common/commit/e25e523dfb24bdc2e466aecb94cb5e3b14f0dbd8
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit e25e523dfb24bdc2e466aecb94cb5e3b14f0dbd8
Author: Harald Jensås <email address hidden>
Date: Wed May 19 15:53:03 2021 +0200

    Ignore non host ports by tag filtering

    Don't include tripleo_vip_net and tripleo_service_vip
    ports when generating the inventory.

    Closes-Bug: #1928469
    Change-Id: I3db93dd6aa493da6f1c059b1c49eb0fa0f3179fc
    (cherry picked from commit 0a35f94522b93fde032a439eaa57fab0e7ee7ccf)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/791936
Committed: https://opendev.org/openstack/tripleo-common/commit/5c5b08b46e56de7fa2641aad84f17fd23b094adc
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 5c5b08b46e56de7fa2641aad84f17fd23b094adc
Author: Harald Jensås <email address hidden>
Date: Tue May 11 00:18:39 2021 +0200

    Ignore OVN Bridge MAC net for inventory generation

    The OVN Bridge MAC network causes the inventory generation
    to be skipped due to MissingMandatoryNeutronResourceTag.
    This nework should be ignored here.

    Related: blueprint network-data-v2-ports
    Partial-Bug: #1928469
    Change-Id: Idb557d0c6c4356385cb05b2041b0bdaa5485367a
    (cherry picked from commit 8877d0f80572431fbb636f47ea87b38fbd6f64f4)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 15.2.1

This issue was fixed in the openstack/tripleo-common 15.2.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 16.1.0

This issue was fixed in the openstack/tripleo-common 16.1.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers