glance-api.conf is broken after https://review.opendev.org/c/openstack/puppet-glance/+/790052

[Michele Baldessari]

In my master tls-e/bgp deployments glance is now broken, because of the following:
[root@controller-0 glance_api]# grep -ir '\["True"\]'
etc/glance/glance-api.conf:show_image_direct_url=["True"]
etc/glance/glance-api.conf:debug=["True"]
etc/glance/glance-api.conf:enable_proxy_headers_parsing=["True"]
etc/glance/glance-api.conf:swift_store_create_container_on_put=["True"]

[root@controller-0 glance_api]# grep -ir show_image_direct_url /etc/puppet/hieradata/
/etc/puppet/hieradata/service_configs.json: "glance::api::show_image_direct_url": true,

glance fails to start with:
2021-05-12T10:08:48.556462781+00:00 stderr F + echo 'Running command: '\''/usr/bin/glance-api --config-file /usr/share/glance/glance-api-dist.conf --config-file /etc/glance/glance-api.conf --config-file /etc/glance/glance-image-import.conf'\'''
2021-05-12T10:08:48.556462781+00:00 stderr F + exec /usr/bin/glance-api --config-file /usr/share/glance/glance-api-dist.conf --config-file /etc/glance/glance-api.conf --config-file /etc/glance/glance-image-import.conf
2021-05-12T10:08:49.777095040+00:00 stderr F argument --debug: Invalid Boolean value: ["True"]

I suspect the reason is the openstack config backend switch in https://review.opendev.org/c/openstack/puppet-glance/+/790052 ?

[Takashi Kajinami (kajinamit)]

This is interesting since we didn't hit that issue in puppet-glance gate.

In integration job
https://03c08251732a708a286f-1284cae0458f2bcc716f47c02bf394ec.ssl.cf2.rackcdn.com/790052/5/gate/puppet-openstack-integration-6-scenario004-tempest-centos-8-stream/ffbf87e/logs/etc/glance/glance-api.conf.txt

In tripleo job
https://46753125d39086c6aab0-a759d6b54561529b072782a6b0052389.ssl.cf1.rackcdn.com/790052/5/gate/puppet-glance-tripleo-standalone/87ac68a/logs/undercloud/var/lib/config-data/puppet-generated/glance_api/etc/glance/glance-api.conf

[Takashi Kajinami (kajinamit)]

Can we check some hieradata definitions in that controller-0 ? For example

$ sudo hiera -c /etc/puppet/hiera.yaml glance::api::logging::debug

[Michele Baldessari (michele)]

Thanks Takashi, this indeed turned out to be a broken overcloud image that had some older puppet files.