[queens-only] undercloud upgrade can fail when upgrading rabbitmq to major release

[Michele Baldessari]

Seen via https://bugzilla.redhat.com/show_bug.cgi?id=1957638

When we upgrade from rabbit from rabbitmq-server.noarch 0:3.6.15-4.el7ost to
rabbitmq-server.x86_64 0:3.7.28-2.el7ost the UC upgrade can fail with:
2021-05-05 18:39:42 | 2021-05-05 18:39:42,339 INFO: dib-run-parts Wed May 5 18:39:42 UTC 2021 Running /usr/libexec/os-refresh-config/configure.d/40-stop-running-epmd
2021-05-05 18:39:42 | 2021-05-05 18:39:42,346 INFO: + RESTART_RABBITMQ=
2021-05-05 18:39:42 | 2021-05-05 18:39:42,346 INFO: + systemctl is-active rabbitmq-server
2021-05-05 18:39:42 | 2021-05-05 18:39:42,353 INFO: active
2021-05-05 18:39:42 | 2021-05-05 18:39:42,353 INFO: + RESTART_RABBITMQ=yes
2021-05-05 18:39:42 | 2021-05-05 18:39:42,354 INFO: + systemctl stop rabbitmq-server
2021-05-05 18:39:47 | 2021-05-05 18:39:47,271 INFO: + pgrep -u rabbitmq -f 'epmd.*-daemon'
2021-05-05 18:39:47 | 2021-05-05 18:39:47,271 INFO: + xargs -r kill
2021-05-05 18:39:47 | 2021-05-05 18:39:47,290 INFO: + systemctl try-restart 'epmd@*'
2021-05-05 18:39:47 | 2021-05-05 18:39:47,304 INFO: Failed to try-restart [e-mail]: Unit is not loaded properly: Invalid argument.
2021-05-05 18:39:47 | 2021-05-05 18:39:47,304 INFO: See system logs and 'systemctl status [e-mail]' for details.
2021-05-05 18:39:47 | 2021-05-05 18:39:47,305 INFO: [2021-05-05 18:39:47,304] (os-refresh-config) [ERROR] during configure phase. [Command '['dib-run-parts', '/usr/libexec/os-refresh-config/configure.d']' returned non-zero exit status 1]
2021-05-05 18:39:47 | 2021-05-05 18:39:47,306 INFO:
2021-05-05 18:39:47 | 2021-05-05 18:39:47,306 INFO: [2021-05-05 18:39:47,305] (os-refresh-config) [ERROR] Aborting...
2021-05-05 18:39:47 | 2021-05-05 18:39:47,317 DEBUG: An exception occurred

We need to call daemon-reload there to fix the stale service files from the old rabbitmq package.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/c/openstack/instack-undercloud/+/790021

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Michele Baldessari <email address hidden>" on branch: stable/queens
Review: https://review.opendev.org/c/openstack/instack-undercloud/+/790021