net_config_override of undercloud.conf only works with json and not yaml

Bug #1927090 reported by Srinivas Atmakuri
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Undecided
Srinivas Atmakuri

Bug Description

Description
=======
On setting net_config_override parameter, the undercloud uses a JSON or YAML format template to configure the networking with os-net-config and ignores the network parameters set in undercloud.conf. We can this parameter when you want to configure bonding or add an option to the interface.

But currently, the net_config_override is only working when a JSON file is passed and doesn't work for YAML.

Steps to reproduce
============
1. Deploy undercloud with net_config_override set
2. Pass a yaml file as input instead of JSON

Expected result
==========
Expect the undercloud_config to read the yaml file passed

Actual result
========
Yaml file is not read, the code runs into errors

Changed in tripleo:
assignee: nobody → Srinivas Atmakuri (srini-atmakuri)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)
Changed in tripleo:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/789554
Committed: https://opendev.org/openstack/python-tripleoclient/commit/253bd6e7db425f2340e8b47319cd527a5210333d
Submitter: "Zuul (22348)"
Branch: master

commit 253bd6e7db425f2340e8b47319cd527a5210333d
Author: Srinivas Atmakuri <email address hidden>
Date: Tue May 4 17:15:32 2021 +0530

    make net_config_override of undercloud.conf work with yaml

    On setting net_config_override parameter, the undercloud uses
    a JSON or YAML format template to configure the networking
    with os-net-config and ignores the network parameters set in
    undercloud.conf. We can use this parameter when we want to
    configure bonding or add an option to the interface.

    This patch will allow net_config_override to work with a json
    or a yaml as an input.

    Closes-Bug: #1927090
    Change-Id: I5f5cec5a1622be4983b4d0db392453d1c489fa40

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 17.1.0

This issue was fixed in the openstack/python-tripleoclient 17.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-tripleoclient (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/821880

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/821884

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/821885

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/821886

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/train)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/821885
Committed: https://opendev.org/openstack/python-tripleoclient/commit/0f1c96f11ff3f863cc237629c17e1052df06df3f
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 0f1c96f11ff3f863cc237629c17e1052df06df3f
Author: Srinivas Atmakuri <email address hidden>
Date: Tue May 4 17:15:32 2021 +0530

    make net_config_override of undercloud.conf work with yaml

    On setting net_config_override parameter, the undercloud uses
    a JSON or YAML format template to configure the networking
    with os-net-config and ignores the network parameters set in
    undercloud.conf. We can use this parameter when we want to
    configure bonding or add an option to the interface.

    This patch will allow net_config_override to work with a json
    or a yaml as an input.

    Closes-Bug: #1927090
    Change-Id: I5f5cec5a1622be4983b4d0db392453d1c489fa40
    (cherry picked from commit 253bd6e7db425f2340e8b47319cd527a5210333d)
    (cherry picked from commit 06a82e0ebf5a9e2016bf17d1c272e650e11e9fe6)

tags: added: in-stable-victoria
tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/821886
Committed: https://opendev.org/openstack/python-tripleoclient/commit/17b333dc94c221ac71d7ec3f60148c0a0672377f
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 17b333dc94c221ac71d7ec3f60148c0a0672377f
Author: Srinivas Atmakuri <email address hidden>
Date: Tue May 4 17:15:32 2021 +0530

    make net_config_override of undercloud.conf work with yaml

    On setting net_config_override parameter, the undercloud uses
    a JSON or YAML format template to configure the networking
    with os-net-config and ignores the network parameters set in
    undercloud.conf. We can use this parameter when we want to
    configure bonding or add an option to the interface.

    This patch will allow net_config_override to work with a json
    or a yaml as an input.

    Closes-Bug: #1927090
    Change-Id: I5f5cec5a1622be4983b4d0db392453d1c489fa40
    (cherry picked from commit 253bd6e7db425f2340e8b47319cd527a5210333d)
    (cherry picked from commit 06a82e0ebf5a9e2016bf17d1c272e650e11e9fe6)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/train)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/821887
Committed: https://opendev.org/openstack/python-tripleoclient/commit/a6fcdbf0df3864af08a123caf35628d482d2234a
Submitter: "Zuul (22348)"
Branch: stable/train

commit a6fcdbf0df3864af08a123caf35628d482d2234a
Author: Srinivas Atmakuri <email address hidden>
Date: Tue May 4 17:15:32 2021 +0530

    make net_config_override of undercloud.conf work with yaml

    On setting net_config_override parameter, the undercloud uses
    a JSON or YAML format template to configure the networking
    with os-net-config and ignores the network parameters set in
    undercloud.conf. We can use this parameter when we want to
    configure bonding or add an option to the interface.

    This patch will allow net_config_override to work with a json
    or a yaml as an input.

    Closes-Bug: #1927090
    Change-Id: I5f5cec5a1622be4983b4d0db392453d1c489fa40
    (cherry picked from commit 253bd6e7db425f2340e8b47319cd527a5210333d)
    (cherry picked from commit 06a82e0ebf5a9e2016bf17d1c272e650e11e9fe6)
    (cherry picked from commit aa9996e13947058dea13692947bb35807b1f6b65)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/821880
Committed: https://opendev.org/openstack/python-tripleoclient/commit/f8ee246464c387a9733de3f0ea245d523098e42a
Submitter: "Zuul (22348)"
Branch: master

commit f8ee246464c387a9733de3f0ea245d523098e42a
Author: Steve Baker <email address hidden>
Date: Thu Dec 16 10:22:17 2021 +1300

    Don't assume json network config in validations

    Change I5f5cec5a1622be4983b4d0db392453d1c489fa40 allowed the
    net_config_override file to be yaml as well as json, but if
    enable_validations is true the _validate_no_ip_change assumes the
    network config is json.

    This change loads this file as yaml in _validate_no_ip_change.

    Change-Id: Iaeadf412865c059d252ffc7087db3853569b74ee
    Related-Bug: #1927090

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-tripleoclient (stable/wallaby)

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/823433

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-tripleoclient (stable/ussuri)

Related fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/823434

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-tripleoclient (stable/victoria)

Related fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/823435

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-tripleoclient (stable/train)

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/823436

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/821884
Committed: https://opendev.org/openstack/python-tripleoclient/commit/06a82e0ebf5a9e2016bf17d1c272e650e11e9fe6
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 06a82e0ebf5a9e2016bf17d1c272e650e11e9fe6
Author: Srinivas Atmakuri <email address hidden>
Date: Tue May 4 17:15:32 2021 +0530

    make net_config_override of undercloud.conf work with yaml

    On setting net_config_override parameter, the undercloud uses
    a JSON or YAML format template to configure the networking
    with os-net-config and ignores the network parameters set in
    undercloud.conf. We can use this parameter when we want to
    configure bonding or add an option to the interface.

    This patch will allow net_config_override to work with a json
    or a yaml as an input.

    Closes-Bug: #1927090
    Change-Id: I5f5cec5a1622be4983b4d0db392453d1c489fa40
    (cherry picked from commit 253bd6e7db425f2340e8b47319cd527a5210333d)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-tripleoclient (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/823433
Committed: https://opendev.org/openstack/python-tripleoclient/commit/86483150232e69ec29ae45c43012f7e494d3d09a
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 86483150232e69ec29ae45c43012f7e494d3d09a
Author: Steve Baker <email address hidden>
Date: Thu Dec 16 10:22:17 2021 +1300

    Don't assume json network config in validations

    Change I5f5cec5a1622be4983b4d0db392453d1c489fa40 allowed the
    net_config_override file to be yaml as well as json, but if
    enable_validations is true the _validate_no_ip_change assumes the
    network config is json.

    This change loads this file as yaml in _validate_no_ip_change.

    Change-Id: Iaeadf412865c059d252ffc7087db3853569b74ee
    Related-Bug: #1927090
    (cherry picked from commit f8ee246464c387a9733de3f0ea245d523098e42a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-tripleoclient (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/823435
Committed: https://opendev.org/openstack/python-tripleoclient/commit/09962681fe758ff9df113efa9da1a826e20c5928
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 09962681fe758ff9df113efa9da1a826e20c5928
Author: Steve Baker <email address hidden>
Date: Thu Dec 16 10:22:17 2021 +1300

    Don't assume json network config in validations

    Change I5f5cec5a1622be4983b4d0db392453d1c489fa40 allowed the
    net_config_override file to be yaml as well as json, but if
    enable_validations is true the _validate_no_ip_change assumes the
    network config is json.

    This change loads this file as yaml in _validate_no_ip_change.

    Change-Id: Iaeadf412865c059d252ffc7087db3853569b74ee
    Related-Bug: #1927090
    (cherry picked from commit f8ee246464c387a9733de3f0ea245d523098e42a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-tripleoclient (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/823434
Committed: https://opendev.org/openstack/python-tripleoclient/commit/d717ee59030d3acc1efdb9ef2a8f0e4a59b45c89
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit d717ee59030d3acc1efdb9ef2a8f0e4a59b45c89
Author: Steve Baker <email address hidden>
Date: Thu Dec 16 10:22:17 2021 +1300

    Don't assume json network config in validations

    Change I5f5cec5a1622be4983b4d0db392453d1c489fa40 allowed the
    net_config_override file to be yaml as well as json, but if
    enable_validations is true the _validate_no_ip_change assumes the
    network config is json.

    This change loads this file as yaml in _validate_no_ip_change.

    Change-Id: Iaeadf412865c059d252ffc7087db3853569b74ee
    Related-Bug: #1927090
    (cherry picked from commit f8ee246464c387a9733de3f0ea245d523098e42a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-tripleoclient (stable/train)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/823436
Committed: https://opendev.org/openstack/python-tripleoclient/commit/bd45a745da1ef95718a5a6893f510ef02937f1b5
Submitter: "Zuul (22348)"
Branch: stable/train

commit bd45a745da1ef95718a5a6893f510ef02937f1b5
Author: Steve Baker <email address hidden>
Date: Thu Dec 16 10:22:17 2021 +1300

    Don't assume json network config in validations

    Change I5f5cec5a1622be4983b4d0db392453d1c489fa40 allowed the
    net_config_override file to be yaml as well as json, but if
    enable_validations is true the _validate_no_ip_change assumes the
    network config is json.

    This change loads this file as yaml in _validate_no_ip_change.

    Change-Id: Iaeadf412865c059d252ffc7087db3853569b74ee
    Related-Bug: #1927090
    (cherry picked from commit f8ee246464c387a9733de3f0ea245d523098e42a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 13.4.6

This issue was fixed in the openstack/python-tripleoclient 13.4.6 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 14.3.0

This issue was fixed in the openstack/python-tripleoclient 14.3.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers