Implement missing unittests for ansible custom libraries

Bug #1922726 reported by Jiri Podivin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Medium
Jiri Podivin

Bug Description

Unit test coverage needs to be increased and tests improved.
(This bug is for work tracking only.)

Jiri Podivin (jpodivin)
Changed in tripleo:
assignee: nobody → Jiri Podivin (jpodivin)
status: New → In Progress
Changed in tripleo:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-validations (master)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-validations (master)

Change abandoned by "Jiri Podivin <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/tripleo-validations/+/785588
Reason: abandoned in favor of https://review.opendev.org/c/openstack/tripleo-validations/+/786876

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-validations (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-validations/+/778986
Committed: https://opendev.org/openstack/tripleo-validations/commit/59fdd2d1ee44403563ec9dcab2a17038d446dc0f
Submitter: "Zuul (22348)"
Branch: master

commit 59fdd2d1ee44403563ec9dcab2a17038d446dc0f
Author: Jiri Podivin <email address hidden>
Date: Fri Mar 5 17:16:44 2021 +0100

    Test folder structure rearranged.

    Patch prepares ground for further work on tripleo_validations
    unit tests.

    Datastructures used for testing were factored out.

    __init__.py files for lookup plugins and library tests were added.
    Together with minimal docstring.

    .gitingore was updated to ignore stestr files.

    test-requirements.txt and requirements.txt were updated to include
    all necessary dependencies

    Depends-On: https://review.rdoproject.org/r/c/openstack/tripleo-validations-distgit/+/32545

    Closes-Bug: #1922726

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: If67992bec97831cc45b46e33af234a9444c5ae4c

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/openstack/tripleo-validations/+/782377
Committed: https://opendev.org/openstack/tripleo-validations/commit/f840eb6b23bd461bb5932236c974c5f994d0e479
Submitter: "Zuul (22348)"
Branch: master

commit f840eb6b23bd461bb5932236c974c5f994d0e479
Author: Jiri Podivin <email address hidden>
Date: Tue Mar 23 09:18:31 2021 +0100

    Minor test improvement for ceph_pools_pg_protection

    Tests now include check of run function and
    required module attributes.

    Closes-Bug: #1922726

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: Id21cd63fff6e8cd2f0aad452ad8f1a5d8ce87930

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on validations-common (master)

Change abandoned by "Jiri Podivin <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/validations-common/+/780795
Reason: No longer needed after merge of testenve adjustment.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by "Jiri Podivin <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/validations-common/+/781787
Reason: The validation.py was removed during the move to new CLI. Because of that this patch is no longer necessary.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-validations 14.1.0

This issue was fixed in the openstack/tripleo-validations 14.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to validations-common (master)

Reviewed: https://review.opendev.org/c/openstack/validations-common/+/779810
Committed: https://opendev.org/openstack/validations-common/commit/50eea5edb7325344a1b4b802470fb7945f03e47b
Submitter: "Zuul (22348)"
Branch: master

commit 50eea5edb7325344a1b4b802470fb7945f03e47b
Author: Jiri Podivin <email address hidden>
Date: Wed Mar 10 16:22:51 2021 +0100

    Improved test coverage for library/warn.py

    Test of module initiation, presence of required attributes
    and basic yaml processing.

    Closes-bug: #1922726

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: I030e43b6b0c1fbd7d1e42627a60dfe5741d95d40

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/openstack/validations-common/+/780020
Committed: https://opendev.org/openstack/validations-common/commit/b50b40c4ab6383c0a32ac89cfd7525ed9eb0e44e
Submitter: "Zuul (22348)"
Branch: master

commit b50b40c4ab6383c0a32ac89cfd7525ed9eb0e44e
Author: Jiri Podivin <email address hidden>
Date: Thu Mar 11 16:32:21 2021 +0100

    Improved test coverage for library/advanced_format.py

    Increases test coverage to almost 100% of statements.
    The exception being the initial call of main.

    Closes-Bug: #1922726

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: Id6f0ab2dec9b52a6f765626c7c85831f85771dd0

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/openstack/validations-common/+/780922
Committed: https://opendev.org/openstack/validations-common/commit/29575dda05132bf8e203ba0ccc8df1efa8e61e65
Submitter: "Zuul (22348)"
Branch: master

commit 29575dda05132bf8e203ba0ccc8df1efa8e61e65
Author: Jiri Podivin <email address hidden>
Date: Tue Mar 16 17:12:46 2021 +0100

    Test for callback initiation.

    Checks for presence of required atributes,
    basic functionality of the init method
    and the current_time module function.

    Closes-Bug: #1922726

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: I2e9a4640fad0f9c44b5503d53ea2613a416c6e18

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-validations (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-validations/+/786875
Committed: https://opendev.org/openstack/tripleo-validations/commit/30fc68853dc55dc21c3255a5b0877306a3de2557
Submitter: "Zuul (22348)"
Branch: master

commit 30fc68853dc55dc21c3255a5b0877306a3de2557
Author: Jiri Podivin <email address hidden>
Date: Fri Apr 9 11:07:07 2021 +0200

    Test classes for lookup plugins

    Extra imports are mocked and fakes.py is imported in
    every test module.

    This should prevent requirements bloat, along with associated
    gate issues.

    Closes-Bug: #1922726
    Change-Id: I73991977005838ae7c5eaf59e5456f9c92811d67

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/openstack/tripleo-validations/+/786876
Committed: https://opendev.org/openstack/tripleo-validations/commit/ec3b1ab0d991013a03025403eaf698c4f43e1a5b
Submitter: "Zuul (22348)"
Branch: master

commit ec3b1ab0d991013a03025403eaf698c4f43e1a5b
Author: Jiri Podivin <email address hidden>
Date: Mon Apr 19 15:22:07 2021 +0200

    Tests of lookup plugin initiation for glance_images.py

    Closes-Bug: #1922726

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: Ib730c4bff12404b6c533db867531b2406f52eafc

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/openstack/tripleo-validations/+/779291
Committed: https://opendev.org/openstack/tripleo-validations/commit/fdd309f383401550b425fef148ebcd74f7cfd323
Submitter: "Zuul (22348)"
Branch: master

commit fdd309f383401550b425fef148ebcd74f7cfd323
Author: Jiri Podivin <email address hidden>
Date: Mon Mar 8 17:22:06 2021 +0100

    New utils.py tests

    Unit tests covering get_nested and geth_auth_session functions.
    Further tests will be submitted as a follow up dependent review.

    Closes-Bug: #1922726

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: I0ed44d1014d10e632beea44f2665a256453c2499

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to validations-libs (master)

Reviewed: https://review.opendev.org/c/openstack/validations-libs/+/777100
Committed: https://opendev.org/openstack/validations-libs/commit/648c2d81c4fbca2343abfa5cf0a6d0562f94c760
Submitter: "Zuul (22348)"
Branch: master

commit 648c2d81c4fbca2343abfa5cf0a6d0562f94c760
Author: Jiri Podivin <email address hidden>
Date: Tue Feb 23 11:22:03 2021 +0100

    Expanded and increased strictness of the ansible.py tests

    Where possible, the tests were adjusted to not only assert
    on the last call made, but on it being a single call.

    Closes-Bug: #1922726

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: I2cd15f3cdcd79705173ed48d555fec35e39b5b71

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/openstack/validations-libs/+/780849
Committed: https://opendev.org/openstack/validations-libs/commit/7cdeeebe30ba363c14693d2916f85d84e322e0f4
Submitter: "Zuul (22348)"
Branch: master

commit 7cdeeebe30ba363c14693d2916f85d84e322e0f4
Author: Jiri Podivin <email address hidden>
Date: Tue Mar 16 14:40:00 2021 +0100

    Cover now prints line numbers

    Cover reports are more comprehensive and useful
    for further test improvement.

    Also removes unnecessary parameter, source,
    of the coverage call, as it is defined inside
    .coveragerc file.

    Similar to the patch for validations-common.

    Closes-bug: #1922726

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: Ife1e84e0a9e605144a2d7dfb8160ed5eab49bc41

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-validations 15.0.0

This issue was fixed in the openstack/tripleo-validations 15.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/validations-common 1.2.0

This issue was fixed in the openstack/validations-common 1.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/validations-libs 1.2.0

This issue was fixed in the openstack/validations-libs 1.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to validations-libs (master)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers