Remove ovn-cms-options from OVS when OVNCMSOptions under Role Parameters is set to ""

[Purandhar Sairam Mannidi]

When we deploy a tripleo environment with OVN+DVR, we set OVNCMSOptions under Compute Role parameters as 'chassis-as-gw'. If we would like disable DVR and remove OVNCMSOptions then, just setting OVNCMSOptions to "" is not sufficient as tripleo-heat-templates would not act on the value and the computes are left with existing ovn-cms-options under external_ids in Open_vSwitch table of OVS.

The way to check when the compute is configured as gateway is run `ovs-vsctl get open . 'external_ids:ovn-cms-options'` and see if the option is set to chassis-as-gw

[Brendan Shephard (bshephar)]

Proposed fix:
https://review.opendev.org/c/openstack/tripleo-heat-templates/+/783222

This worked for me:

1. Apply the patch to THT
2. On a Compute node:
ovs-vsctl set open . external_ids:ovn-cms-options=enable-chassis-as-gw
3. Add env file:
~~~
parameter_defaults:
  OVNCMSOptions: ""
~~~
4. Re-run deployment with included env file:

Before:
{hostname=overcloud-novacompute-0.bne-home.net, ovn-bridge=br-int, ovn-bridge-mappings="datacentre:br-ex", ovn-cms-options=enable-chassis-as-gw, ovn-encap-ip="172.16.0.39", ovn-encap-type=geneve, ovn-match-northd-version="true", ovn-openflow-probe-interval="60", ovn-remote="tcp:172.16.2.207:6642", ovn-remote-probe-interval="60000", rundir="/var/run/openvswitch", system-id="4b01dab1-8778-42c5-93fa-1e9dffe2f0de"}

After:
[root@overcloud-novacompute-0 ~]# ovs-vsctl get open . external_ids
{hostname=overcloud-novacompute-0.bne-home.net, ovn-bridge=br-int, ovn-bridge-mappings="datacentre:br-ex", ovn-encap-ip="172.16.0.39", ovn-encap-type=geneve, ovn-match-northd-version="true", ovn-openflow-probe-interval="60", ovn-remote="tcp:172.16.2.207:6642", ovn-remote-probe-interval="60000", rundir="/var/run/openvswitch", system-id="4b01dab1-8778-42c5-93fa-1e9dffe2f0de"}

[Takashi Kajinami (kajinamit)]

Just a note for easy reference in future.
This issue was initially reported in https://bugzilla.redhat.com/show_bug.cgi?id=1943488

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/786099

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/786100

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/786102

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/786099
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/b276cb24b079795051dc1f4af55ed53de72bb9bd
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit b276cb24b079795051dc1f4af55ed53de72bb9bd
Author: Purandhar Sairam Mannidi <email address hidden>
Date: Fri Mar 26 18:43:01 2021 +1000

    Remove ovn-cms-options from OVS when OVNCMSOptions is set to ""

    This patch resolves issue where ovn-cms-options is left when OVNCMSOptions
    is changed to "" in RoleParameters on an existing OVN+DVR+HA environment.

    Closes-Bug: #1922168
    Change-Id: I649b2a1f7babd86d1fb6a2ebd68b22a3560eb885
    (cherry picked from commit 180fcf18bfaf5c433902b6dd0d738e5f6523dd98)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/786100
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/59fcd220fd83904f6003ab2076ca321ca0f7812a
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 59fcd220fd83904f6003ab2076ca321ca0f7812a
Author: Purandhar Sairam Mannidi <email address hidden>
Date: Fri Mar 26 18:43:01 2021 +1000

    Remove ovn-cms-options from OVS when OVNCMSOptions is set to ""

    This patch resolves issue where ovn-cms-options is left when OVNCMSOptions
    is changed to "" in RoleParameters on an existing OVN+DVR+HA environment.

    Closes-Bug: #1922168
    Change-Id: I649b2a1f7babd86d1fb6a2ebd68b22a3560eb885
    (cherry picked from commit 180fcf18bfaf5c433902b6dd0d738e5f6523dd98)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/786102
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/6c62cf789e25cccbe53bb20c46961a5bc392feab
Submitter: "Zuul (22348)"
Branch: stable/train

commit 6c62cf789e25cccbe53bb20c46961a5bc392feab
Author: Purandhar Sairam Mannidi <email address hidden>
Date: Fri Mar 26 18:43:01 2021 +1000

    Remove ovn-cms-options from OVS when OVNCMSOptions is set to ""

    This patch resolves issue where ovn-cms-options is left when OVNCMSOptions
    is changed to "" in RoleParameters on an existing OVN+DVR+HA environment.

    Closes-Bug: #1922168
    Change-Id: I649b2a1f7babd86d1fb6a2ebd68b22a3560eb885
    (cherry picked from commit 180fcf18bfaf5c433902b6dd0d738e5f6523dd98)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 14.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 13.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 12.4.4 release.